CODERS PLEASE DISCUSS!!! Pre-Datastore modifications with XML-files (UPDATE 28-7)

[merk]

Ive just hit a major major snag with my code using

PHP Code:

$vbulletin->datastore->fetch(array('menu_left', 'menu_right')); 


to fetch data.

It appears in global_start it occurs too late in the process and overwrites certain datastore objects (because it requeries all default datastore objects and fetches them as well) causing the time offset to be incorrect.

How do you guys currently retrieve datastore objects? Just a query? File edits?

[Andreas]

File Edits.
If you do it in config.php it will be a one-time edit

[merk]

config.php - interesting.

What does the variable look like?

At the moment im happy to introduce a query for this purpose until a proper solution is made.

[Andreas]

PHP Code:

if (THIS_SCRIPT == 'whatever')
{
$specialtemplates[] = 'item';
} 


[Boofo]

Here's what I use the Kirby came up with and it works excellently by the way.

Also, you don't need an if THIS_SCRIPT with it doing it this way. It works globablly. I have one for forumdisplay and 2 for forumhome in there and they all work fine.

PHP Code:

 // ****** SPECIALTEMPLATES *****
// Add any specialtemplates here for any products or mods that use the datastore, to save
// from re-doing file edits on an upgrade or re-install of vBulletin (until they give us a better
// way to do it, anyway). Thanks to KirbyDE for the how-to on doing this.
global $specialtemplates;
$specialtemplates = array_merge(
$specialtemplates, array(
'forumstatscache',
)); 


I added the little description to make it look more uniformly.

[merk]

If you put that into config.php, you will only be able to load datastore objects for every page.

THIS_SCRIPT checks allow you to load datastore objects for a per-page basis.

[Marco van Herwaarden]

Although this is a nice and simple solution, it does load everything for every page as mentioned. Also i wouldn't be so happy if all hacks where coded this way, it would be a huge config.php loaded on every page.

[Andreas]

Honestly, class_core.php is way bigger then config.php would ever get even if every Hack added Items there

But as mentioned, it should be wrapped in if (THIS_SCRIPT == ... )

[Boofo]

Originally Posted by merk

If you put that into config.php, you will only be able to load datastore objects for every page.

THIS_SCRIPT checks allow you to load datastore objects for a per-page basis.

Well, since I only have 3 of them, that is not a big issue, but yes, you could do it that way. This way, if I want to use it board-wide, I can.

[merk]

I am using one extra query to load my datastore items.

Just use global_start hook to do a single query which will load the items you need. I am currently happy with one extra light weight query.