Improved PM Popup JavaScript

What's it do?
Simple: it checks to see how many new PMs a user has. If they've only got one (which is usually the case...I don't think many people get tons of new PMs), the popup JavaScript alert displayed to them will let them know who sent them the message, what it's title is, and, rather than take them to the Inbox, it'll take them directly to the message.

If there's more than one, it'll display a more vague message, letting them know just how many new messages they have, and redirecting them to their Inbox (which is where the current popup directs you). Anyway, here's the hack:


Open global.php. Around line 266 you should see the following:

$newpmmsg=1;

RIGHT below it, place this (REPLACE your current code for this hack with the code below, if you happen to be one of the few people who actually intalled this originally from the Beta Hacks forum. )

  $latest_pm = $DB_site->query("SELECT p.privatemessageid AS pm_popup_id, p.title AS pm_popup_title, u.username AS pm_popup_username FROM privatemessage p, user u WHERE messageread = 0 AND p.userid = $bbuserinfo[userid] AND p.fromuserid = u.userid ORDER BY dateline DESC");
  $hack_pm_total  = $DB_site->num_rows($latest_pm);
  
    if ($hack_pm_total > 1) {
      eval("\$pm_popup_text = \"".gettemplate('pm_popup_multiple')."\";");
      eval("\$pm_popup_url  = \"".gettemplate('pm_popup_url_multiple')."\";");
    } else {
      extract($DB_site->fetch_array($latest_pm));
      eval("\$pm_popup_text = \"".gettemplate('pm_popup')."\";");
      eval("\$pm_popup_url  = \"".gettemplate('pm_popup_url')."\";");
    }

Now, create the four new templates. I've attached a file to this post containing the names of the four templates, and the text I've used to populate them -- which will probably be the same text and such you'll want to use. Don't be intimidated...they're all very small.

After that, edit your head_newpm template to make use of the new variables. Here's my use of it (highly suggested):

<script language="JavaScript">
<!--
function confirm_newpm() {
	input_box = confirm("$pm_popup_text");
	if (input_box == true) { // Output when OK is clicked
		second_box = confirm("Open in new window?\n\n(Press cancel to open your $inboxname in the current window.)");
		if (second_box == true) {
			window.open('$pm_popup_url','pmnew','width=600,height=500,menubar=yes,scrollbars=yes,toolbar=yes,location=yes,directories=yes,resizable=yes,top=50,left=50'); 
		} else {
			window.location = "$pm_popup_url";
		}
	} else {
	// Output when Cancel is clicked
	}
}
-->
</script>

Enjoy.

[CeleronXL]

I don't know if anyone's done this yet, but I need to keep tabs on all the hacks I install. The only directions in the directions file itself were the new templates, so I made this set of instructions that were included in the first post. If anyone else wants them to keep tabs on the whole thing, here's the entire set of instructions.

[akowacko]

i have the welcome panel hack. no i added your hack and the PM box is gone. i revert to my original files and the pm is still gone. can't see a thing. please help.

[akowacko]

i'm having trouble looking for the original head_newpm template. can someone check if this is the original one?

<script language="JavaScript">
<!--
function confirm_newpm() {
input_box=confirm("You have a new private message. Click OK to view it, or cancel to hide this prompt.");
if (input_box==true) { // Output when OK is clicked
second_box=confirm("Open in new window?\n\n(Press cancel to open your $inboxname in the current window.)");
if (second_box==true) {
window.open('private.php?s=$session[sessionhash]','pmnew','width=600,height=500,menubar=yes,scroll bars=yes,toolbar=yes,location= yes,directories=yes,resizable=yes,top=50,left=50') ;
} else {
window.location="private.php?s=$session[sessionhash]";
}
} else {
// Output when Cancel is clicked
}
}
// -->
</script>

thanks!

[TWTCommish]

I don't think we're allowed to post entire templates.

[Boofo]

I tried installing this hack and all I could get where script errors. (Line 79). I realluy wanted it, but it doesn't look like it wants to work with my setup. If anybody has any updates that might make it work for me, I'm willing to try them.

[TWTCommish]

Check your vBulletin Options to make sure you do NOT have each template beginning and ending with an HTML comment. If you do, the hack won't work.

[Boofo]

I already checked that when you mentioned it in the other post. I reverted back to the standard popup and everything works like it should now. I'd like to get this one going if you can think of anything.

[TWTCommish]

Hmmm. What error do you get? I'm wondering if the title of the PM or the username of the person who sent it might be interfering...

[Boofo]

The title was Test and the name of the sender was Brandon. Normal stuff. It was the same kind of error that other user got at around line 88, only mine was 79. An object expected error, or something like that.

[69-FLy-gUy]

hmm. I am having a little problem.. the PM box won't Pop up....

when i view the source.. the js is there. and says the info, but it won't pop up.