[VB3 RC3] Attachments in private messages

Unsupported. VB3.5 version is here:
https://vborg.vbsupport.ru/showthread.php?t=91220

Tested on 3.0.3

This hack enables you to send attachments in a private message. This feature was really useful to me in vb2 and I kind of missed it on vb3 so I rehacked it myself.

When a user writes a private message they will be given the option to add an attachment, the same as when writing a post. It uses the same rules you have defined for a convencional attachment including file types, quotas, etc. It is only an extension for attachments to be used in private messages.

As always it is advised to backup your files before hacking in case you want to go back, this is some big hack including modification of multiple files, some templates and adding two extra columns in the database tables.

Instructions are provided in the txt, and some screenshots on where the attachment option appears.

Info for hackers:
You may modify, improve, upgrade, redistribute this hack, include it
in another hack or yours or translate it provided you do it free of
charge and you distribute it in www.vbulletin.org at least, there is no
need to pm me asking for permission
Some portions of the code are (c) Jelsoft Enterprises Ltd.

Edit by MarcoH64:
Because of multiple requests to make this hack work on vB3.0.7 i created upgrade instructions. These upgrade instructions can be followed after the original instructions (the 3.0.3 version). The original coder can not be held responsible for my modification.

[Boofo]

Then how can we save an attachment for later without having to download it? Is there anyway to set it up so if someone does decide to delete their attachment, then and only then it would transfer ownership to whoever still has the message that was sent to them with the attachment? On bigger sites, I can see what you're saying might make sense as to not fill up the site with attachments. But on a small site, like mine, there is no worry there yet. Besides, the Admin can see and delete any attachments in the Admin CP if it looks like it is starting to get out of hand.

[Oblivion Knight]

Originally Posted by Kentaurus

That's a template thing, if the normal attachments appear framed then the attachments in private message should, too. Try attaching a jpg instead or a gif to see if it changes. How does it show in a normal postbit?

Aha.! Correct..
This is a problem with the .gif extension for some reason (on normal posts too)..

Hmm.. *scratches head*


[high][EDIT][/high]
Hmm.. Just noticed vB.org has this very same problem.
https://vborg.vbsupport.ru/showthrea...586#post474586

[high][EDIT 2][/high]
Ok, this is due to image sizes.. My bad..

[Boofo]

That gif in the link has the box around it ok. What are you seeing?

EDIT: What sizes are we talking about?

[Oblivion Knight]

Originally Posted by Boofo

EDIT: What sizes are we talking about?

The maximum pixel size w/h an image can be before it is shown as "thumbnail" form..

Concluding that this is default behaviour and not a bug with the mod..
Awesome work Kentaurus..

[Boofo]

LOL I know WHAT it is, I was curious about what actual size file is messing it up.

[Oblivion Knight]

Ahh sorry.. It IS 2am here afterall..
Anything below the default w AND h of 100 pixels here at vB.org..

[NuclioN]

Looks great but..

* PM attachment is showing up on the forumindex trough this mod: https://vborg.vbsupport.ru/showthread.php?t=61244

* javascript error sendmail: (see attachment)

* Kan not see the send attachment in PM

[Kentaurus]

Originally Posted by NuclioN

Looks great but..

* PM attachment is showing up on the forumindex trough this mod: https://vborg.vbsupport.ru/showthread.php?t=61244

* javascript error sendmail: (see attachment)

* Kan not see the send attachment in PM

Note... if the author updates his hack this would need to be updated also.

In Mindtrix hack, look for:

$trix = $DB_site->query("SELECT attachmentid, dateline, filename FROM attachment WHERE dateline < " . TIME() ." ORDER BY dateline DESC LIMIT 5");

change it to:

$trix = $DB_site->query("SELECT attachmentid, dateline, filename FROM attachment WHERE dateline < " . TIME() ." AND private=0 ORDER BY dateline DESC LIMIT 5");

sendmail has nothing to do with this hack, what error are you getting?

Some people reported me before that the attachments weren't showing in the pm, I haven't traced why yet but someone also said that enabling thumbnails in the acp made them visible (I still haven't been able to reproduce it).

[MindTrix]

Wand me to update my hack with your fix, so it does not clash with your hack mate?

[Kentaurus]

Originally Posted by MindTrix

Wand me to update my hack with your fix, so it does not clash with your hack mate?

Thanks Mindtrix, that would be nice. Only that you would need to put it as a note because normally they don't have a "private" column in the table.

[MindTrix]

Sure ill just make a link then in my post saying about it etc

[The Quibbler]

/me installs, and hopes it all works fine in RC4.

[Boofo]

Another small bug.

When you preview a message, the attachment is still there but it doesn't show in the attachments box until you open it up and do a blank upload. Then it lists like it should. Can I get my "fix" for this?

[Kentaurus]

Originally Posted by Boofo

Another small bug.

When you preview a message, the attachment is still there but it doesn't show in the attachments box until you open it up and do a blank upload. Then it lists like it should. Can I get my "fix" for this?

I would need more details for this one. When I send a PM, preview it, if I click in the manage attachments button then the pop-up already has the previously attached file. Or do you mean in the pm original window and not the pop-up?

[Boofo]

Originally Posted by Kentaurus

I would need more detailes for this one. When I send a PM, preview it, if I click in the manage attachments button then the pop-up already has the previously attached file. Or do you mean in the pm original window and not the pop-up?

Ok, I guess I got it a little confused. I mean right above the Manage Attchaments button in the Additional options box underneath the message. It won't show the attachment in a preview until you open up the manage attachments box and close it.