The Arcive of Official vBulletin Modifications Site.It is not a VB3 engine, just a parsed copy! |
|
Comments |
#62
|
|||
|
|||
It doesn't matter where the attachments are stored.
Yes, you can limit access to the mod to certain user groups. 15,000 attachments... hmmm. Would you be willing to beta test the new release: https://vborg.vbsupport.ru/showpost.php?p=539692 PM me an e-mail address and I will send you the new script. Cheers |
#63
|
|||
|
|||
I would be interested to hear from folks who run with a large number of attachments (more than 2,000) to give me some feedback on timing. Please PM me if you are willing to test the new version. Thank you.
Changes queued-up for version 2.1
ps: If the 'COUNT(*)' retrieval is just too slow to support sites with many thousands of attachments, then we will need an option to skip getting the count. Note that the query to get 'COUNT(*)' is not as simple as you might think. As a minimum (not incuding special search values from the Display Options form), it must deal with forum permissions, attachment 'visible', as well as check the post table for 'visible' and post deletions. With such an option enabled, the page would not include the number of accessible/matching attachments and would not have normal page navigation. For the page navigation, since we do not know how many there are, the best we could do is support "Next Page" when we know that there is *at least one* more attachment not on the current page. |
#64
|
||||
|
||||
I don't know what's happening with this, but I hope it continues. I just installed and it's very nice.
Question: I want the search box to be 'Open' by default. How can I do that? |
#65
|
|||
|
|||
Quote:
Right, by default, the search form is displayed "collapsed" when the page is loaded. This would be a good option to have in the next release. For now, what you can do is make two changes to the template 'attbro_FORM' (I did not test this). Change this line: <img id="collapseimg_attbro_disp_opts" src="$stylevar[imgdir_button]/collapse_thead_collapsed.gif" alt="" border="0" /></a> to this: <img id="collapseimg_attbro_disp_opts" src="$stylevar[imgdir_button]/collapse_thead.gif" alt="" border="0" /></a> (removed the characters highlighted in red) Then, a few lines down from that, change this line: <tbody id="collapseobj_attbro_disp_opts" style="display:none; "> to this: <tbody id="collapseobj_attbro_disp_opts" style=""> |
#66
|
||||
|
||||
Thanks - I'll check it out tonight. It's not a REAL big issue, but you know how it goes. Some folks don't look so closely and miss the 'open' link (I renamed the phrase on mine to better point it out).
The biggest problem I have, actually, is checking things people upload for the file name. Many people upload stuff like 'document.doc' so the search feature has a limited function. However, I have gone in and renamed a lot of atttachments - I have to 'edit' the thread - download and rename the attachment, unattach the file in the post, and reupload the renamed file. And I watch to make sure new attachments have an appropriate name. I rename threads a lot as well, but I do that mostly for search engines. I started doing that last December, along with some other SEO 'stuff' and my rankings, and traffic, have significantly improved. |
#67
|
|||
|
|||
Quote:
|
#68
|
||||
|
||||
Very nice hack, but I am confused how to get the file icons to show. If someone could help It would be apreciated.
Thanks CarCdr! fiber |
#69
|
||||
|
||||
OK - I was researching why my board and a clients board would not show the attachment icons on the attachment listing display: and eventually found it.
This modification need only be applied by those who have altered their $stylevar[imgdir_attach] to a absolute path, this modification will need to be made. In attachment_browser.php, Find: Code:
function ICON_FILE_EXISTS($extension) { global $stylevar; static $attbro_icon_present; if (empty($attbro_icon_present["$extension"])) $attbro_icon_present["$extension"] = (file_exists("$stylevar[imgdir_attach]/$extension.gif")); return $attbro_icon_present["$extension"]; } Code:
function ICON_FILE_EXISTS($extension) { global $stylevar; static $attbro_icon_present; if (empty($attbro_icon_present["$extension"])) $attbro_icon_present["$extension"] = (file_exists($_SERVER['DOCUMENT_ROOT']."$stylevar[imgdir_attach]/$extension.gif")); return $attbro_icon_present["$extension"]; } |
#70
|
|||
|
|||
Thanks Natch.
So, how do you suggest I conditionalize this so that no patch need be applied (i.e., in a future version of this hack). What does your "$stylevar[imgdir_attach]" look like? |
#71
|
||||
|
||||
/forums/images/attach for my main style - but I think you will find that this folder will exist on all installations: the difficulty is determining the location of forumroot from $_SERVER['DOCUMENT_ROOT'] on all installs...
|
|
|
X vBulletin 3.8.12 by vBS Debug Information | |
---|---|
|
|
More Information | |
Template Usage:
Phrase Groups Available:
|
Included Files:
Hooks Called:
|