[VB3 RC3] Attachments in private messages

Unsupported. VB3.5 version is here:
https://vborg.vbsupport.ru/showthread.php?t=91220

Tested on 3.0.3

This hack enables you to send attachments in a private message. This feature was really useful to me in vb2 and I kind of missed it on vb3 so I rehacked it myself.

When a user writes a private message they will be given the option to add an attachment, the same as when writing a post. It uses the same rules you have defined for a convencional attachment including file types, quotas, etc. It is only an extension for attachments to be used in private messages.

As always it is advised to backup your files before hacking in case you want to go back, this is some big hack including modification of multiple files, some templates and adding two extra columns in the database tables.

Instructions are provided in the txt, and some screenshots on where the attachment option appears.

Info for hackers:
You may modify, improve, upgrade, redistribute this hack, include it
in another hack or yours or translate it provided you do it free of
charge and you distribute it in www.vbulletin.org at least, there is no
need to pm me asking for permission
Some portions of the code are (c) Jelsoft Enterprises Ltd.

Edit by MarcoH64:
Because of multiple requests to make this hack work on vB3.0.7 i created upgrade instructions. These upgrade instructions can be followed after the original instructions (the 3.0.3 version). The original coder can not be held responsible for my modification.

[catocom2]

Originally Posted by kentaurus

The new phrases are added in the admin control panel, that is, you go to the phrase manager and click on the "add new phrase" button

I found where to add the phrases there.
It still says I don't have permission when I open the attachment window though. :surprised:

[Kentaurus]

Originally Posted by catocom2

I found where to add the phrases there.
It still says I don't have permission when I open the attachment window though. :surprised:

Did you do the template modifications in the newattachment template? That would be a cause for the window to give you a nopermission error.

If you have the hack installed in an accesible board for me to take a quick peek that would help also.

[catocom2]

Thanks Kentaurus!
It was in the "newattachment.php" file.
I must have missed something in that file the first time around.
I took a fresh copy, and tried it again. It works perfectly now. :up:

[catocom2]

Is there a way to moderate PM attachments in the admincp, like
the regular attachments?

[Kentaurus]

Originally Posted by catocom2

Is there a way to moderate PM attachments in the admincp, like
the regular attachments?

The attachments follow the same rules as the regular attachments, they count for the quota of the user, and you can search for them in the admincp by author, date or any other field.

As for having a moderator queue for attachments that's not a feature. In fact, you do not moderate user's private messages and neither the attachments.

[catocom2]

ah, I see

[catocom2]

Well I upgraded to RC4 and reinstalled this hack, but
it has put it at the top for some reason..
It still works good though.

[Kentaurus]

Originally Posted by catocom2

Well I upgraded to RC4 and reinstalled this hack, but
it has put it at the top for some reason..
It still works good though.

How is your pm_newpm template? You can add $attachmentoption wherever you want that box to show. Seems to me that it is above the message area. I wil re-check it as soon as I have rc4 installed.

[catocom2]

ah, yeah I had to move it down in the pm_newpm temp.

find

$disablesmiliesoption

and put it right below it...like..

	                $disablesmiliesoption
                        $attachmentoption

I also had a problem with the "private.php" file and had to
change a few things.

[Oblivion Knight]

All seems to be working well..
Just a small thing of concern, in the message itself where the attached images are shown, the "Attached Images" in the message isn't framed like your screenshot demonstrates..

I've attached a screenshot of this, hopefully you can shed some light on this.?

[Boofo]

I think I found another bug. I had a member send me a photo of something. I still have the message and there is a paperclip showing there is an attachment to it but when you open the message, there is no attachment there. Now, this member erased all of her sent messages in the pm area. Could that have something to do with this since she is the one who sent it? Cause the attachment she sent me never showed up in my attachment list, only hers.

[Revpolar]

Yes that'll do it. I just did the install and found that out right away. Which is a good feature if you ask me. Great hack. My install was flawless on RC4. Thanks alot.

[Boofo]

It's not a good feature if you want to hold on to an attachment like I wanted to.

[Kentaurus]

Originally Posted by Oblivion Knight

All seems to be working well..
Just a small thing of concern, in the message itself where the attached images are shown, the "Attached Images" in the message isn't framed like your screenshot demonstrates..

I've attached a screenshot of this, hopefully you can shed some light on this.?

That's a template thing, if the normal attachments appear framed then the attachments in private message should, too. Try attaching a jpg instead or a gif to see if it changes. How does it show in a normal postbit?

[Kentaurus]

Originally Posted by Boofo

I think I found another bug. I had a member send me a photo of something. I still have the message and there is a paperclip showing there is an attachment to it but when you open the message, there is no attachment there. Now, this member erased all of her sent messages in the pm area. Could that have something to do with this since she is the one who sent it? Cause the attachment she sent me never showed up in my attachment list, only hers.

That's because the ownership of the attachment is mantained to the person who sent it. He can delete it anytime and you wouldn't have the attachment anymore. I can't give the ownership of the attachment to the recipient because there could be multiple recipients and I wouldn't know who should be the owner. And making a copy for everyone and storing an attachment 3-4 times doesn't seem to me as a good solution.

But the paperclip still showing up is a bug, I'll look into it. That should dissapear as soon as there are no more attachments.