List of changed var/array/function names

[Kadence]

The parameters for the print_forum_chooser() function in /includes/adminfunctions.php have changed.

Old (vB 3.0.7):

PHP Code:

function print_forum_chooser($name = 'forumid', $selectedid = -1, $topname = NULL, $title = NULL, $displaytop = 1, $multiple = 0, $displayselectforum = 0) 


New (vB 3.5 Beta 3):

PHP Code:

function print_forum_chooser($title, $name, $selectedid = -1, $topname = null, $displayselectforum = false, $multiple = false) 


The $title parameter has moved from the 4th parameter to the 1st, $displayselectforum and $multiple have swapped places, and the $displaytop parameter has been deleted.

[MrNase]

It took me a while to figure out:

PHP Code:

$id = intval($_REQUEST['id']); 


has become:

PHP Code:

    $vbulletin->input->clean_array_gpc('r', array(
        'id'=> TYPE_UINT
    ));
    $id = $vbulletin->GPC['id']; 


[Andreas]

$id is empty because you must use $vbulletin->GPC['id']

Btw: For just one variable, it doesn't make too much sense to use clean_array_gpc().

[MrNase]

I edited my above post to add another example so that someone who's as stupid as me understands it


vBulletin provides this functions so I'll use them

[Andreas]

Easier approach & less overhead:

PHP Code:

$id = $vbulletin->input->clean_gpc('r', 'id', TYPE_UINT); 


[MrNase]

Thank you

One should edit the first post of this thread and add all usefull information

[MrNase]

What happened to $_FILES ?

What would this code look like:

PHP Code:

$imagesize = getimagesize($_FILES['src']['tmp_name']); 


[Marco van Herwaarden]

You would be using clean_gpc with a 'f' as the first parameter.

[Erwin]

Originally Posted by KirbyDE

Easier approach & less overhead:

PHP Code:

$id = $vbulletin->input->clean_gpc('r', 'id', TYPE_UINT); 


Interesting.

[RaidenDAWG2]

These new globalize things are driving me nuts here.

I used to have something that looked like this in 3.0.x...

PHP Code:

if(isset($_POST['do']))
{
    $do=$_POST['do'];
}
if(isset($_GET['u']))
{
    $spammerid=$_GET['u'];
}
elseif(isset($_POST['u']))
{
    $spammerid=$_POST['u'];
}
if(isset($_GET['t']))
{
    $threadid=$_GET['t'];
}
elseif(isset($_POST['t']))
{
    $threadid=$_POST['t'];
}
if(isset($_GET['p']))
{
    $postid=$_GET['p'];
}
elseif(isset($_POST['p']))
{
    $postid=$_POST['p'];
} 


Pretty standard $_GET/$_POST structure that reads in either the get or post based on which step it is (it's a spam killing type thing, pops up a window with some options to confirm, then submits and does its thing).

So in trying to convert it over to 3.5 RC1, I tried this...

PHP Code:

$vbulletin->input->clean_array_gpc('g', array(
    'do' => TYPE_STR,
    'u'=> TYPE_INT,
    't'=> TYPE_INT,
    'p'=> TYPE_INT)
);
if(isset($vbulletin->GPC['do']))
{
    $do = $vbulletin->GPC['do'];
}

if(isset($vbulletin->GPC['u']));
{
    $spammeruserid = $vbulletin->GPC['u'];
}

if(isset($vbulletin->GPC['p']));
{
    $spammerpostid = $vbulletin->GPC['p'];
}

if(isset($vbulletin->GPC['t']));
{
    $spammerthreadid = $vbulletin->GPC['t'];
} 


So...yeah...where am I going wrong here? Any help you guys can give me would be much appreciated

Thanks,
-RD