Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 General Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #51  
Old 12-27-2014, 02:34 AM
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Location: St. Augustine, FL
Posts: 3,853
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I found this thread searching for a way to set the "About Me" tab as the default tab when visiting user profiles, and so I created the plugin and it worked well on my dev site (vB 4.2.1 ), but when I implemented it on the live site (vB 4.2.2 PL2), it did not work. I found though that if I removed the conditional, and just used as the Plugin PHP code:

PHP Code:
$vbulletin->GPC['tab'] = 'aboutme'
then it works. However, I do not want to just remove the conditional:

PHP Code:
if (!$vbulletin->GPC_exists['tab']) 
without knowing what its purpose is or what problems this could cause. Could anyone shed some light on why we want the above conditional?
Reply With Quote
  #52  
Old 12-27-2014, 02:37 AM
ozzy47's Avatar
ozzy47 ozzy47 is offline
 
Join Date: Jul 2009
Location: USA
Posts: 10,929
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Disable that plugin, and see if this mod works for you, https://vborg.vbsupport.ru/showthread.php?t=302655
Reply With Quote
Благодарность от:
MarkFL
  #53  
Old 12-27-2014, 03:03 AM
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Location: St. Augustine, FL
Posts: 3,853
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by ozzy47 View Post
Disable that plugin, and see if this mod works for you, https://vborg.vbsupport.ru/showthread.php?t=302655
Hello Ozzy,

First, thank you for you quick and helpful response.

It works beautifully on my dev site, but not on my live site. I looked at your plugin code, and it uses the same conditional. I would rather use your product though if I can figure out why the conditional is causing a problem, so that we can change this in the future if we want via the AdminCP without having to hack a plugin.
Reply With Quote
  #54  
Old 12-27-2014, 03:07 AM
ozzy47's Avatar
ozzy47 ozzy47 is offline
 
Join Date: Jul 2009
Location: USA
Posts: 10,929
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Have you tried disabling all other mods? Does the same thing happen on a unmodified default style?
Reply With Quote
  #55  
Old 12-27-2014, 03:28 AM
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Location: St. Augustine, FL
Posts: 3,853
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by ozzy47 View Post
Have you tried disabling all other mods? Does the same thing happen on a unmodified default style?
Disabling all other mods would require the consent of the site owner, however, I have been planning to set up a dev site identical to the live site and at that time I can do what I like with it.

At your suggestion, I did just now try an unmodified default style and had the same result.

So, once I set up the new dev site, I will disable all mods, and then enable them one by one until I find the conflict. I will let you know what I find.
Reply With Quote
  #56  
Old 12-27-2014, 03:29 AM
ozzy47's Avatar
ozzy47 ozzy47 is offline
 
Join Date: Jul 2009
Location: USA
Posts: 10,929
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Yeah let me know how it goes, and we can proceed from there.
Reply With Quote
  #57  
Old 12-28-2014, 08:42 AM
BirdOPrey5's Avatar
BirdOPrey5 BirdOPrey5 is offline
Senior Member
 
Join Date: Jun 2008
Location: New York
Posts: 10,610
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by MarkFL View Post
Disabling all other mods would require the consent of the site owner, however, I have been planning to set up a dev site identical to the live site and at that time I can do what I like with it.

At your suggestion, I did just now try an unmodified default style and had the same result.

So, once I set up the new dev site, I will disable all mods, and then enable them one by one until I find the conflict. I will let you know what I find.
First look for any mods that might use the same hook before disabling them all. You might get lucky.
Reply With Quote
Благодарность от:
MarkFL
  #58  
Old 12-28-2014, 06:29 PM
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Location: St. Augustine, FL
Posts: 3,853
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by ozzy47 View Post
Yeah let me know how it goes, and we can proceed from there.
I found the culprit was DB Tech's Post Thanks/Like product. Changing the execution order of your plugin in either direction seemed to have no effect.

So, I hacked your plugin code, and replaced the condition:

PHP Code:
 !$vbulletin->GPC_exists['tab'
with:

PHP Code:
 ($vbulletin->userinfo['userid'] != $userinfo['userid']) || ($vbulletin->GPC['tab'] != 'thanks'
This way if a user is visiting their own profile because of a thanks notification, the "Post Thanks/Like" tab is used, otherwise the "About Me" tab is used (or whatever tab I define in the AdminCP via your product). This gives me the desired result, but if any unforeseen problems arise because of the change I made, I will let you know.
Reply With Quote
Благодарность от:
ozzy47
  #59  
Old 12-28-2014, 06:32 PM
ozzy47's Avatar
ozzy47 ozzy47 is offline
 
Join Date: Jul 2009
Location: USA
Posts: 10,929
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Then it is a bug in their mod, but glad you got it sorted.
Reply With Quote
  #60  
Old 12-28-2014, 06:40 PM
MarkFL's Avatar
MarkFL MarkFL is offline
 
Join Date: Feb 2014
Location: St. Augustine, FL
Posts: 3,853
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by ozzy47 View Post
Then it is a bug in their mod, but glad you got it sorted.
I can't thank your posts now, but I did want to let you know your help and your product(s) are greatly appreciated. :up:
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 01:12 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.04351 seconds
  • Memory Usage 2,277KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (4)bbcode_php
  • (5)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (10)post_thanks_box
  • (3)post_thanks_box_bit
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (3)post_thanks_postbit
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete