Chat Modifications - Fix vbShout Timezone problem

This vbShout plugin: http://www.vbhackers.com/f76/ajax-fl...ut-2-1-a-4536/

Has a serious bug with Time Zone changing to that of the last person to post in the shout box.

Here is a fix so that each user will see the time in their local timezone correctly.

1. Open template forumhome_vbshout_shout
Find this (should be at the very beginning):

<tr>

After it add:

                                <td nowrap align="left" valign="top">
                                <font size="1">
                                    <date>{$Shout['time']}</date>
                                    
                                </font>
                                </td>

Make sure that the "date" and "/date" tags are on the same line, and with no spaces between them and the $Shout variable, just as above. These are not valid html tags, and we are going to write code to replace them ourselves.



2. Open template forumhome_vbshout
Find:

Shouts.innerHTML = '<table cellpadding="1" cellspacing="3" border="0" width="95%" align="left">' + ShoutRequest.handler.responseText + '</table>'

Replace it with:

                        var formatMe = ShoutRequest.handler.responseText
			formatMe = replaceDates(formatMe);
                        Shouts.innerHTML = '<table cellpadding="1" cellspacing="0" border="0" width="100%" align="left">' + formatMe + '</table>'

In the same template
Find this:

function sb_CollectHV(sbForm)

Before it add:

// replaces <date> tags
function replaceDates(s) {
            var ret = "";
            var matches = s.match(/<date>\d+<\/date>/g);
            for(var i = 0; matches != null && i < matches.length; i++) {
                var utc = matches[i].match(/\d+/);
                var date = new Date(utc * 1000);
                ret = ret + s.substr(0, s.indexOf(matches[i]));
                ret = ret + (date.getMonth()+1) + "/" +
                            date.getDate() + "/" +
                            date.getFullYear() + " " +
                            date.getHours() + ":" +
                            ((date.getMinutes() < 10) ? "0" : "") +
                            date.getMinutes() + ":" +
                            ((date.getSeconds() < 10) ? "0" : "") +
                            date.getSeconds() + " ";


                s = s.substr(s.indexOf(matches[i]) + matches[i].length);
            }
            ret = ret + s;
            return ret;
}

3. Open file vbshout.php
FInd this (There are similar code blocks, this should be in the function rewrite_shoutbox_flatfile() around line 226):

        $Shout['time']     = buildTime($Shout['s_time']);
        $Shout['s_shout']  = bbcodeparser($Shout['s_shout']);
        $Shout['style']    = '';
        $Shout['data']     = unserialize($Shout['s_data']);
        $Shout['username'] = fetch_musername($Shout, 'usergroupid');

        if (preg_match("#(\#)?0099FF#i", $Shout['data']['color']) && $Shout['s_by'] != 1)
        {
            $Shout['data']['color'] = '';
        }

Replace it with:

        // $Shout['time']     = buildTime($Shout['s_time']);
        $Shout['time']     = $Shout['s_time'];
        $Shout['s_shout']  = bbcodeparser($Shout['s_shout']);
        $Shout['style']    = '';
        $Shout['data']     = unserialize($Shout['s_data']);
        $Shout['username'] = fetch_musername($Shout, 'usergroupid');
        
        if (preg_match("#(\#)?0099FF#i", $Shout['data']['color']) && $Shout['s_by'] != 1)
        {
            $Shout['data']['color'] = '';
        }

This should now pass the date as UTC and JavaScript will convert it on the client side to the appropriate date.

[parabat]

Originally Posted by newhere

Either way (with your code or with mine), I get a horizontal scroll bar when someone posts a shout which is too long.

Just as a side.. the scrollbar appears in IE6 & IE7 (without a long posting), but not in Firefox.

-PB

[jessej]

Originally Posted by Terminatoronly

when i installed it i didnt get any time with the shout how can i add the time ???

same here.

i hope someone will answer cause i had it on v2.0, and i really want it on v2.1.

thanks- and this is a GREAT hack.

[CMGU]

i can´t change somebody help me

[oz_moses]

Cheers for the mods, much appreciated

CMGU, perhaps if you ask a question you might find help more forthcoming.

[oz_moses]

Ok, here's my customisations for anyone who's interested. These changes to the replaceDates function do the following

• Droped the seconds - the shouts are displayed in order anyway, my users don't care if a shout was 3 or 49 seconds ago
• Changed the date format to dd-mon , easier to read, all months are 3 letters helps keep it aligned at the month turnover.

// replaces <date> tags
function replaceDates(s) {
	var ret = "";
	var matches = s.match(/<date>\d+<\/date>/g);
	var months=['Jan','Feb','Mar','Apr','May','Jun','Jul','Aug', 'Sep','Oct','Nov','Dec'];

	for(var i = 0; matches != null && i < matches.length; i++) {

	var utc = matches[i].match(/\d+/);
	var date = new Date(utc * 1000);
        
        ret = ret + s.substr(0, s.indexOf(matches[i]));
	ret = ret + (
                        date.getDate() + "-" +
			months[date.getMonth()]) + " " +
                        ((date.getHours() < 10) ? " " : "") + 
				date.getHours() + ":" +
                        ((date.getMinutes() < 10) ? "0" : "") +
				date.getMinutes() + " ";

                s = s.substr(s.indexOf(matches[i]) + matches[i].length);
            }
            ret = ret + s;
            return ret;
}

[oz_moses]

Originally Posted by jessej

same here.

i hope someone will answer cause i had it on v2.0, and i really want it on v2.1.

thanks- and this is a GREAT hack.

I found that changes aren't rendered until you make a new shout... so just shout!

[oz_moses]

Originally Posted by parabat

Just as a side.. the scrollbar appears in IE6 & IE7 (without a long posting), but not in Firefox.

-PB

I noticed the horizontal scroll initially in IE6, it was on all the time.

I made an edit in forumhome_vbshout template to chang the table width to 95% as per the original hack which seems to have fixed it.

Shouts.innerHTML = '<table cellpadding="1" cellspacing="0" border="0" width="95%" align="left">' + formatMe + '</table>'

seems to be working in IE6 and IE7. Haven't tested Firefox yet...