Show Thread Enhancements - CES Intelligent Postbit Query

CES Intelligent Postbit Query
Version: 1.0.1

This hack is now used as a troubleshooting tool for members with unusually high queries on showthread. You do not need to install this unless your queries peak around 20 or higher.

Note that if after installing this you experience a drop in queries, it means you have a bad plugin installed. Leaving this installed, while this does not hurt your forum at all, does not solve your query problem - it only now hides it.

To disable the tool, you only need to change the line:

PHP Code:

$lastcheck = ($lastfetchtype == $fetchtype) ? true : false; 


to:

PHP Code:

// $lastcheck = ($lastfetchtype == $fetchtype) ? true : false; 


Post your query success stories in the thread!

For those without success (i.e. it doesn't seem to make a difference), please don't uninstall, but help us determine what is different in your case. PHP version, MySQL version, hacks installed, PHP cache, etc. would all be useful information. Thanks!

*** NEWS ***
This section has become a list of bad plugins. Often these plugins can be optimized by a rewrite using a different hook, and thus not causing this query issue.

Product: Username Management
Hook Location: postbit_factory
Bad Plugin: Add Username history to postbit(legacy)

1/28/2007 - v1.0.0, v1.0.1 released

I actually came across this while trying to reduce queries in my CES Site News mod which uses a customized showthread.php.

Known Issues:
- NONE

- Some users see an amazing improvement, others do not see a difference in query count for some time, while still others don't see any difference at all. It all depends on your server setup and your current vBulletin installation (settings, other mods, etc). This hack is still young (1 day) so we haven't narrowed down what causes these differences in success.

- If you are still experiencing the stolen signatures issue, you need to clear your sig_cache. Do this by going to AdminCP -> Maintenance -> Update Counters -> Empty Signature Cache.

What It Does:
On some installations showthread wastes 1 query per post in showthread.php when creating the postbits. You can tell if this applies to your installation if you approach or exceed 20 queries on a page of only 10 or so posts.

By adding these 4 lines, showthread checks to see if it already has created the appropriate Postbit Factory object instead of doing it all over again. Queries on showthread are thus DRASTICALLY reduced (1 per post), even though the code reveals no direct database references.

This can be a HUGE performance boost.

I hope someone from Jelsoft sees this thread...

Mod Features:
- removes multiple pointless queries

Products to Install: 0
Plugins Included: 0
Files to Upload: 0
Files to Edit: 1
New Templates: 0
Template Edits: 0
Queries Added*: -1

*See "What It Does" for details.

*** Changelog ***
As of Version 1.0.1:
- fixed bug where posts would "steal" signatures from each other
Special thanks to TheFrienzNet for his help ^_^

[COBRAws]

Originally Posted by TheFrienzNet

As seen from your profile card, you are using vBulletin 3.5.4. This hack only supports 3.6.x.

Im using 3.6.4 my profile was not updated.

[thincom2000]

Originally Posted by COBRAws

I was having the Steal sigs bug, now I updated with the new code replacements (replaced just the first instances and the two).

Anything I do, I get the following error msg:


mmm

That happened to me while during primary testing. On vBulletin 3.6.4 it happens when you have:

PHP Code:

$lastfetchtype = ($lastfetchtype != $fetchtype) ? $fetchtype : $lastfetchtype;
$lastcheck = ($lastfetchtype == $fetchtype) ? true : false; 


instead of

PHP Code:

$lastcheck = ($lastfetchtype == $fetchtype) ? true : false;
$lastfetchtype = ($lastfetchtype != $fetchtype) ? $fetchtype : $lastfetchtype; 


[COBRAws]

Originally Posted by thincom2000

That happened to me while during primary testing. On vBulletin 3.6.4 it happens when you have:

PHP Code:

$lastfetchtype = ($lastfetchtype != $fetchtype) ? $fetchtype : $lastfetchtype;
$lastcheck = ($lastfetchtype == $fetchtype) ? true : false; 


instead of

PHP Code:

$lastcheck = ($lastfetchtype == $fetchtype) ? true : false;
$lastfetchtype = ($lastfetchtype != $fetchtype) ? $fetchtype : $lastfetchtype; 


Thanks, quick replier but im using 3.6.4 as on my last message. Sorry for not updating my profile info.

[thincom2000]

In that case please post your showthread.php (stripped of license data), and I'll take a look at it.

[Kiros72]

Is there any reason the queries would appear to be the same (before and after the hack)?

[thincom2000]

For each post, -1 query. For each signature +1 query.

It would appear to be the same if the number of different signatures and posts are the same. In its current form, this would only be beneficial if the same people keep posting in a thread.

EDIT: That's completely untrue. I just looked at the code again, and at my site, and this does not add queries for signatures.

There is no reason I can think of why you should not be getting QUERIES SAVED = NUMBER OF POSTS ON PAGE - 1.

Do you have any hacks that run on postbit hooks ?

[Cap'n Steve]

Maybe I'm missing what exactly this hack does, but I know that default vBulletin doesn't do a query for every post. If you have more than 20 queries or so, then something is very wrong.

[Get Shorty]

Originally Posted by Cap'n Steve

Maybe I'm missing what exactly this hack does, but I know that default vBulletin doesn't do a query for every post. If you have more than 20 queries or so, then something is very wrong.

Yeah, like I mentioned, I didn't see any change in query usage.

[Kiros72]

Originally Posted by Cap'n Steve

Maybe I'm missing what exactly this hack does, but I know that default vBulletin doesn't do a query for every post. If you have more than 20 queries or so, then something is very wrong.

No, I don't have any hacks that would modify the postbits - not that I'm aware of

[G_Man]

Originally Posted by Cap'n Steve

Maybe I'm missing what exactly this hack does, but I know that default vBulletin doesn't do a query for every post. If you have more than 20 queries or so, then something is very wrong.

I just uninstalled since my queries were exactly the same as before making the edits. It sure seems to be helping on some forums though.

Hopefully something can be found to establish this benefit. I have a few mods boosting my queries to around 27-35 or so...