RPG Integration Hack - Old Support Thread

Nice conversion there mate, lot of work has gone into it so well done and thanks for sharing it

[Revan]

Originally Posted by deathemperor

I tested and found two errors:


1st is database error:
you said that you cant make the posting results, so I wonder what is this for

".TABLE_PREFIX."rpg_battle_options.postresults,".TABLE_PREFIX."rpg_battle_options.battleforum,

it should be removed or when opening rpg.php it will show db error.
one more thing with this script

LEFT JOIN ".TABLE_PREFIX."user ON ".TABLE_PREFIX."user.userid=$userid

it doesn't understand $userid, if I replace it with 1, it's fine of course, I think the solution is replace $userid with $bbuserinfo['userid'], didn't test yet

This is bogus, because there has been a vital change in the way rpg.php and rpgcp.php acts.

rpg.php is to display the stats of an user, using the arg "?userid=".
rpgcp.php is to display the user browsing the file ONLY.
Why?
Because even if you were not the same user as the user you viewed rpgcp.php for, you would get the "sell" link if he owned an item.
This would either cause you to sell your own item, or create DB errors.

But I have made some small fixes to avoid this sorta thing happening again, I will update the zip.

Originally Posted by deathemperor

and:

when I came to clans.php, it show a blank page, came to clans.php?action=view it show a database error ( cant remember, I'm away from my PC).l

This is also bogus, because clans.php is to view a specific clan with the arg "?clanid=".
I have made a similar fix as the above file to prevent this from happening again

Originally Posted by deathemperor

and the templates as far as I've seen they weren't well-made, this could be easy changed. The manner things should be verify is the code since I'm not sure what to do when errors occurs.

Please continue to report these holes in the code because I consider them to be
a) annoying
2) spamming the admins email
d) all of the above

And I didnt make the templates, I simply took out the obvious "non-XHTML" stuff in them, and put them in an XML file.
If you know anyone/want to help me with the templates (as requested in the first post), do let me know

Originally Posted by deathemperor

The spells, apart from causing HP/MP, is it possible to causes status ?

No, not yet.

Originally Posted by deathemperor

I think you should have made it a beta testing board, problems occurs this way it's hard for you to verify --> fix all

You sayin I should create a beta board?
I already do have one, on my localhost and I have this live on my 3.0.3 (currently down btw ), and no errors was found during my test runs.

*zip updated*

[deathemperor]

This is bogus, because there has been a vital change in the way rpg.php and rpgcp.php acts.

rpg.php is to display the stats of an user, using the arg "?userid=".
rpgcp.php is to display the user browsing the file ONLY.

I know this, but it doesn't work, that's the case

[Revan]

the rpg.php, it works with the arg ?userid=1
(example)
why I am sure? Because:
a) in the code it says "$userid = $_GET['userid']"
b) it works on all my test runs

and I KNOW the rpgcp.php works because theres no $userid in that code

[deathemperor]

I know, I didn't say rpgcp.php has something wrong, just rpg.php

how about letting me make the template ? I know HDJ I think I can make it at least look like the old vb2 RPG hack.

[Revan]

What template do you mean?
If you mean the rpg.php's template then no because I spent ages on tweaking that file and its template to make it contain all the info the rpgcp.php contains (since I blocked people from viewing the rpgcp of anyone but themselves)

[SB2002]

Ok, i'm having a bit of a problem, only a small one tho, all the rpg names are displaying as the users location as opposed to users name, is there something I am missing here? I've been through the thread 4 times now and can't find anyone else with this problem..... anyone?

EDIT:

I can change the name through the admincp and it sticks, but the when the user edits it is does not change, i have tested this several times now and it keeps doing the same thing. WHen they first create it it takes on their location as their name, and then when you try to edit it after it has been changed through the user edit users function in the rpg section of the admin cp it stays with what the admin set it as, any ideas?

EDIT 2:

Nevermind, i know Read the f**king manual.......

And yes, I actually am an IT technician, we NEVER read the manual, lol

[Deimos]

I to can't get the battles to work
I request a battle, I get a PM, so does the other person, when he clicks to approve/confirm it, it says invalid password/battle
But the page before DOES have the correct battle/password in the URL.

[Dark Dragon]

Originally Posted by Deimos

I to can't get the battles to work
I request a battle, I get a PM, so does the other person, when he clicks to approve/confirm it, it says invalid password/battle
But the page before DOES have the correct battle/password in the URL.

Same problem here, I thought it was just me though.

[Deimos]

The fix you posted above didn't work for me
When I went to run the sql query..

ALTER TABLE `user` ADD `rpgstats` CHAR(1) NOT NULL DEFAULT '1' AFTER `limitlevel`;

It came up with..

An error occurred while attempting to execute your query. The following information was returned.
error number: 1054
error desc: Unknown column 'limitlevel' in 'user'

And if I now try and save the updated profile/update RPG info page, it says.

Database error in vBulletin 3.0.3:

Invalid SQL: UPDATE user SET element='2', rpgrace='3', alignment='3', rpggender='2', rpgclass='32', rpgtype='0', limitlevel='', rpgstats='0' WHERE userid='1686'
mysql error: Unknown column 'limitlevel' in 'field list'

***************

Edit
I just removed that fix and put the profile.php changes back that were listed in the zip file and it doesn't do it anymore
But I don't then get the option in usercp to choose wether to display stats or not, which is a shame, but I still can't use the battle system

[SB2002]

Originally Posted by Dark Dragon

Same problem here, I thought it was just me though.

I'm gettin the same here too