[VB3 RC3] Attachments in private messages

Unsupported. VB3.5 version is here:
https://vborg.vbsupport.ru/showthread.php?t=91220

Tested on 3.0.3

This hack enables you to send attachments in a private message. This feature was really useful to me in vb2 and I kind of missed it on vb3 so I rehacked it myself.

When a user writes a private message they will be given the option to add an attachment, the same as when writing a post. It uses the same rules you have defined for a convencional attachment including file types, quotas, etc. It is only an extension for attachments to be used in private messages.

As always it is advised to backup your files before hacking in case you want to go back, this is some big hack including modification of multiple files, some templates and adding two extra columns in the database tables.

Instructions are provided in the txt, and some screenshots on where the attachment option appears.

Info for hackers:
You may modify, improve, upgrade, redistribute this hack, include it
in another hack or yours or translate it provided you do it free of
charge and you distribute it in www.vbulletin.org at least, there is no
need to pm me asking for permission
Some portions of the code are (c) Jelsoft Enterprises Ltd.

Edit by MarcoH64:
Because of multiple requests to make this hack work on vB3.0.7 i created upgrade instructions. These upgrade instructions can be followed after the original instructions (the 3.0.3 version). The original coder can not be held responsible for my modification.

[SloppyGoat]

Originally Posted by Boofo

Does this hack follow what you have set for the attchment storage as far as where they are stored? I have mine stored on the disk and not the db.

A bit off topic, but can you tell me how you do that? I'd rather have my files stored on disk too! I prefer to keep the db as small as possible.

[Kentaurus]

Originally Posted by SloppyGoat

A bit off topic, but can you tell me how you do that? I'd rather have my files stored on disk too! I prefer to keep the db as small as possible.

In the admin control panel, in the menu go to attachments -> attachment storage type. there you can switch between database and disk.

The only way this could be bad, is if a dnld failed, I guess. But I've yet to see that happen.

Downloads fail for me all the time.. maybe it is just my isp. Also, I am likely to forget where in my hd (or in which computer) I stored the file, I might end searching in the pm so I can dl it again.

[SloppyGoat]

Originally Posted by kentaurus

In the admin control panel, in the menu go to attachments -> attachment storage type. there you can switch between database and disk.

Oh! I saw the one for avatars, and I was thinking of that. Now that I look, I've already transfered all my attachments too. DOH! I'm going to have to stop thinking in vB2.X terms, eh?

Downloads fail for me all the time.. maybe it is just my isp. Also, I am likely to forget where in my hd (or in which computer) I stored the file, I might end searching in the pm so I can dl it again.

I only allow 150K attachments, so that's not usually an issue(that I've heard of), on my server anyway. I don't mind this at all, as long as the attachments can be stored on the HDD. :up:

Have all the changes discussed in this thread been updated in the original txt now, or do I need to go back and read all of this again? Nice hack! I'm liking this more and more now...the more I read about it. :up:

[Kentaurus]

Originally Posted by SloppyGoat

Oh! I saw the one for avatars, and I was thinking of that. Now that I look, I've already transfered all my attachments too. DOH! I'm going to have to stop thinking in vB2.X terms, eh?

I only allow 150K attachments, so that's not usually an issue(that I've heard of), on my server anyway. I don't mind this at all, as long as the attachments can be stored on the HDD. :up:

Have all the changes discussed in this thread been updated in the original txt now, or do I need to go back and read all of this again? Nice hack! I'm liking this more and more now...the more I read about it. :up:

All changes are applied to the txt, I only write them in the forum for the people that already had the hack installed and don't want to go all over the instructions again.

[SloppyGoat]

Great! Thanks! I'll be installing this one soon then.

[Boofo]

Originally Posted by Boofo

Ok, that works but it now shows each pm attachment twice in the attachments list.

Have the instructions from the first post been updated with this and the paperclip code?

I've narrowed this down to if you send yourself a message with attachments in it, it shows them twice on the Attachments listing. What do I need to do to stop this?

[Boofo]

When you click on the "Show Thumbnails" link, it doesn't show the thumbnails for private attachments. Is there a fix for this, also?

[thuffner]

Just installed vB3 RC3 and re-did this hack twice with no avail.

Doesn't seem to work on RC3...

[Boofo]

Works great on my RC3. You must have missed something somewhere.

[thuffner]

Well everything works fine except the attachment doesnt show up in a PM...

[thuffner]

Just installed again and it didn't work.

It attaches to a PM fine. I send it to myself, open the PM, and no attachment is in the PM...

[Boofo]

kentaurus, are you still supporting this hack?

[Kentaurus]

Originally Posted by Boofo

kentaurus, are you still supporting this hack?

not at the same pace, but yes, I am If a really big bad bug appears I would of course give priority to it, for small modifications I usually delay a little more. I even tested this with RC3 yesterday and checked if the instructions were still ok.

About that double attachment in the attachment screen I am still thinking if I should fix that. The attachments in private message are somehow more controversial than the common attachments...

Right now I can duplicate the attachment for the attachment owner and all the members for which the attachment is sent.. that takes a lot of space in little time because a single attachment can be stored twice, or three times, or more. If I don't do that ownership of the attachment is difficult to determine.

If the owner of the attachment is the one that sent the attachment then I can go to attachments -> delete this attachment and the person that received it keeps nothing. I don't think this is natural, right now if someone sends me something by mail there is no way they can delete it after being sent.

If the owner of the attachment is the recipient then I have to do that store-attachments-more-than-once, and that's not nice for the db or the filesystem. I can't store it only once because a pm can be sent to multiple recipients, and then any recipient would be able to delete it leaving the rest with no attachment. This is even worse than the owner deleting it.

And now, why does the attachment appears twice in the attachment screen? That is because it appears once for each of your pm with that attachments, and if you send the pm to yourself and also you keep a copy then you have 2 pm's. Then that screen will link once to the pm you recieved from yourself and once to the pm that is in the sent folder.. even if it's the same attachment. That is why I haven't fixed it yet.. I am still debating if I should. Sending a pm to yourself is not that natural anyway, unless I were using the pm as a personal notepad or something.

[Kentaurus]

Originally Posted by thuffner

Just installed again and it didn't work.

It attaches to a PM fine. I send it to myself, open the PM, and no attachment is in the PM...

There was also someone having that problem before. Do you have any other hack installed that deals with functions_posting.php or private.php?

Also, did you made all the code modifications in private.php? That's usually the problem.

[sonic3d]

nice job