Mozilla/Firefox users: Search when editing templates

I am not sure if this is a real hack, so moderators, please feel free to remove it, if you do not consider it worthy.

I am an avid Mozilla user, having IE only for testing my forums, so I never use IE in the admincp. However, I was given access to a site, in which, for some reason, I had to use IE to access its admincp. I noticed that while editing a template, there was a "Search" box at the bottom of the form. That same box, didn't show up when using Firefox!

So I started asking around and I was told that this works only in IE. Then, when vB 3.5 came out, I noticed that the search function, was present in Firefox as well. Puzzled, I posted a question in vB.com, and the answer I got said to upload the clientscript/vbulletin_templatemgr.js, to get the same functionality.

Well, I did but nothing changed. So then I compared the file includes/adminfunctions_template.php and noticed some small differences. I incorporated them in vb 3.0.7 adminfunctions_template.php and voila, I got the search working fine.

If you are not in a hurry to update to vb 3.5 and if you want that functionality, edit your includes/adminfunctions_template.php and find:

PHP Code:

function print_template_javascript()
{
    global $stylevar, $vbphrase, $vboptions;

    print_phrase_ref_popup_javascript();

    echo '<script type="text/javascript" src="../clientscript/vbulletin_templatemgr.js"></script>';

    print_label_row(iif(is_browser('ie'), $vbphrase['search_in_template'], $vbphrase['additional_functions']), iif(is_browser('ie'), '
    <input type="text" class="bginput" name="string" accesskey="t" value="' . htmlspecialchars_uni($GLOBALS['searchstring']) . '" size="20" onChange="n=0;" tabindex="1" /> 


replace that with:

PHP Code:

function print_template_javascript()
{
    global $stylevar, $vbphrase, $vboptions;

    print_phrase_ref_popup_javascript();

    echo '<script type="text/javascript" src="../clientscript/vbulletin_templatemgr.js"></script>';

    print_label_row(iif(is_browser('ie') OR is_browser('mozilla', '20040707'), $vbphrase['search_in_template'], $vbphrase['additional_functions']), iif(is_browser('ie') OR is_browser('mozilla', '1.7'), '
    <input type="text" class="bginput" name="string" accesskey="t" value="' . htmlspecialchars_uni($GLOBALS['searchstring']) . '" size="20" onChange="n=0;" tabindex="1" /> 


With only this change, the search is working OK for me, but if you have problems, try uploading the clientscript/vbulletin_templatemgr.js from vb 3.5. It was not needed in my case, and it does not seem to have any differences that can affect the search, but I am not an expert in js.

Rgds

[sv1cec]

Thanks.

I know my site is not moving up to vB 3.5 any time soon, with so many hacks and patches I've made in it, so I thought maybe others are in the same boat as I am, and put this here.

Rgds

[c0d3x]

is possible to change the colour of the selected test?

[Dennis B]

John,

Thanks so much for this simple yet very effective mod. :up:

[akanevsky]

Good mod, however since I use Opera, it is no use to me... How about you do the same thing for opera?

[sv1cec]

I am not sure. You may try to replace that part of the code, with :

PHP Code:

function print_template_javascript()
{
    global $stylevar, $vbphrase, $vboptions;

    print_phrase_ref_popup_javascript();

    echo '<script type="text/javascript" src="../clientscript/vbulletin_templatemgr.js"></script>';

    print_label_row(iif(is_browser('ie') OR is_browser('mozilla', '20040707') OR is_browser('opera'), $vbphrase['search_in_template'], $vbphrase['additional_functions']), iif(is_browser('ie') OR is_browser('mozilla', '1.7'), '
    <input type="text" class="bginput" name="string" accesskey="t" value="' . htmlspecialchars_uni($GLOBALS['searchstring']) . '" size="20" onChange="n=0;" tabindex="1" /> 


And see if it is working. If not, you may also try copying the clientscript/vbulletin_templatemgr.js file from vb 3.5 to your server and see if it will work.

I have absolutely no idea about Opera.

Rgds

[akanevsky]

Nope, it will display the field but won't search.

[sv1cec]

It was far-fetched anyway, sorry!

[Kirk Y]

Brilliant! I wondered why this didn't show in Firefox, excellent hack and thanks for sharing!

[MorrisMcD]

Originally Posted by sv1cec

Maybe you accidentally deleted the next line in that file? Here is what that part of the file should look:

PHP Code:

function print_template_javascript()
{
    global $stylevar, $vbphrase, $vboptions;

    print_phrase_ref_popup_javascript();

    echo '<script type="text/javascript" src="../clientscript/vbulletin_templatemgr.js"></script>';

    print_label_row(iif(is_browser('ie') OR is_browser('mozilla', '20040707'), $vbphrase['search_in_template'], $vbphrase['additional_functions']), iif(is_browser('ie') OR is_browser('mozilla', '1.7'), '
    <input type="text" class="bginput" name="string" accesskey="t" value="' . htmlspecialchars_uni($GLOBALS['searchstring']) . '" size="20" onChange="n=0;" tabindex="1" />
    <input type="button" class="button" style="font-weight:normal" value=" ' . $vbphrase['find'] . ' " accesskey="f" onClick="findInPage(document.cpform.string.value);" tabindex="1" />
    &nbsp;') .
    '<input type="button" class="button" style="font-weight:normal" value="' . $vbphrase['preview'] . '" accesskey="p" onclick="displayHTML();" tabindex="1" />
    <input type="button" class="button" style="font-weight:normal" value=" ' . $vbphrase['copy'] . ' " accesskey="c" onclick="HighlightAll();" tabindex="1" />
    &nbsp;
    <input type="button" class="button" style="font-weight:normal" value="' . $vbphrase['view_quickref'] . '" accesskey="v" onclick="js_open_phrase_ref(0, 0);" tabindex="1" />
    ');
} 


Rgds

Forgot to come back to see if someone answered this yet...

I was missing this

<input type="button" class="button" style="font-weight:normal" value=" ' . $vbphrase['find'] . ' " accesskey="f" onClick="findInPage(document.cpform.string.value); " tabindex="1" />

Not sure how and when I did it.. I thought I was always careful

Thanks for the help

[sv1cec]

Most welcome.