[VB3 RC3] Attachments in private messages

Unsupported. VB3.5 version is here:
https://vborg.vbsupport.ru/showthread.php?t=91220

Tested on 3.0.3

This hack enables you to send attachments in a private message. This feature was really useful to me in vb2 and I kind of missed it on vb3 so I rehacked it myself.

When a user writes a private message they will be given the option to add an attachment, the same as when writing a post. It uses the same rules you have defined for a convencional attachment including file types, quotas, etc. It is only an extension for attachments to be used in private messages.

As always it is advised to backup your files before hacking in case you want to go back, this is some big hack including modification of multiple files, some templates and adding two extra columns in the database tables.

Instructions are provided in the txt, and some screenshots on where the attachment option appears.

Info for hackers:
You may modify, improve, upgrade, redistribute this hack, include it
in another hack or yours or translate it provided you do it free of
charge and you distribute it in www.vbulletin.org at least, there is no
need to pm me asking for permission
Some portions of the code are (c) Jelsoft Enterprises Ltd.

Edit by MarcoH64:
Because of multiple requests to make this hack work on vB3.0.7 i created upgrade instructions. These upgrade instructions can be followed after the original instructions (the 3.0.3 version). The original coder can not be held responsible for my modification.

[hagi]

I set it up and it caused my PM to stop working. So I un-installed the hack and now this is what I get when I click on my normal attachments.

------------------------------------
Database error in vBulletin 3.0.0 Release Candidate 2:

Invalid SQL:
SELECT filename, filesize, postid, attachment.userid,
filedata,
dateline,
visible, mimetype, NOT ISNULL(deletionlog.primaryid) AS isdeleted, private
FROM vb3_attachment AS attachment
LEFT JOIN vb3_attachmenttype AS attachmenttype ON(attachmenttype.extension = SUBSTRING_INDEX(attachment.filename, '.', -1))
LEFT JOIN vb3_deletionlog AS deletionlog ON(attachment.postid = deletionlog.primaryid AND type = 'post')
WHERE attachmentid = 1

mysql error: Unknown column 'private' in 'field list'

mysql error number: 1054
---------------------------------

Any idea to at least fix my attachment table so I can try again?

[Kentaurus]

Originally Posted by hagi

I set it up and it caused my PM to stop working. So I un-installed the hack and now this is what I get when I click on my normal attachments.

------------------------------------
Database error in vBulletin 3.0.0 Release Candidate 2:

Invalid SQL:
SELECT filename, filesize, postid, attachment.userid,
filedata,
dateline,
visible, mimetype, NOT ISNULL(deletionlog.primaryid) AS isdeleted, private
FROM vb3_attachment AS attachment
LEFT JOIN vb3_attachmenttype AS attachmenttype ON(attachmenttype.extension = SUBSTRING_INDEX(attachment.filename, '.', -1))
LEFT JOIN vb3_deletionlog AS deletionlog ON(attachment.postid = deletionlog.primaryid AND type = 'post')
WHERE attachmentid = 1

mysql error: Unknown column 'private' in 'field list'

mysql error number: 1054
---------------------------------

Any idea to at least fix my attachment table so I can try again?

Did you run the queries almost at the end of the file. You are trying to select a "private" column, but your database doesn't have one, until you add the columns there would be some database errors. These are the queries:

ALTER TABLE attachment add private int not null;
ALTER TABLE pmtext add attach int not null;
ALTER TABLE attachment add index (private);

You can run any query in the admin control panel, almost at the end in a section called "Execute SQL Query", for you to be able to run any query in the config.php you should have a line like $canrunqueries = '1';

changing that 1 for whatever your userid is, that is. Or, if your host provides you with phpmyadmin then you can run queries from that.

Please be aware that depending on the size of your attachment table the first query can take a while.

[hagi]

I will redo everything. I think I messed up because that was the first file and not the updated version. Will tell you if everything works

[Boofo]

How about who it is from? And the title (if there's room)?

[hagi]

Edit: Yay it works now. I think it was the way I was executing the queries. I did them one by one instead of my usual all at once and it worked. Works like a charm My post attachments have also started to work fine again. Nice hack *clicks install*

thx for the help also

[SloppyGoat]

I wouldn't mind installing this, but only if the attachments are deleted after they download them. I sure don't want my db getting abused like that.

[Nmidia]

Excellent. I was wondering why it didn't work the first time....I was so intent on not making any mistakes as this was my first sql query update that I forgot to upload the files. Yes, stop laughing at me now.

Works first time. Excellent instructions, for a very useful hack!

[Boofo]

Does this hack follow what you have set for the attchment storage as far as where they are stored? I have mine stored on the disk and not the db.

[Kentaurus]

Originally Posted by SloppyGoat

I wouldn't mind installing this, but only if the attachments are deleted after they download them. I sure don't want my db getting abused like that.

Wouldn't that be a little hard on your users? I usually download an attachment more than once, and after I download it I expect it to remain there. That would seem a little un(user-friendly) to me.

This hack uses the same quotas and options that you have already defined for your attachments so if you have a quota for each user no matter if they attach files to posts or private message once they reach their limit they would have to delete some to continue attaching files.

[Kentaurus]

Originally Posted by Boofo

Does this hack follow what you have set for the attchment storage as far as where they are stored? I have mine stored on the disk and not the db.

It should. It uses the same code that normal posts use for attachments, I just moved that feature to private messages. I tested both the file and db storage and they seemed to be working.