[RELEASE] Poll Hack v1.0.1

[EDIT] Some users found a badley-coded part of the hack, I am rewriting that part and therefore have deleted the url from this post[/EDIT]

The Poll Hack for the vB, now updated for speed and fuctionality. Demo at http://www.naboonline.com/polltest/

new features from 0.9.2 (previous version)

- if a user votes without logging in, is asked to login and the pollvote still counts
(2 new templates,error_pollvotenologin, error_pollvoteinvaliduser)
- Graphical view of poll results available. Template pollyesvote has a new variable $pollbargraph. If you
do not want to have the graphical view, simply remove the variable.
- poll icon ist now not needed to be inserted into the vBulletin icon db.
- new file pollmodule.php - hacks in files only reference to it, much less code to enter into the new files!
- speed enhancements and less mysql calls.

Overall features

- Let registered users post a new thread that has a poll integrated in it
- Let registered users vote on the poll
- Multiple votes impossible as userid is stored on vote
- Define # of poll options in CP
- Limit who can post a poll by usergroups (from the control panel)
- Designed to be easily translated. Only some text is hard coded (see localisation section below)
- Fully templateable - you can customise the look of the poll
- Users who can not post can not vote as well
- Make sure person did not vote, press back, and vote again
- Admin/Moderator edit of Polls at all times
- Edit Poll while no votes (for user who started the poll thread)
- vB code parse for options
- closing a thread == close a poll
- Admin delete
- View results without voting
- Close a poll (admin/mod/author)
- Graphical view of votes (bar graph and/or pie graph) **NEW**

Note to upgraders: Due to a change in the how data is stored, the new poll is not backwards compatible. Therefore, you will need to run updatepoll.php

The poll hack will be intergrated into vBulletin 2.0, so if you are in no hurry, you should better wait


[Edited by doron on 11-04-2000 at 06:00 AM]

This hack is very unoptimized....the person who told me this will remain anonymous.

Wasn't I as I have never actually looked at it other than to help fix todays problem..

Hmm, after looking through the code, the killer lies here:

  $pollidcheck=$DB_site->query_first("SELECT pollid FROM post WHERE threadid=$threadid");

That SQL query is issued for each table row displayed in forumdisplay, so if you have 50 threads listed per page, thats 50 extra queries.

ouch...maybe I should take this off for now.

Originally posted by VirtueTech
This hack is very unoptimized....the person who told me this will remain anonymous.

I would love to see their version of it.

It's easy to sit back and complain about the work of others, not so easy to do it yourself. Your source would do well to remember that doron is doing this out of the goodness off his heart and doesn't have to contribute anything at all.

Originally posted by Stallion
Hmm, after looking through the code, the killer lies here:

  $pollidcheck=$DB_site->query_first("SELECT pollid FROM post WHERE threadid=$threadid");

That SQL query is issued for each table row displayed in forumdisplay, so if you have 50 threads listed per page, thats 50 extra queries.

Sorry for this confusion, I was working fast to fix that spce in name thing that I messed some stuff up. argghhh

that is need however, as forumdisplay checks threads, not posts. And users wanted to have the poll icon showed without it being choosen. I could add a table to thread which would help. You can remove that code, but the custom icon won't show then.

http://www.naboonline.com/pollhack/pollmodule.php has the fix for the nonescaped showresults, it regressed cause of trying to fix the space thing at 1 AM here, and I was not thinking correctly.

I'll fix the pollidcheck thing today and add a column to the thread table.

Sorry again for this, I shoudl have tested this more, but I had 30 people email me last week requesting this hack.

ok, I now have the optimised version done, thanks to Ed for finding that. i had removed such code away from all other files before, somehow forgot to do that for forumdisplay.php

http://www.naboonline.com/pollhack/pollupgrade.zip is for those who are stuck with the unoptomised version.
http://www.naboonline.com/pollhack/pollv101.zip has the full version

If anyone else finds anything wrong, don't hesitate to tell.

thanks to you all for testing this and all, I guess I should be spanked for this (anyone have a paddle)?

Works just fine. Thanks to all.

Hello Martin,

The comment made about the hack was simply to notify everyone about the truth of the hack....the person who I will still keep anonymous is very understanding that the hack was out of the goodness of dorons heart....we were just making him aware....and thanks goes to doron for his fix.

I keep getting this error emailed to my administrators email address:

Database error in vBulletin: Invalid SQL: SELECT threadid FROM post WHERE pollid=
mysql error: You have an error in your SQL syntax near '' at line 1
mysql error number: 1064
Date: Saturday 04th of November 2000 03:27:00 PM
Script: /poll.php
Referer: http://209.15.159.99/poll.php

Any ideas?