Infraction Hook

[MarkFL]

Originally Posted by Dragonsys

I will have to do some checking on my test site and see how GPC['points'] is returned.
I think the hook is right, just need to figure out what is being returned, so we can use it properly

On my local dev site, it returns the number of points for the infraction being issued.

[Dragonsys]

Originally Posted by MarkFL

On my local dev site, it returns the number of points for the infraction being issued.

ok, so for a Warning it should return 0 and an Infraction it should be >0 or is it <0?

--------------- Added [DATE]1450894187[/DATE] at [TIME]1450894187[/TIME] ---------------

Chris, what version of vBulletin are you running?

[MarkFL]

Yes for a warning it returns 0 and, for example if I issue a custom infraction for 1 point, it returns 1.

[Dragonsys]

Originally Posted by MarkFL

Yes for a warning it returns 0 and, for example if I issue a custom infraction for 1 point, it returns 1.

strange, then the code should work. it should have worked by using != 0

--------------- Added [DATE]1450894799[/DATE] at [TIME]1450894799[/TIME] ---------------

Ok, let's try removing some of the unneeded code and just getting the basics.

PHP Code:

global $vbulletin, $db, $userinfo;

    if ($userinfo['ipoints'] > 0)
    {
        $newrep = ($userinfo['reputation'] - $userinfo['ipoints']*500);
    }
    else
    {
        $newrep = ($userinfo['reputation'] - 150);
    }

    $vbulletin->db->query_write("
        UPDATE " . TABLE_PREFIX . "user
        SET reputation = " . $newrep . "
        WHERE userid = " . $userinfo['userid']
    ); 


Does this work? It should subtract points for Warning & Infraction

[MarkFL]

Originally Posted by Dragonsys

strange, then the code should work. it should have worked by using != 0

This is the last block of code you posted:

PHP Code:

global $vbulletin, $db, $userinfo;

if ($vbulletin->GPC['points'] > 0) {
    $points = $userinfo['ipoints'];
    $rep = $userinfo['reputation'];

    if ($points > 0)
    {
        $newrep = ($rep - $points*500);
    }
    else
    {
        $newrep = ($rep - 150);
    }

    $vbulletin->db->query_write("
        UPDATE " . TABLE_PREFIX . "user
        SET reputation = " . $newrep . "
        WHERE userid = " . $userinfo['userid'] .""
    );
} 


The only issue I can see is with the quotes at the end of the query...I would write:

PHP Code:

global $vbulletin, $db, $userinfo;

if ($vbulletin->GPC['points'] > 0) {
    $points = $userinfo['ipoints'];
    $rep = $userinfo['reputation'];

    if ($points > 0)
    {
        $newrep = ($rep - $points*500);
    }
    else
    {
        $newrep = ($rep - 150);
    }

    $vbulletin->db->query_write("
        UPDATE " . TABLE_PREFIX . "user
        SET reputation = " . $newrep . "
        WHERE userid = " . $userinfo['userid']
    );
} 


What this should do is if a user is being issue a warning, nothing happens. If they are being issued an infraction, then if prior to the current infraction they have current active points, they will have 500 rep points deducted per current active infraction points, otherwise their rep will simply be reduced by 150.

--------------- Added [DATE]1450895509[/DATE] at [TIME]1450895509[/TIME] ---------------

Originally Posted by Dragonsys

...Ok, let's try removing some of the unneeded code and just getting the basics.

PHP Code:

global $vbulletin, $db, $userinfo;

    if ($userinfo['ipoints'] > 0)
    {
        $newrep = ($userinfo['reputation'] - $userinfo['ipoints']*500);
    }
    else
    {
        $newrep = ($userinfo['reputation'] - 150);
    }

    $vbulletin->db->query_write("
        UPDATE " . TABLE_PREFIX . "user
        SET reputation = " . $newrep . "
        WHERE userid = " . $userinfo['userid']
    ); 


Does this work? It should subtract points for Warning & Infraction

That will only take into account a user's prior active infraction points, so there will be no difference in what's done between a warning and an infraction being issued.

[Dragonsys]

Originally Posted by MarkFL

The only issue I can see is with the quotes at the end of the query

Right, that was just checking to see if he was getting a SQL error

Originally Posted by MarkFL

What this should do is if a user is being issue a warning, nothing happens. If they are being issued an infraction, then if prior to the current infraction they have current active points, they will have 500 rep points deducted per current active infraction points, otherwise their rep will simply be reduced by 150.

I had that and he said ti didn't subtract any points

Originally Posted by MarkFL

That will only take into account a user's prior active infraction points, so there will be no difference in what's done between a warning and an infraction being issued.

Correct, I'm trying to see if the basics work, and then figure out why he is having problems with the if statement.

[MarkFL]

Using the last block of code you posted (with the query edited to remove your test quotes), I tested it on a user on my local dev site who initially had 13 ipoints and 10 rep points. After I issued a 3 point infraction, his ipoints became 16 and his rep became -6490 (which is what we should expect).

This means that at the hook we are using, the ipoints value was still at 13 and $vbulletin->GPC['points'] > 0.

Then I issued that same user a warning, and his rep was unaffected.

The bottom line is the code you posted works flawlessly for me.

[Dragonsys]

Originally Posted by MarkFL

Using the last block of code you posted (with the query edited to remove your test quotes), I tested it on a user on my local dev site who initially had 13 ipoints and 10 rep points. After I issued a 3 point infraction, his ipoints became 16 and his rep became -6490 (which is what we should expect).

This means that at the hook we are using, the ipoints value was still at 13 and $vbulletin->GPC['points'] > 0.

Then I issued that same user a warning, and his rep was unaffected.

The bottom line is the code you posted works flawlessly for me.

Ok, i wonder why it is not working for Chris then.

[MarkFL]

Oh, if I had a dollar for every time I have wondered, "Why does it work for me, but not the other user?"

[Dragonsys]

Originally Posted by MarkFL

Oh, if I had a dollar for every time I have wondered, "Why does it work for me, but not the other user?"

I know