Major Additions - microNEWSLETTER (Mailinglist Manager)

*** Link Removed ***

[NFLfbJunkie]

I have cPanel but do not have exactly 'mail log manager'. I have the 'Email Address to include as: From Email' set as my personal email. Does this email need to be a domain email address, such as contact@mysite.com?

[NFLfbJunkie]

I also just realized I can't edit messages. When I click edit all I get is the original subject but the message doesn't show.

[Skyrider]

Received an error when running the CRON:

Database error in vBulletin 4.0.1:

Invalid SQL:
SELECT * FROM micronewsletter_subscribers WHERE email='Don'xxxxx@hotmail.com' ORDER BY email ASC LIMIT 1;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'xxxx@hotmail.com' ORDER BY email ASC LIMIT 1' at line 1
Error Number : 1064
Request Date : Tuesday, January 26th 2010 @ 09:12:29 PM
Error Date : Tuesday, January 26th 2010 @ 09:12:31 PM
Script : http://xxxxx/admincp/cronadmin.php?d...ron&cronid=117
Referrer : http://xxxx/admincp/cronadmin.php?do=modify
Username : FF|Skyrider
Classname : vB_Database
MySQL Version : 5.0.32-Debian_7etch11-log

[UpFriends]

Thank you, Thank you, Thank you for this!

[Skyrider]

Seems CRON doesn't like any ' in the email.

[UpFriends]

Downloaded, installed, and nominated

[MaryTheG(r)eek]

Originally Posted by FF|Skyrider

Received an error when running the CRON:

To check for valid/invalid email address, I'm using the native vB function "is_valid_email()". Normally it must reject the email and continue to the next one. Strange that it brings mysql error.

Maria

[thincom2000]

missing $db->escape_string?

[Krali]

What is the link for users to unsubscribe?

I want to add it under a navigation button in the main menu, not only in the newsletter mail.

Great Mod and looking forward to full (pro) version.

[MaryTheG(r)eek]

Originally Posted by thincom2000

missing $db->escape_string?

I don't think so, as this is just a few lines before. Actually the problem is why this email has been accepted. I also added this function in the cron, just for an additional security check, but the problem is before, during record's save.

I seen again the code, and seems to me correct:

    $vbulletin->input->clean_array_gpc('p', array(
        'subscriberid'  => TYPE_INT,
        'groupid'       => TYPE_INT,
  'email'      => TYPE_STR
 ));
    // Get Values
    $subscriberid = $vbulletin->GPC['subscriberid'];
    $groupid = $vbulletin->GPC['groupid'];
 $email = $db->escape_string($vbulletin->GPC['email']);
    if($subscriberid != 0)
    {
       if(is_valid_email($email))
       {
          $vbulletin->db->query_write("UPDATE " . TABLE_PREFIX . "micronewsletter_subscribers
                                       SET groupid = '$groupid',
                                           email = '$email' WHERE id=$subscriberid");
       } else {
         $vbulletin->url="newsletter.php?" . $vbulletin->session->vars['sessionurl'] . "do=main&tab=5";
         eval(print_standard_redirect('micronewsletter_invalid_email', true, true));
       }
    } else {
       if(is_valid_email($email))
       {

First I'm escaping the string and then I'm checking for valid email address. The only that maybe is wrong, is if it needs something else than "TYPE_STR". Is there "TYPE_EMAIL" ??

Maria