Board Optimization - Super Speedy UserCP

TIME TO INSTALL: 10 seconds (requires editing of one file in one place)

This simple code modification increases my usercp.php loading speed by 6x. I think it will be most useful in cases where there are many subscribed forums.

It is listed as a modification for version 3.8.3 (which I am currently working with), but this mod works as far back as 3.0.1 (the 'find' text might be slightly different, but the function name and the text you replace is the same).
EDIT: Tested up to 3.8.4.

It works because the php function is_array() is excruciatingly slow, and an empty array gives the same return value as an empty variable.

This code would likely break if someone introduced a location in the code where the $lastpostarray variable was set to something (i.e. not nothing) that was not an array.

There are lots of these checks in the vBulletin code. It's likely that further speed increases could be achieved by changing more of them -- just remember that there is an unlikely circumstance (see previous paragraph) where it would cause problems. If you find other locations with significant effects, please post them in a reply!

##### IN FILE

functions_forumlist.php

##### FIND

function construct_forum_bit($parentid, $depth = 0, $subsonly = 0)
{
global $vbulletin, $stylevar, $vbphrase, $show;
global $imodcache, $lastpostarray, $counters, $inforum;

// this function takes the constant MAXFORUMDEPTH as its guide for how
// deep to recurse down forum lists. if MAXFORUMDEPTH is not defined,
// it will assume a depth of 2.

// call fetch_last_post_array() first to get last post info for forums
if (!is_array($lastpostarray))

##### REPLACE

if (!is_array($lastpostarray))

##### WITH

if (!$lastpostarray)

#####

And that's it! Enjoy, and I hope it helps!

[ChiNa]

Somebody said that he made a mistake,,, Now can anyone follow up to what is right 1 or 2?

Options1: if (!i$lastpostarray)

Option2: if ($lastpostarray)

Thank you in advance...

[Birched]

I am using it as written in the OP.

EDIT: to be clear: the typo a few years back was that I had an extra 'i' in the code. You want to use the text in the original post, which is not option 1 or option 2 in your post, but:

Option 3: if (!$lastpostarray)

[ChiNa]

Ohh Ok, U actually have edited your post then, bcoz that was what I did use too.. if (!$lastpostarray)

One last question, is it ok to use on a vBulletin 3.8.6 or 3.8.7.. I mean I wont get later any affect on my other pages or maybe errors...

Thanks for the tip

[Birched]

Should be fine for 3.8.x. Definitely works for 3.8.6.

[ChiNa]

Thanks, Birched, What about the 3.8.7, its Same as 3.8.6, Am sure it will work out too.. Coz almost the optiones and files are same, Thanks a lot for your time mate... Appreciated.

[tehPARADOX]

Thanks.

[career]

can't see difference when enable it.
Pls, could you suggest how to test it.

thanks

[lazytown]

Any idea if this issue affects 4.2?

[xlguy]

Have just tried this on 3.8.7 PL2

[blind-eddie]

Originally Posted by xlguy

Have just tried this on 3.8.7 PL2

Yes, don't use this edit.
It shows forum home to have zero post & sets all forums to private, But, your results may differ.