Go Back   vb.org Archive > vBulletin Modifications > Archive > vB.org Archives > vBulletin 3.6 > vBulletin 3.6 Add-ons
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools
Rewrite eBay Links Details »»
Rewrite eBay Links
Version: 1.4, by Dismounted Dismounted is offline
Developer Last Online: Apr 2023 Show Printable Version Email this Page

Category: Add-On Releases - Version: 3.6.x Rating:
Released: 04-06-2007 Last Update: 10-12-2008 Installs: 186
Uses Plugins
Additional Files  
No support by the author.

Rewrite eBay Links

Description:
This mod rewrites eBay links so they link to an affiliate.

Request:
Requested in a paid deal by brookelyn, this modification's idea can also be accredited to brookelyn. Also requested by various other members.

Installation:
All the installation information is in the package.

Changes:
2 Plugins
1 File

Supporters / CoAuthors

Show Your Support

  • This modification may not be copied, reproduced or published elsewhere without author's permission.

Comments
  #332  
Old 11-25-2008, 04:42 AM
Dismounted's Avatar
Dismounted Dismounted is offline
 
Join Date: Jun 2005
Location: Melbourne, Australia
Posts: 15,047
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

It shouldn't "double-rover" them. It shouldn't be even touching those links. But what could go wrong, will go wrong, so I'll look into if I have the time.
Reply With Quote
  #333  
Old 11-25-2008, 09:47 AM
benFF benFF is offline
 
Join Date: Jul 2004
Posts: 86
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Cheers
Reply With Quote
  #334  
Old 12-01-2008, 03:08 PM
benFF benFF is offline
 
Join Date: Jul 2004
Posts: 86
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quoted posts also fall foul of this.
Reply With Quote
  #335  
Old 12-06-2008, 06:51 PM
Big Kahuna's Avatar
Big Kahuna Big Kahuna is offline
 
Join Date: Feb 2002
Location: SE Texas
Posts: 182
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by noppid View Post
The problem is the encoded ampersand on the item URL var.

urlencode is doing it. I had this issue in an eBay Developer Application I run.

In the functions file on like line 57, add one line of code after the urlencode that looks like this.

PHP Code:
    // encode URL
    
$encodedlink urlencode($rightlink);
    
$encodedlink str_replace("%26amp%3B""&" $encodedlink); 
That fixed it for us. YMMV.

OK -- when you say functions file are you talking about the /includes/function.php -- because if so, in that file, my first occurrence of the word urlencode is not anywhere near line 57-- by line 1376.

I'd like to get this fix -- but I don't want to screw things up worse by following half instructions making the assumption I know the key to the other half.

What is the exact file I need to modify and what is the phrase I need to search for to insert the patch afterward?

Thank you
Reply With Quote
  #336  
Old 12-06-2008, 06:57 PM
Big Kahuna's Avatar
Big Kahuna Big Kahuna is offline
 
Join Date: Feb 2002
Location: SE Texas
Posts: 182
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I figured it out -- silly me for not reading minds well enough -- functions files is code (to throw off dumb-asses like me) for the file /includes/functions_rewrite_ebay_links.php
Reply With Quote
  #337  
Old 12-06-2008, 07:09 PM
Big Kahuna's Avatar
Big Kahuna Big Kahuna is offline
 
Join Date: Feb 2002
Location: SE Texas
Posts: 182
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by noppid View Post
Glad to help. When I saw the bug and that dismounted was busy, I had to do something. I use this hack and it's important to us. So, hopefully this can be the permanent fix.

This is shorter.

PHP Code:
$encodedlink str_replace("%26amp%3B""&" urlencode($rightlink)); 

That appears to be the fix.
Reply With Quote
  #338  
Old 12-06-2008, 08:49 PM
creativepart creativepart is offline
 
Join Date: Jun 2006
Posts: 116
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Hey Dismounted,

I had a HUGE problem with the rewrite mod this week. Someone posted a link to a non-auction HTML page that is on ebay.com on my forum running this mod.

Naturally, the mod rewrote the link and put my campid and rover coding on this static html page link.

Then one of my members ran an auction on EBay and he decided to put a link to this static page in his auction description. He could not find the URL but he remembered he had seen it on my website. So, he went there and copied the link and placed it in his EBay Auction Description.

All this was, of course, unbeknownst to me.

Within an hour or two of him posting that auction I received an email from Ebay closing my EPN Affiliate account and seizing all of my earnings.

Luckily, I have an EPN rep that I can turn to with issues and problems. I called my rep and we figured it out and we found the problem and the guy that posted the link containing my affiliate coding notified Ebay that I wasn't involved and that it was an accident.

The next day I did get my account back.

But everyone should know that if for any reason one of your converted links ends up in an Ebay Auction, Blog, or even Ebay Forum you'll get booted out of EPN within hours of the posting. I was told that that any Affiliate coding link on any Ebay Hosted page will get you booted.

This mod needs to be fixed to NOT convert anything but auction URLs. It has to be made so that it will ignore ebay.com urls that do not contain the rest of the auction part of the URL.

PS They also said -- and this is a different subject but important too for people using this mod to know -- that you can not put your affiliate coding on any auction that you are conducting. So, if you are running Ebay auctions in the same niche as your forum and using the rewrite mod be sure that none of your auctions can show up on your forum with your Affiliate coding.
Reply With Quote
  #339  
Old 12-07-2008, 06:42 AM
Dismounted's Avatar
Dismounted Dismounted is offline
 
Join Date: Jun 2005
Location: Melbourne, Australia
Posts: 15,047
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Could your EPN rep give me specific "URL-types" to only rewrite?

That would be great.
Reply With Quote
  #340  
Old 12-31-2008, 09:33 PM
creativepart creativepart is offline
 
Join Date: Jun 2006
Posts: 116
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Sorry, I didn't see this earlier.

The mods needs to be able to tell the difference between an auction URL and simply the letters "e b a y . c o m" anywhere in any URL. As was pointed out a long time ago, a URL for a place called Tine Bay had rover tags put on it because it was tinebay.com

In my case a URL for a non-auction page like ebay.com/disclosure.htm had rover links put on it and this is what got posted into a real Ebay Auction description and caused all the problems.
Reply With Quote
  #341  
Old 01-02-2009, 10:21 PM
ShadMan ShadMan is offline
 
Join Date: Sep 2005
Location: Houston, TX
Posts: 30
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thanks, noppid!
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 03:07 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.10204 seconds
  • Memory Usage 2,310KB
  • Queries Executed 26 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (2)bbcode_php
  • (2)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)modsystem_post
  • (1)navbar
  • (6)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (11)post_thanks_box
  • (11)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (11)post_thanks_postbit_info
  • (10)postbit
  • (11)postbit_onlinestatus
  • (11)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete