Add-On Releases - Rewrite eBay Links

Rewrite eBay Links

Description:
This mod rewrites eBay links so they link to an affiliate.

Request:
Requested in a paid deal by brookelyn, this modification's idea can also be accredited to brookelyn. Also requested by various other members.

Installation:
All the installation information is in the package.

Changes:
2 Plugins
1 File

[Dismounted]

Sorry, I haven't had any time to look at anything.

[noppid]

Originally Posted by ShadMan

Same thing is happening on mine, starting today. Here is the original link posted on my forum:

http://cgi.ebay.com/ws/eBayISAPI.dll?ViewItem&ssPageName=STRK:MEWAX:IT&item=140159953844

And here is what the link was re-written to, which gives the "Invalid Item" page:

http://rover.ebay.com/rover/1/711-53200-19255-0/1?campid=5335887982&toolid=10001&mpre=http%3A%2F%2Fcgi.ebay.com%2Fws%2FeBayISAPI.dll%3FViewItem%26amp%3BssPageName%3DSTRK%3AMEWAX%3AIT%26amp%3Bitem%3D140159953844

This results in some additional characters being placed into the URL (see bold and compare to original link above):

http://cgi.ebay.com/ws/eBayISAPI.dll?ViewItem&ssPageName=STRK:MEWAX:IT&item=140159953844

The problem is the encoded ampersand on the item URL var.

urlencode is doing it. I had this issue in an eBay Developer Application I run.

In the functions file on like line 57, add one line of code after the urlencode that looks like this.

PHP Code:

    // encode URL
    $encodedlink = urlencode($rightlink);
    $encodedlink = str_replace("%26amp%3B", "&" , $encodedlink); 


That fixed it for us. YMMV.

[ashley76]

Thanks Noppid! That did the trick!

[noppid]

Originally Posted by ashley76

Thanks Noppid! That did the trick!

Glad to help. When I saw the bug and that dismounted was busy, I had to do something. I use this hack and it's important to us. So, hopefully this can be the permanent fix.

This is shorter.

PHP Code:

$encodedlink = str_replace("%26amp%3B", "&" , urlencode($rightlink)); 


[dwessell]

Thanks Noppid, much appreciated!

[rinkrat]

Works great!

[benFF]

This goes horribly wrong if someone posts up an already rovered link or forwards a PM which has been pre-rovered as it then double rovers them, which breaks all the links..

It should really look if the link has been rovered and if so, strip the url out and rover it with your own settings.

[benFF]

Oh and if a user edits a post which has an ebay link and had already been changed - it completely destroys it.

[BadgerDog]

Originally Posted by benFF

This goes horribly wrong if ...... <snip>

Are you referring to noppid's fix?

... or, v1.4 of the mod itself without the fix?

Thanks ...

Regards,
Badger

[benFF]

Both. The fix doesn't stop double / triple rewrites.

We need a v1.5 which doesn't rewrite the link if a rover address already exists - and if it does, make sure it's using thr right rover settings and modify if appropriate.