Search for Posts in Thread by Username

<font size="3">Search for Posts in Thread by Username</font>

Description
Do you know that? You are searching for that one Post in a single Thread made by a specific User, but you can't remember the Text.
Unfortunately the Thread is several hundred Posts long - and the User has tons of Posts in the Forum that Thread belongs to.
So searching for Keywords in the Thread doesn't work, and searching for the Posts made by the User also doesn't help much.
This Hack solves the Problem by allowing you to search for Posts from a specific User made in a specific Thread.

Details
1 Plugin XML
1 Template Edit

History
1.0.0
Initial Version

1.0.1
vBulletin 3.5.2 compatibility

Please only click Install if you actually have installed/are using this Hack, and click Uninstall whan you don't use it any longer!

[Andreas]

Whoops
Gonna have to update the instructions then.
Thanks for pointing that out.

[buro9]

Originally Posted by KirbyDE

@buro9
Yes, it's possible.
do=process&searchthreadid=X&userid=Y

Fantastic... installed.

But... there's a bug.

If I search a thread for a user:
search.php?do=process&amp;searchthreadid=133&amp;u serid=267

And then perform a search for another user against the same thread:

search.php?do=process&amp;searchthreadid=133&amp;u serid=389

The first results always comes back.

It's as if vBulletin caches the search result according to the threadid and pays no attention to the userid.

If you want to view this on mine, just click the Who Posted link and you'll see that I've made the Who Posted popup link back via the postcount to the search result. Except... it has that bug.

[Andreas]

Yes, vBulletin does cache the results without taking the Username into account - and there is no way to get around this limitation without editing search.php.
(Except "disabling" caching results for this search, which I did on my site).

[buro9]

Originally Posted by KirbyDE

Yes, vBulletin does cache the results without taking the Username into account - and there is no way to get around this limitation without editing search.php.
(Except "disabling" caching results for this search, which I did on my site).

I can totally do that How though?

I already have search result sharing disabled in my AdminCp > vBulletin Options > Message Searching Options.

Is there another way around this... did you comment out some code to achieve this?

(btw... disabling the search cache would fix a bug in vBulletin where it's possible to get someone elses search results and have the results ordered incorrectly).

So totally up for this, how though

[buro9]

Originally Posted by buro9

I can totally do that How though?

Done it... commented out a chunk of search.php

[Andreas]

I used a somewhat dirty trick to avoid file edits

search_process_start

PHP Code:

if ($searchuser AND $vbulletin->GPC['searchthreadid'] AND !$vbulletin->GPC['query'])
{
$realuserid = $vbulletin->userinfo['userid'];
$vbulletin->userinfo['userid'] = -1;
} 


search_process_fullsearch

PHP Code:

$vbulletin->userinfo['userid'] = $realuserid; 


This way vBulletin does not find a valid searchhash and performs a new search.

[buro9]

Originally Posted by KirbyDE

I used a somewhat dirty trick to avoid file edits

search_process_start

PHP Code:

if ($searchuser AND $vbulletin->GPC['searchthreadid'] AND !$vbulletin->GPC['query'])
{
$realuserid = $vbulletin->userinfo['userid'];
$vbulletin->userinfo['userid'] = -1;
} 


search_process_fullsearch

PHP Code:

$vbulletin->userinfo['userid'] = $realuserid; 


This way vBulletin does not find a valid searchhash and performs a new search.

Brilliant and very amusing.

I think I'll stick with file edits though, I'm comfortable with them and can upgrade even my heavily modded board in less than 30 minutes with all hacks migrated... a short enough time for me to care about, and at least I have no plugin overhead.

Hey... have you published your private hack to prevent pulling in plugins all the time? You have one don't you? (imagines it writes .php files out during plugin installs and just puts include statements into the hooks)

[Andreas]

I've got a neat Windows proggy to slipstream plugins into vBulletin, yes.
But I havn't updated it to process product XMLs ... yet.

My board is so hacked that even with Tools like Beyond Compare, the last upgrade (3.0.0 RC2 -> 3.0.6) took some hours to get it working again without errors, although the new Version had been tested before by the whole team for some days.
Not to mention the Style stuff which took weeks.

[Neal-UK]

Originally Posted by KirbyDE

I've got a neat Windows proggy to slipstream plugins into vBulletin, yes.
But I havn't updated it to process product XMLs ... yet.

My board is so hacked that even with Tools like Beyond Compare, the last upgrade (3.0.0 RC2 -> 3.0.6) took some hours to get it working agin without errors, although the new Version had been tested before by the whole team for some days.
Not to mention the Style stuff which took weeks.

excellent mod, nice one again

[buro9]

Originally Posted by KirbyDE

My board is so hacked that even with Tools like Beyond Compare, the last upgrade (3.0.0 RC2 -> 3.0.6) took some hours to get it working again without errors, although the new Version had been tested before by the whole team for some days.

Not to mention the Style stuff which took weeks.

Yeah, that's where mine is. I eventually invested in Slick Edit and keep a very tightly controlled set of conventions over marking up hacks within the code, the changes made, etc. Done well file changes are easy to migrate and not too time consuming.

Style changes take time though, that I'll admit, but that would be the case even with the plugin system. Especially because most of the time I cut 'n' paste the templates into Slick Edit so that I can use a powerful diff and merge tool to make the new version.

I dread to think how difficult it will be to upgrade when I finish the XHTML Strict style I've been hacking together for weeks (reduced tables, highly semantic).