Remove 1 Database Query Per Page

Remove 1 Database Query Per Page

Intro:
The idea is, lets remove 1 query from each page load, if the person is just refreshing the page. At first this may sound not important or just plain stupid, but on "larger" forums, cutting 1 query is always welcomed I know.

Description:
Basically all this does, is check the current Session Location from the DB against the current WOL path; the Session is already provided by vbulletin, so no extra query there.

All we do, is simply check the Location from the Database against the current WOL, if they don't match then the query is allowed to update the database; if they are the same - it is simply ignored.

Affects:
The only things this will do, is prevent the updating of the "lastactivity", and "location" if a person keeps refreshing the page, IMO that's not really a big deal, vbulletin takes care of deleting and remaking new sessions when they expire anyway. As long as your members are browsing around and such, their lastactivity, location will be updated as per usual.

Updates:
Version 1.1 - Scripts whosonline, misc are allowed to always update.
Version 1.0 - Release

Instructions:
1. [ open includes/sessions.php ]
2. [ go to about line 354, or look for $bypass = intval(SESSION_BYPASS); ]
3. [ replace this block of code ]

PHP Code:

    $DB_site->shutdown_query("
        UPDATE " . TABLE_PREFIX . "session
        SET useragent = '" . addslashes(USER_AGENT) . "', lastactivity = " . TIMENOW . $location . ", styleid = $styleid" . iif(VB_AREA !== 'Upgrade', ", bypass = $bypass") . "
        ###REPLACE###
        WHERE sessionhash = '" . addslashes($session['sessionhash']) . "'"
        , 'sessionupdate'
); 


4. [ with this block of code]

PHP Code:

    /**
     * Update Location On Page Change
     *
     * @author Trigunflame
     * @version 1.1
     * @copyright Dusty Burns 2005-2006
     */

    // Check Script
    if ($session['location'] != WOLPATH || THIS_SCRIPT == 'misc' || THIS_SCRIPT == 'online')
    {
        $DB_site->shutdown_query("
            UPDATE " . TABLE_PREFIX . "session
            SET useragent = '" . addslashes(USER_AGENT) . "', lastactivity = " . TIMENOW . $location . ", styleid = $styleid" . iif(VB_AREA !== 'Upgrade', ", bypass = $bypass") . "
             ###REPLACE###
             WHERE sessionhash = '" . addslashes($session['sessionhash']) . "'"
            , 'sessionupdate'
        );
    }

    /**
     * End Update Locations On Page Change
     */ 


5. [ save file ]

[Deaths]

It's usefull for people who are new to PHP, but still want to optimize code a little.

Anyway, its your hack, your choice

[twoseven]

i've been programmig so long that i read || as OR its just as readable imo.

[Trigunflame]

*wonders why my thread has become a php syntax discussion*

[Marco van Herwaarden]

Originally Posted by Trigunflame

*wonders why my thread has become a php syntax discussion*

If you would like to make a comment, you should start with a '/*' and end with '*/', not just a '*':

PHP Code:

/*wonders why my thread has become a php syntax discussion*/ 


[buro9]

/* You should really leave spaces around those comments too. */

[WebMasterAJ]

So... lol... is this working for everyone? Sorry to bring this thread... umm... back on topic. :lol:

[Erwin]

Good idea. You're right, shutdown queries don't show up on the microstats... hence I saw no difference when I installed this. That 1 query really doesn't make a huge difference considering what it's doing. But theoretically if you don't need that query, why have it there?

[Trigunflame]

Originally Posted by Erwin

Good idea. You're right, shutdown queries don't show up on the microstats... hence I saw no difference when I installed this. That 1 query really doesn't make a huge difference considering what it's doing. But theoretically if you don't need that query, why have it there?

That could be said about a lot of code vbulletin has

ps. I tried this on a forums im workin with, has on average 2000+ online; it "did" cut down his load somewhat by the reduce in just that 1 query.

[Trigunflame]

*wonders how many people have actually used this*

Surprised not that many... oO

[WebMasterAJ]

I have it installed... it can't hurt.