Kill 1 Query In BBCode Manager (ACP)

While looking through bbcode.php in admincp/, i noticed that a global query was executed on all of it's pages, however only 2 actions need this query to be executed, so its a useless query on other pages within the BBCode Manager.

In admincp/bbcode.php
Find:

PHP Code:

$bbcodes = $DB_site->query("SELECT bbcodetag, bbcodereplacement, twoparams FROM " . TABLE_PREFIX . "bbcode");
$searcharray = array();
$replacementarray = array();
$doubleRegex = "/(\[)(%s)(=)(['\"]?)([^\"']*)(\\4])(.*)(\[\/%s\])/siU";
$singleRegex = "/(\[)(%s)(])(.*)(\[\/%s\])/siU";

while ($bbcode = $DB_site->fetch_array($bbcodes))
{
    if ($bbcode['twoparams'])
    {
        $regex = sprintf($doubleRegex, $bbcode['bbcodetag'], $bbcode['bbcodetag']);
    }
    else
    {
        $regex = sprintf($singleRegex, $bbcode['bbcodetag'], $bbcode['bbcodetag']);
    }
    $searcharray[] = $regex;
    $replacementarray[] = $bbcode['bbcodereplacement'];
} 


Replace It With:

PHP Code:

if($_REQUEST['do'] == "test" || $_REQUEST['do'] == "modify"){

    $bbcodes = $DB_site->query("SELECT bbcodetag, bbcodereplacement, twoparams FROM " . TABLE_PREFIX . "bbcode");
    $searcharray = array();
    $replacementarray = array();
    $doubleRegex = "/(\[)(%s)(=)(['\"]?)([^\"']*)(\\4])(.*)(\[\/%s\])/siU";
    $singleRegex = "/(\[)(%s)(])(.*)(\[\/%s\])/siU";

    while ($bbcode = $DB_site->fetch_array($bbcodes))
    {
        if ($bbcode['twoparams'])
        {
            $regex = sprintf($doubleRegex, $bbcode['bbcodetag'], $bbcode['bbcodetag']);
        }
        else
        {
            $regex = sprintf($singleRegex, $bbcode['bbcodetag'], $bbcode['bbcodetag']);
        }
        $searcharray[] = $regex;
        $replacementarray[] = $bbcode['bbcodereplacement'];
    }
} 


I know it's not much, but every little helps!

- Zero Tolerance

[Polo]

Originally Posted by Oblivion Knight

Still if a query can be killed where it isn't needed, that can only be a good thing and I don't see why Jelsoft aren't taking this into consideration.

I totally with you Oblivion Knight

[Oblivion Knight]

I have a feeling this change is the cause of an error when removing custom BB Codes..
Warning: Empty regular expression in /admincp/bbcode.php on line 300


[EDIT]
Yup, I removed the if statement and the error disappeared when removing another custom BB Code.

[Yorixz]

Thanks; all improvements in speed are welcome