MultiQuote

Introduction
This multiquote hack allows your members to select multiple posts to quote from. These posts can be on a different page, in a different thread, or on an entirely different forum. Don't worry, the hack checks to make sure the user has read permissions on the post so no sneaky members can insert random post ID's in hopes to find what's going on in your secret staff forums.

What's new in this "version 2"?

• Better programmed!
• "Go Advanced" works with Quick Reply
• Fixed the bug with IE not "turning on" the MQ icons when re-viewing a thread with MQ'd posts.
• Included vB3-styled icons (I just resized the images posted by Hoffi -- thanks Hoffi!)

Overview

• vB files to modify: 1 (newreply.php)
• Templates to modify: 2 (SHOWTHREAD, postbit)
• Phrases to create: 1 (multiquote)
• Files to upload: 3 (2 images, 1 Javascript file)

(Included missing Javascript file from post #75. Sorry for the delays, I don't come around often!)

[mtellin]

I got a parse error when I tried that one, no matter what type of reply I tried

[Chroder]

You sure you pasted it correctly? I've got the exact code and nothing is comeing up for me. Whats the error your getting?

[BillaBongUSA]

That new code seems to work okay for me.

[mtellin]

Originally Posted by Chroder

You sure you pasted it correctly? I've got the exact code and nothing is comeing up for me. Whats the error your getting?

Yup it was something completly unrelated that I messed up, wasnt your code and its working now

However for me if I click more than one to quote, and then click post reply, it only has one quoted (but I didnt get any errors when clicking one to quote then clicking go advanced)

[BillaBongUSA]

Yeah, same here, but I think that that only happens when you try to quote the last reply in the thread. Any other reply that I try to quote works, but when I try to quote the last reply, it doesn't show up.

[Edit: I don't know if that was very clear... To clarify, if I select three posts to quote, they will all show up. But if one of those is the last post in the thread, only two will show up, and the last post in the thread is omitted.]

[Zelda-King]

Yeah, I get a database error when using Quick Reply (which is important to fix as most people use Quick Reply). Same one as posted already;

Database error in vBulletin 3.0.0 Release Candidate 2:

Invalid SQL: SELECT postid, username, pagetext FROM post WHERE postid IN(19134) AND postid <> ORDER BY postid ASC LIMIT 20
mysql error: You have an error in your SQL syntax near 'ORDER BY postid ASC LIMIT 20' at line 1

mysql error number: 1064

Also, considering this works across threads and such, shouldn't the button for selected posts stay on? If you go back to a post on another page that you selected, the button turns off though the quote still works.

[Chroder]

PHP Code:

//############################################################################
//# START MULTI QUOTE                                                        #
//############################################################################
if(isset($_COOKIE[COOKIE_PREFIX . 'mq']))
{
    $pids = $_COOKIE[COOKIE_PREFIX . 'mq'];
    $pids = urldecode($pids);

    if(!empty($pids) && preg_match("/^[0-9,]+$/", $pids))
    {
        if($_REQUEST['noquote'])
            $mq_postid = '';
        elseif(!empty($postinfo['postid']))
            $mq_postid = "AND postid <> {$postinfo['postid']}";
        else
            $mq_postid = '';

        $q = $DB_site->query("SELECT username, pagetext FROM ".TABLE_PREFIX."post WHERE postid IN($pids) $mq_postid ORDER BY postid ASC LIMIT 20");
        while($row = $DB_site->fetch_array($q))
        {
            $originalposter = fetch_quote_username($row['username']);
            $pagetext = htmlspecialchars_uni($row['pagetext']);
            $pagetext = trim(strip_quotes($pagetext));
            eval('$newpost[\'message\'] .= "' . fetch_template('newpost_quote', 1, 0) . '\n";');
        }
    }

    setcookie(COOKIE_PREFIX . 'mq', '', time() - 3600, $vboptions['cookiepath'], $vboptions['cookiedomain']);
}
//############################################################################
//# END MULTI QUOTE                                                          #
//############################################################################ 


That should fix the last post not being included. I got screwed up because in RC2 (mabe RC1?) the template changed and the reply button actually replies to the _last_ post as to the first post. So I was having trouble reproducing the bug

I'll update the main file with this code. The "go advanced" in the quick reply still doesn't show the quotes, though I'm working on it

[Chroder]

Zelda-King -- I assume you were using the code from the file? I posted a fix to that above, but the main file is now updated.

Originally Posted by Zelda-King

Also, considering this works across threads and such, shouldn't the button for selected posts stay on? If you go back to a post on another page that you selected, the button turns off though the quote still works.

It should be doing this already, that is the reason for the mq_init() function. Is anyone else not getting this functionality? Remember that the New Reply page, when loaded, will clear the cookie that has saved the posts you've selected. This is the intended action, because after they've been added to the message box they're not needed. Though the problem comes with the "go advanced" button in the QR that will not display the quotes but will still clear them.

[BillaBongUSA]

Yeah, the button doesn't stay on for me cross-thread either.

[Chroder]

Doh. Seems to only work in Moz. I'll look into that too.