The Dot Hack

This is the Dot Hack:



The point of the hack is that it will place a dot on each thread that you have posted in. I think it is a great hack, what do you think?

I would like to release it but you have to modify the search index function and update the threadindex field for every user. If John wants to include it in the new version I will send him the code and give him hints on how to make the threadindex and search by user functions more robust, as I have done.

Originally posted by rangersfan
Mike/Ed has said all "known" bugs have been fixed in 1.1.4 so perhaps they have changed the delimiter, if not then all known bugs haven't been fixed.

All REPRODUCABLE bugs have been fixed (except for one which I may have forgotten about) But the speed increase is DEFINATELY noticeable.

Well this one is reproduceable. Find a user with a name that is a substring of another users name where the substring is separated by a space in the larger name. Then search for posts by the user with the substring. You will then receive the posts from both users since the delimiter of the index is a space.

Yes, but this isn't one that's fixed for the simple reason of backward compatibility - I didn't feel like making a script to update the indexes

ARGH!!!

This must be fixed and why must you do it anyway? I, of course, had a script that changed my indexes and I will just have to create another one and fix it myself for my own forum if jelsoft refuses to fix it.

Originally posted by rangersfan
ARGH!!!

This must be fixed and why must you do it anyway?

Woah, lets get this straight - I don't HAVE to. I offered to.

I'll try to get it in.

You said "I didn't feel like making a script to update the indexes" which to me implied that you are working for Jelsoft in some capacity if you make decisions about including or not including code in vBulletin.

'tis a reproduceable bug that needs to be rectified.

i am with the new bugs moderator on this

just do a search for posts by "chris" or by "john" in the forums, it shouldn't give the results that it does.

AS a database developer it makes no sense to have any text field delimited by spaces. If you are going to use delimiters it needs to be a uncommon character. Usually a PIPE (|) is used the delimiter because that is the characters sole purpose in life within a database.

When the user requests an exact name search, why not do a simple lookup on the username to grab their ID, then it's extraordinarily easy to just go SELECT whatever FROM post WHERE userid = $userid

And with that, provided the user entered the username in correctly, will provide *exact* results.

That is another thing which annoys me on the "Search All posts by this user" icon. It should check the userID of the posts, not that silly text field. In that case you don't even have to look-up anything, the userid is provided in the postbit! I'm going to make it work like that tonight if anyone is interested. Otherwise I will keep the tiny hack to myself!

mrogish yes it does need to be changed as it is rather silly now. If you change a users name then they won't show up in searches *until* you rebuild the search indexes OR someone makes a post in each thread that they have participated in. That is a little too much like UBB for me!