Attachments as files

Well after alot of time leaving it in the beta hacks forums without any problems, I'm now moving it to the Full Releases, I'm satisfied that there isn't any bugs that need to be addressed. Thanks to Jawelin he pointed out most of the mistakes through alot of his testing.
I've attached it as an installer file here, as it needs to make changes to the database. Two new rows to settings and a new column in the attachment table.

Scott

Updated some more

Note the > is missing off the bottom of the file after the ?, add it before trying to install

[Scott MacVicar]

There is no code which is changed which would stop people from downloading attachments, did you make sure the usergroup had permission to view attachments?

[JJR512]

Prior to installing this hack, all usergroups were able to download/view attachments. There wasn't a problem before this hack, only after it.

As I mentioned, there is so far only one other person, besides me, that can view attachments. There is another person in the same usergroup as that guy that has said he cannot. I don't think it's a usergroup-based problem.

I can view all the attachments that other people are not able to.

[Sean]

Same thing here.

I have checked and rechecked the user groups. tried numerous things. I am going to revert to an old attachments database, and reload all changed databases and re-install. I'll let you know what happens.

[JJR512]

Update: As an unlogged-in visitor, I cannot view attachments.

[JJR512]

You can see my attachment test thread, and the replies from all the people that can't see it and the two people (now two instead of one, besides me) that can see it: http://forums.jjr512.com/showthread....threadid=29545

[Sean]

FYI: Doesn't work for me either.. Really weird if ya ask me.. hmmm

[Aaow AnD wHiTe]

Thanx PPN

We would like to know if it would be possible to make something like an... attachments backup hack.

With this hack, you could save all your attachments as binaries without removing them from the database. It would be really usefull for us ^^

Thanx again ^^

[Sean]

I'm re-installing now. Last time (and this time), I found this:


VISABLE was not included in the string you wanted us to find.

if (!$attachmentinfo=$DB_site->query_first("SELECT filename,filedata,dateline,visible
							FROM attachment
							WHERE attachmentid='$attachmentid'")){

Instead of:

if (!$attachmentinfo=$DB_site->query_first("SELECT filename,filedata,dateline FROM attachment WHERE attachmentid='$attachmentid'")){

Do I replace what I found? Because when I look for the above line, it is not found..

[Scott MacVicar]

Sean, this is for vB 2.2.2, the visible part was added as it was missing in 2.2.1

I'll do some testing then, I'll do some testin on my own boards where I implemented this hack.
I know for a fact that the attachments are there as I can view them via shell and ftp. So there must be an error in the top 30 lines or so.

Is everyone running 2.2.2?

[Scott MacVicar]

Ok, I've worked out the problem now

sorry about all the problems.

Look for

PHP Code:

if (!$attachmentinfo=$DB_site->query_first("SELECT filename,hash,dateline,visible FROM attachment WHERE attachmentid='$attachmentid'")){ 


Please ensure that visible is there in that list, this is super super important as if it isn't then only moderators and admins will be able to view it as they have permission to moderate attachments.