Color Picker for Admin CP Style Properties

OK, a few people mentioned they want this so here goes:
popup color-picker for the Administration Control Panel's Style Properties page
(where you select the colours for your BB style theme(s)).

The hack is extremely easy to install:

1) Download the attachment.

2) Upload colors.gif and picker.php to your forums' /admin/ directory.

3) Open admin/style.php and find:

PHP Code:

        if ($iscolor) {
            echo "20\" onchange=\"updatecolor(this.form.preview$idvalue,this.value,'$idvalue')\" id=\"$idvalue\">\n";
            echo "<input type=\"button\" disabled value=\"              \" id=\"preview$idvalue\" style=\"background-color:$itemarray[replaceword]\">"; 


Replace with:

PHP Code:

        if ($iscolor) {
            echo "20\" onchange=\"updatecolor(this.form.preview$idvalue,this.value,'$idvalue')\" id=\"$idvalue\">\n";
            echo "<input type=\"button\" onclick=\"window.open('picker.php?fieldname=$name&idvalue=$idvalue','color','width=202,height=124,left=539,top=450');\" value=\" Click to Pick \" id=\"preview$idvalue\" style=\"background-color:$itemarray[replaceword]; font-weight: bold\">"; 


Save the file and upload it to /admin/

That's it!

Demonstration

Now, go to your style editor page, and click on any
button next to one of the colour value fields:



When you click on a button next to the color value you
need to fill, a small pop-up window will jump:



For an alternative colour chart, scroll down to post #25

Clicking on any of the colours will immediately fill in its
respective value in the correct field, as well as change
the background colour of the respective button.



Enjoy

Cheers,

Bira

IMPORTANT COMMENT ABOUT BROWSERS:

This hack has been tested and functions on IE 5, 5.5, 6; Netscape 4.7, 6.2, and Opera 6.

HOWEVER, the background color of the buttons will change ONLY in IE. The value will be passed to the form field just fine (you can see the text changing), but the background colour for the button will NOT change (it remains that default beige-grey) in any browser except IE.

I repeat: THE HACK WILL WORK ON ALL BROWSERS. It's only the display that is impared.

[KuraFire]

[QUOTE]Originally posted by bira
yeah, it occured to me that some people here may not have .html parsed as php in their httpd.conf (which, I must admit, I'm surprised you don't)

[KuraFire]

btw, you might want to edit the instructions.txt file in the zip in the attachment, to edit the .html into .php (to make it working) - in case people cut and paste from the instructions file instead of from this thread. Will prevent them from coming here and complaining it doesn't work and that they did exactly what the instructions say - the instructions are kinda wrong now.

[bira]

server load doesn't change one bit. If you parse html via php and there's not a single php code in that file, it will just output it and that's that. There's nothing to execute, hence there's no memory needed.

But I get your point about shared servers. In any event, it was a complete oversight on my part and I apologise. What surprises me is that none of you got a javascript error! getting a <?php echo $something ?> smack in the middle of a javascript should have immediately triggered a javascript syntax error for you. You probably have the option to disable all errors in your browser selected. Shame on you, developers!

[bira]

[QUOTE]Originally posted by KuraFire
btw, you might want to edit the instructions.txt file in the zip in the attachment, to edit the .html into .php (to make it working) - in case people cut and paste from the instructions file instead of from this thread. Will prevent them from coming here and complaining it doesn't work and that they did exactly what the instructions say - the instructions are kinda wrong now.

[bira]

At a friend's request, I also made an alternative colours chart:



If you rather use this one than the original one included in the hack (first post), then please:

1) download the attached file, rename it to picker.php

2) in style.php, instead of:

window.open('picker.php?fieldname=$name&idvalue=$idvalue','color','width=202,height=124,left=539,top=450')

use:

window.open('picker.php?fieldname=$name&idvalue=$idvalue','color','width=202,height=147,left=539,top=450')

[Admin]

I think I'm gonna try something, instead of hard-coding all the colors in the file, maybe you can use a FOR loop to go through all the colors... or maybe half the colors.

[bira]

FireFly, what for?

[Crinos]

[QUOTE]Originally posted by bira
yeah, it occured to me that some people here may not have .html parsed as php in their httpd.conf (which, I must admit, I'm surprised you don't)

[KuraFire]

[QUOTE]Originally posted by bira
server load doesn't change one bit. If you parse html via php and there's not a single php code in that file, it will just output it and that's that. There's nothing to execute, hence there's no memory needed.

But I get your point about shared servers. In any event, it was a complete oversight on my part and I apologise. What surprises me is that none of you got a javascript error! getting a <?php echo $something ?> smack in the middle of a javascript should have immediately triggered a javascript syntax error for you. You probably have the option to disable all errors in your browser selected. Shame on you, developers!

[bira]

Originally posted by KuraFire


Uhm, why would that give a javascript error?? The PHP is parsed out of there before it reaches the browser, and javascript isn't processed until it reaches the browser.

Or am I talking nonsense??

Well, if you have <?php echo $something ?> in the middle of the javascript, and that page is not parsed through php, then the <?...?> code is outputted to the client as part of the php/script source. And, when java parses the script, it stubles on illegal elements that shouldn't be there.


[QUOTE]Originally posted by KuraFire

Also: if a server parses .html files, doesn't that mean it Checks the entire .html file to see if there is any PHP code inside it, anywhere? I do believe that that's what parsing is.. :/

And if so, it _would_ provide some extra server loads if you do it on a large scale (100+ visits per minute) - all those php, asp, etc. tutorials speak about how you shouldn't use .php extensions if you don't have any PHP in the file, to prevent needless server parsing, i.e. server loads.