Infraction Hook

[Chris.08i]

Originally Posted by Dragonsys

ok, that is what I gave you the first time

PHP Code:

$vbulletin->GPC['points'] != 0 


but you said it didn't work. So I changed it to this:

PHP Code:

$vbulletin->GPC['points'] == 0 


So what determines an infraction vs a warning, in the code?

I am not sure - from what Mark posted earlier, I assumed that

PHP Code:

$vbulletin->GPC['points'] 


was the code to determine the number of points being issued in the infraction.

So from my understanding:

An infraction that don't carry points

PHP Code:

$vbulletin->GPC['points'] == 0 


would equal an infraction should skip the bottom code (deduction code).


I have tried either variations, and neither have worked.

[Dragonsys]

Originally Posted by Chris.08i

I am not sure - from what Mark posted earlier, I assumed that

PHP Code:

$vbulletin->GPC['points'] 


was the code to determine the number of points being issued in the infraction.

So from my understanding:

An infraction that don't carry points

PHP Code:

$vbulletin->GPC['points'] == 0 


would equal an infraction should skip the bottom code (deduction code).


I have tried either variations, and neither have worked.

In that case != 0 should cause it to run the subtraction code, which you said it didn't. I will have to look at the hook some.

--------------- Added [DATE]1450845554[/DATE] at [TIME]1450845554[/TIME] ---------------

based on this post:

Originally Posted by MarkFL

If you use the code I posted in post #8, then the deduction will be based on the accumulated active points prior to the infraction being issued. So, for example, suppose a user has 3 active points, and you then issue a warning...$userinfo['ipoints'] will be equal to 3.

But, if you use the hook location and variable I suggested in post #10, then $vbulletin->GPC['points'] will be equal to 0.

I would assume that a Warning is

PHP Code:

 $vbulletin->GPC['points'] == 0 


so an Infraction would be

PHP Code:

 $vbulletin->GPC['points'] != 0 


You want the points to be deducted with an Infraction, but not a Warning, right?

[Chris.08i]

That is correct.

The hook I am using is 'infraction_update_complete'

[Dragonsys]

Originally Posted by Chris.08i

That is correct.

The hook I am using is 'infraction_update_complete'

ok, in that case the first piece of code I posted should work for what you want, but you say it is not actually subtracting the points. Did you get a SQL error?

try this:

PHP Code:

global $vbulletin, $db, $userinfo;

if ($vbulletin->GPC['points'] == 0) {
    $points = $userinfo['ipoints'];
    $rep = $userinfo['reputation'];

    if ($points > 0)
    {
        $newrep = ($rep - $points*500);
    }
    else
    {
        $newrep = ($rep - 150);
    }

    $vbulletin->db->query_write("
        UPDATE " . TABLE_PREFIX . "user
        SET reputation = " . $newrep . "
        WHERE userid = " . $userinfo['userid'] .""
    );
} 


[Chris.08i]

So I tried again with == 0 and != 0.

When I tried == 0 - points get deducted when I issue warnings and they don't get deducted when giving an infraction.

When I tried != 0, points are not deducted in either situation.

[Dragonsys]

Originally Posted by Chris.08i

So I tried again with == 0 and != 0.

When I tried == 0 - points get deducted when I issue warnings and they don't get deducted when giving an infraction.

When I tried != 0, points are not deducted in either situation.

ok, we are making progress at least, lol. Let's try it this way (assuming this will always be a positive or 0):

PHP Code:

global $vbulletin, $db, $userinfo;

if ($vbulletin->GPC['points'] > 0) {
    $points = $userinfo['ipoints'];
    $rep = $userinfo['reputation'];

    if ($points > 0)
    {
        $newrep = ($rep - $points*500);
    }
    else
    {
        $newrep = ($rep - 150);
    }

    $vbulletin->db->query_write("
        UPDATE " . TABLE_PREFIX . "user
        SET reputation = " . $newrep . "
        WHERE userid = " . $userinfo['userid'] .""
    );
} 


[Chris.08i]

Tried that before if I remember correctly. I tried again nevertheless.

Warning does nothing, and infraction does nothing.

[Dragonsys]

There are minor differences. Ok, let me think on this a bit. I will get a fresh look in the morning.

[Chris.08i]

Originally Posted by Dragonsys

There are minor differences. Ok, let me think on this a bit. I will get a fresh look in the morning.

Thanks.

Perhaps the code to check for the infraction points being handed out is wrong, or the hook is wrong? I am not sure how to check either of these though.

[Dragonsys]

Originally Posted by Chris.08i

Thanks.

Perhaps the code to check for the infraction points being handed out is wrong, or the hook is wrong? I am not sure how to check either of these though.

I will have to do some checking on my test site and see how GPC['points'] is returned.
I think the hook is right, just need to figure out what is being returned, so we can use it properly