4.2.2 Upgraders, Check your Advanced Search

[Paul M]

Originally Posted by nerbert

I didn't research this or test it .....

Clearly not, since it was fixed in 4.2.2.

[nerbert]

Originally Posted by Paul M

Clearly not, since it was fixed in 4.2.2.

I'm running 4.2.2 and it's been throwing warnings all the time in Who's Online. There's still another occasional warning associated with another line of code that I'm not sure how to fix.

/*======================================================================*\
|| #################################################################### ||
|| # vBulletin 4.2.2 Patch Level 1 - Licence Number XXXXXXXXXXX
|| # ---------------------------------------------------------------- # ||
|| # Copyright ?2000-2014 vBulletin Solutions Inc. All Rights Reserved. ||
|| # This file may not be redistributed in whole or significant part. # ||
|| # ---------------- VBULLETIN IS NOT FREE SOFTWARE ---------------- # ||
|| # http://www.vbulletin.com | http://www.vbulletin.com/license.html # ||
|| #################################################################### ||
\*======================================================================*/


/*======================================================================*\
|| ####################################################################
|| # Downloaded: 18:15, Sat Aug 2nd 2014
|| # CVS: $RCSfile$ - $Revision: 61394 $
|| ####################################################################
\*======================================================================*/

I edited it because it was throwing warnings.

[ozzy47]

Well, you should be running 4.2.2 pl4 as you are running a outdated version with known security issues.

[nerbert]

Originally Posted by ozzy47

Well, you should be running 4.2.2 pl4 as you are running a outdated version with known security issues.

My other admin will have time for an upgrade this weekend. Meanwhile I modified the modcp directory name.

[squidsk]

Originally Posted by Paul M

Clearly not, since it was fixed in 4.2.2.

Sorry that code is not fixed in 4.2.2PL1, 4.2.2PL2 or 4.2.2PL4, I haven't checked 4.2.2PL3 but I'd be surprised if it was fixed there.

The code on line 516 of includes/functions_online.php is:

else if ($userinfo['values']['do'] == 'editfolders' OR $userinfo['action']['do'] == 'updatefolders')

instead of:

else if ($userinfo['values']['do'] == 'editfolders' OR $userinfo['values']['do'] == 'updatefolders')

Now it isn't a game breaking bug, as the only consequence of that typo is that if a user is updating their folder there won't be a corresponding specific action entry and the user will get the generic 'private_messaging' entry, but it should still be fixed given the actual fix required.

[Paul M]

Hmmm, well my test forum is supposedly running 4.2.2, and its fixed

I also know its fixed in core, as I remember doing it. I guess I'll have to look at SVN later.

[Paul M]

Ah well, I found it ;
http://tracker.vbulletin.com/browse/VBIV-15962

Apparently I fixed it last summer, so its in 4.2.3, not 4.2.2

My apologies, I guess I must have tested it locally and never reverted the change.

[ForceHSS]

in 4.2.3 it is

else if ($userinfo['values']['do'] == 'editfolders' OR $userinfo['values']['do'] == 'updatefolders')

line 518

[ozzy47]

Originally Posted by ForceHSS

in 4.2.3 it is

else if ($userinfo['values']['do'] == 'editfolders' OR $userinfo['values']['do'] == 'updatefolders')

line 518

Which would be the correct fix.

[ForceHSS]

Originally Posted by ozzy47

Which would be the correct fix.

Reason why I posted was showing it was there