Using $_GET

[RedTyger]

That's what I just said.

Is there any reason to use the input cleaner instead of just performing the checks yourself as I suggested? The advantage that way is that you don't have to change the way you access the variable and you can also assign extra or different checks instead of being limited to the few GPCs and can assign if/else to deal with the data as well. That's a terrific tutorial but the one thing it doesn't do is explain why you should use it instead of your own way.

[KingPuyol]

Thanks

If I did this:
$playername = SELECT name FROM players WHERE id='" . $_REQUEST['id'] . ''

Will it work?

Originally Posted by RedTyger

That's what I just said.

Is there any reason to use the input cleaner instead of just performing the checks yourself as I suggested? The advantage that way is that you don't have to change the way you access the variable and you can also assign extra or different checks instead of being limited to the few GPCs and can assign if/else to deal with the data as well. That's a terrific tutorial but the one thing it doesn't do is explain why you should use it instead of your own way.

It complies with vBulletin's coding standards, I don't know why you wouldn't want to use a tool like that provided for you. If you are going to run the sanitizing functions manually, it is fine, but it is always open to you forgetting to clean a variable. If you use $vbulletin->GPC, you have more confidence that your variables are being cleansed properly.

[Analogpoint]

The only case where I would consider not using vB's sanitizing functions would be if you're only dealing with one single int variable in a plugin, then it would probably be more readable/simpler to just use intval to force it to be an int. If I remember right, that's what vB does anyway to sanitize an int variable.

$i = intval ($_GET['i']);

In all other cases (and maybe even in this one), follow Danny's advice.

[KingPuyol]

What should I put in the red text if I'm going to using REDTYGER's advice?

if($_GET['id'] == "here)
{
do something else;
}