Attachments as files

Well after alot of time leaving it in the beta hacks forums without any problems, I'm now moving it to the Full Releases, I'm satisfied that there isn't any bugs that need to be addressed. Thanks to Jawelin he pointed out most of the mistakes through alot of his testing.
I've attached it as an installer file here, as it needs to make changes to the database. Two new rows to settings and a new column in the attachment table.

Scott

Updated some more

Note the > is missing off the bottom of the file after the ?, add it before trying to install

[fury]

Question: how easy would it be to modify the attachments database and this hack to allow up to 3 attachments per post, and be easy to convert from a userid_dateline.extension filename format?

I want to know because I'm planning on converting a phpBB board to vBulletin, but the attachment hack I installed on the phpBB allows up to 3 attachments per post, and vBulletin by default doesn't.

[Prince]

Does this hack work with vB 2.2.9?

and can someone please briefly explain what the install does?

does it take all existing file attachments out of your vB database and make them files?

[Craigr]

Originally posted by Prince
Does this hack work with vB 2.2.9?

and can someone please briefly explain what the install does?

does it take all existing file attachments out of your vB database and make them files?

Well i was for installing it on 2.2.9, but i couldn't find the code in attachments.php you're supposed to replace!

Craig

[wolffenstein]

installed on my testing board, running 2.2.9. ran fine.

the install file, when viewed with your browser, helps install the hack by making modifications to the database for you, and pointing out which files to modify in an "easy way." place it in your admin folder, as it requires admin access to install.

it can import (read: copy, but not delete) files from the database.

the attachments.php with proper code is in your forums' root directory. the attachments.php in the admin folder does not have the necessary coding. yes, those instructions weren't perfectly clear at first, but read all instructions before proceding, common sense should dictate. you'll notice you have to make modifications to files in the mod and admin folders, and thus, they're located in the mod/ and admin/ folders.

however, the instructions have a slight typo, though i think the reason lies within changes to vb since 2.2.3. the second instructions for the admin/functions.php file (don't mistake this for admin/adminfunctions.php like i did) have this code:

$DB_site->query("DELETE FROM attachment WHERE attachmentid IN ($attachmentids"."0) AND NOT attachmentid IN ($omitattachmentids"."0)");

wheras function.php has:

$DB_site->query("DELETE FROM attachment WHERE attachmentid IN ($attachmentids"."0) AND attachmentid NOT IN ($omitattachmentids"."0)");

simply, "attachmentid" and "NOT" are reversed. i wouldn't imagine this to be any problem whatsoever. i've attached the installer file with the proper change for versions 2.2.7 and above (2.2.7 change log: "Admin/functions.php; fixed a bug causing attachments used as references to be deleted when they shouldn't be").

[Danny]

it does work fine, but I have now upgraded to vb2.2.9 and unfortunately when i try and change a user from one group to another group using the control panel i get an error in the user.php file, this error does not appear when no hacks are installed.

Database error in vBulletin Control Panel 2.2.9:

Invalid SQL: UPDATE user SET birthday='0000-00-00',options='14',usergroupid='15',username='margar et
vasey',email='email@email.com',styleid='1',parente mail='n/a',coppauser=1,homepage='http://',icq='',aim='',yahoo='',signature='',adminemail=1 ,showemail=0,invisible=1,usertitle='Member',custom title=0,joindate=UNIX_TIMESTAMP('2002-09-06
15:07:30'),cookieuser=1,nosessionhash=,daysprune='-1',lastvisit=UNIX_TIMESTAMP('2002-09-06
15:07:30'),lastactivity=UNIX_TIMESTAMP('2002-09-06 15:18:27'),lastpost=UNIX_TIMESTAMP('1970-01-01
01:00:00'),posts='0',timezoneoffset='0',emailnotif ication=1,receivepm='0',emailonpm='1',ipaddress='-1',pmpopup=IF(pmpopup=2 AND
1=1,pmpopup,'1') WHERE userid=270
mysql error: You have an error in your SQL syntax near 'daysprune='-1',lastvisit=UNIX_TIMESTAMP('2002-09-06
15:07:30'),lastactivity=UNIX' at line 1

mysql error number: 1064

Date: Friday 03rd of January 2003 08:52:07 PM
Script: http://www.golden-springs.com/forums...admin/user.php
Referer: http://golden-springs.com/forums/adm...dit&userid=270

[mv540]

Hi guys, I need some quick help. I have installed this hack on a 2.2.9 board and everythijng seemed to work fine. It seems now that only mods and admins can view forums or search.
Here's the error.

Fatal error: Call to undefined function: getmodpermissions() in /home/hsphere/local/home/ital911/dss-power.com/forums/admin/functions.php on line 1758

Thanks

regular members get this error when they actually click on a forum or clich the vew newest possts, which I have set to get daily..

[Danny]

Originally posted by mv540
Hi guys, I need some quick help. I have installed this hack on a 2.2.9 board and everythijng seemed to work fine. It seems now that only mods and admins can view forums or search.
Here's the error.

Fatal error: Call to undefined function: getmodpermissions() in /home/hsphere/local/home/ital911/dss-power.com/forums/admin/functions.php on line 1758

Thanks

regular members get this error when they actually click on a forum or clich the vew newest possts, which I have set to get daily..

you have hacked the functions.php file incorrectly delete it and start over again, I have hacked my 2.2.9 board with this hack and everything is fine.

my above post was a bug in 2.2.9 which is fixed now.

[Areku]

Hi!

I recently uninstalled this hack off from my board, but I must have forgotten to change something in editpost.php since now, everytime i try to delete ANY post (doesnt matter if it contains an attachment or not) or try to delete any attached file, I get the following error:

Database error in vBulletin 2.2.0:

Invalid SQL: SELECT attachmentid, hash FROM attachment WHERE attachmentid='491'
mysql error: Unknown column 'hash' in 'field list'

mysql error number: 1054

Date: Friday 10th of January 2003 06:07:47 AM
Script: http://.../forums/editpost.php
Referer: http://.../forums/editpost.php?s=&ac...t&postid=32926

The error does NOT appear if I just edit the text of the post and submit changes.


Can any1 help out??

[Areku]

Further exploring functions.php I found the responsible (I think it's the responsible for the error):

PHP Code:

// ###################### Start removeattachment #######################
function removeattachment ($attachmentid) {
  global $DB_site,$attachpath;
  $fileinfo = $DB_site->query_first("SELECT attachmentid, hash FROM attachment WHERE attachmentid='$attachmentid'");
  $path = "$attachpath/$fileinfo[hash].file";
  unlink($path);
} 


However, what should I do with this routine that's causing problems ONLY with editpost.php? If I delete it I'm sure a new problem will arise, right?


I might think of a database not so well written or some sort of column is superfluous, but I'm stucked, what shall I do now?

THanks!!!

[Mustang5ohhh]

I'm getting the same error as above when I go to delete a thread with an attachment. Any updates ?

Next ... I'm sort of new to the vB thing ... I've installed the hack and with a few minor problems that I worked out ... it "seems" to be working. The whole problem is that I'm not sure if it is working right. Using Telnet I connect to MySQL and I still see the attachment tables:

1. Am I supposed to?
2. The filedata column has nothing in it ... does that mean that it worked and the file is out in the directory?
3. Is there a querie I can run to see if that it is indeed working?

Sorry about so many questions ... I went to the MySQL site but ... I'm not that advanced yet ... I need laymans terms to get me through this.

Thanks in advance.

M