[VB3 RC3] Attachments in private messages

Unsupported. VB3.5 version is here:
https://vborg.vbsupport.ru/showthread.php?t=91220

Tested on 3.0.3

This hack enables you to send attachments in a private message. This feature was really useful to me in vb2 and I kind of missed it on vb3 so I rehacked it myself.

When a user writes a private message they will be given the option to add an attachment, the same as when writing a post. It uses the same rules you have defined for a convencional attachment including file types, quotas, etc. It is only an extension for attachments to be used in private messages.

As always it is advised to backup your files before hacking in case you want to go back, this is some big hack including modification of multiple files, some templates and adding two extra columns in the database tables.

Instructions are provided in the txt, and some screenshots on where the attachment option appears.

Info for hackers:
You may modify, improve, upgrade, redistribute this hack, include it
in another hack or yours or translate it provided you do it free of
charge and you distribute it in www.vbulletin.org at least, there is no
need to pm me asking for permission
Some portions of the code are (c) Jelsoft Enterprises Ltd.

Edit by MarcoH64:
Because of multiple requests to make this hack work on vB3.0.7 i created upgrade instructions. These upgrade instructions can be followed after the original instructions (the 3.0.3 version). The original coder can not be held responsible for my modification.

[RobinHood]

Originally Posted by btappan

anybody fix this yet? can i make it delete them after they are a week old or something?

I already tried that. The attachment would still be deleted even though the PM still exists. The attachment would be deleted within a few hours.

[btappan]

believe me, the attachments are being deleted even when the pm is still there. I have informed my users to not delete any messages to test what is happening. no one has deleted their messages, and the attachments are still dissappearing.

[btappan]

I have determined from my testing that the attachments are being deleted shortly after they have been viewed, not when the user deletes the PM. Also, if I send another user a PM attachment and then look at what i sent them in my sent items folder before the recipient has even looked at it, it is usually deleted before they view it unless they look at it quick enough b4 it gets cleaned out by thr cron file. so wether the sender or the recipient views the attachment once it has been sent, it will be deleted shortly thereafter. back to my original question: can i temporarily fix this by reverting my cleanup file? i don't really care if the attachments aren't being deleted in the mean time until someone comes up with a fix for this. let me know

[Kentaurus]

I'm really really sorry about not upgrading this hack, I have it upgraded in my forum and there are a couple modifications that have to be made to make it compatible with 3.0.3. theArchitect sent me a pm today and I headed here to upgrade my hack as fast as I could

I originally designed this hack for RC3 and upgraded it until gold, but I haven't had time lately to upgrade my hacks (or to document them). Anyway, I'll attach in the first post the upgraded txt for the 3.0.3 vbulletin.

About the cron job. Hourly all the orphan attachments (that is the attachments that were uploaded but the post was never commited) are deleted. When my hack is not installed then an attachment in the pm counts as a not commited attachment (that are the replacements in the cleanup2.php file). That is new behaviour in 3.0.3, in earlier versions they checked the posthash instead of the postid.

That would mean that if you upgraded to 3.0.3 and didn't upgrade the hack you might've lost your private attachments. You'd need to edit the files (or at least the cleanup2.php, then upgrade to 3.0.3 for your attachments to be safe.

[theArchitect]

Originally Posted by Kentaurus

I'm really really sorry about not upgrading this hack, I have it upgraded in my forum and there are a couple modifications that have to be made to make it compatible with 3.0.3. theArchitect sent me a pm today and I headed here to upgrade my hack as fast as I could

Many thanks, you assistance is most appreciated.

However I am having a problem with the install. I have rechecked my work but am getting the following error message when I try and upload an attachment:

Invalid Post specified. If you followed a valid link, please notify the webmaster

I also recieved a DB error report:

Database error in vBulletin 3.0.3:
 
 Invalid SQL: 
 
 		DELETE FROM attachment
 
 		WHERE postid = 0 AND private = 0 AND
 
 		dateline < 1097016998
 mysql error: Unknown column 'private' in 'where clause'
 
 mysql error number: 1054

Do you have any thoughts as to what stage of the hack install I have done incorrectly?

[RobinHood]

Originally Posted by theArchitect

Many thanks, you assistance is most appreciated.

However I am having a problem with the install. I have rechecked my work but am getting the following error message when I try and upload an attachment:

Invalid Post specified. If you followed a valid link, please notify the webmaster

I also recieved a DB error report:

Database error in vBulletin 3.0.3:
 
 Invalid SQL: 
 
 		DELETE FROM attachment
 
 		WHERE postid = 0 AND private = 0 AND
 
 		dateline < 1097016998
 mysql error: Unknown column 'private' in 'where clause'
 
 mysql error number: 1054

Do you have any thoughts as to what stage of the hack install I have done incorrectly?

Make sure you have "private" column in the attachment table.

[theArchitect]

Originally Posted by RobinHood

Make sure you have "private" column in the attachment table.

Bizarre. I re-checked this on one of my test forums and ended up with the error that the row had already been added (when I tried it I got rows affected 0).

So I ran the entire install process on a different board and everything seems to be working fine. I guess I will just have to put it down to another vB X File.

But thankyou for your help.

[btappan]

Originally Posted by Kentaurus

About the cron job. Hourly all the orphan attachments (that is the attachments that were uploaded but the post was never commited) are deleted. When my hack is not installed then an attachment in the pm counts as a not commited attachment (that are the replacements in the cleanup2.php file). That is new behaviour in 3.0.3, in earlier versions they checked the posthash instead of the postid.

So if I reinstall the entire hack with your new release it will cure my current problem of pm attachments being deleted hourly once they have been viewed? also, how different is your release compared to the other? Am I going to have a problem running the commands since I already have the last version installed?

[Kentaurus]

Yes, it should cure that problem. However for that you need only to modify the cleanup2.php file in your includes/cron directory (with the instructions in the hack)

Only attachment.php and cleanup2.php have heavy modifications, you might want to check only those if it is already installed and working.

[Debbi]

I would LOVE to have this mod for 3.0.3. Any chance of this in the near future?