[VB3 RC3] Attachments in private messages

Unsupported. VB3.5 version is here:
https://vborg.vbsupport.ru/showthread.php?t=91220

Tested on 3.0.3

This hack enables you to send attachments in a private message. This feature was really useful to me in vb2 and I kind of missed it on vb3 so I rehacked it myself.

When a user writes a private message they will be given the option to add an attachment, the same as when writing a post. It uses the same rules you have defined for a convencional attachment including file types, quotas, etc. It is only an extension for attachments to be used in private messages.

As always it is advised to backup your files before hacking in case you want to go back, this is some big hack including modification of multiple files, some templates and adding two extra columns in the database tables.

Instructions are provided in the txt, and some screenshots on where the attachment option appears.

Info for hackers:
You may modify, improve, upgrade, redistribute this hack, include it
in another hack or yours or translate it provided you do it free of
charge and you distribute it in www.vbulletin.org at least, there is no
need to pm me asking for permission
Some portions of the code are (c) Jelsoft Enterprises Ltd.

Edit by MarcoH64:
Because of multiple requests to make this hack work on vB3.0.7 i created upgrade instructions. These upgrade instructions can be followed after the original instructions (the 3.0.3 version). The original coder can not be held responsible for my modification.

[Keyser S?ze]

ok this works fine for me in 3.0.1 BUT, when i load a PM with a attachment, takes forever, like a full 2 minutes to load the PM

thats the only problem, other PMs load very fast, almost instantly

[moley]

when i used it on 3.0.1 i got an error

An error occurred while attempting to execute your query. The following information was returned.
error number: 1064
error desc: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near ';
ALTER TABLE pmtext add attach int not null;
ALTER TABLE att

anyone know how to fix it?

[Datenpapst]

aren't privat messages privat and only for the users themselfs?

[moley]

a private message is from one person to another this hack can be used in this sorta of case user 1 made a new wallpaper and he wants to show his friend user 2. Instead of making a thread user 1 goes and makes a pm with the image attahment so that way the only two people who will see it are user 1 and user 2.

Also on your sites portal you seem to have latest thread replies twince once on the left hand colum and once under the latest news. justing pointing out.

[weaver]

I can't find either of these pieces of code in private.php. I'm running 3.0.3.

$postid = verify_id('post', $attachmentinfo['postid']);

verify_forum_password($foruminfo['forumid'], $foruminfo['password']);

[Weasel]

snobbymom, in that last piece of code just replace foruminfo with attachmentinfo everywhere you see it in the edit.

As for the " $postid = ..." I'm wondering the same thing myself. Its possible that that edit could be skipped.

Otherwise all of the edits are fairly straightforward even if they dont match the new 3.0.3 code exactly. Can anyone get this working in 3.0.3?

[RobinHood]

Oh, guess what? I got this working for VB 3.0.3!

Took me an hour, but I got it!

A working demo of it is at http://www.generazn.com.

I will post a fix for this hack very soon.

[RobinHood]

Okay, here is the fix!

First,

Open attachment.php:

Find:

PHP Code:

if (!$attachmentinfo = $DB_site->query_first("
    SELECT filename, attachment.postid, attachment.userid, attachmentid,
        " . iif($thumb, 'thumbnail AS filedata, thumbnail_dateline AS dateline, thumbnail_filesize AS filesize,', 'attachment.dateline, filedata, filesize,') . "
        attachment.visible, mimetype, NOT ISNULL(deletionlog.primaryid) AS isdeleted,
        thread.forumid, forum.password, thread.threadid
    FROM " . TABLE_PREFIX . "attachment AS attachment
    LEFT JOIN " . TABLE_PREFIX . "attachmenttype AS attachmenttype ON(attachmenttype.extension = SUBSTRING_INDEX(attachment.filename, '.', -1))
    LEFT JOIN " . TABLE_PREFIX . "deletionlog AS deletionlog ON(attachment.postid = deletionlog.primaryid AND type = 'post')
    LEFT JOIN " . TABLE_PREFIX . "post AS post ON (post.postid = attachment.postid)
    LEFT JOIN " . TABLE_PREFIX . "thread AS thread ON (post.threadid = thread.threadid)
    LEFT JOIN " . TABLE_PREFIX . "forum AS forum ON (forum.forumid = thread.forumid)
    " . iif($postid, "WHERE attachment.postid = $postid", "WHERE attachmentid = $attachmentid") . "
")) 


Replace with:

PHP Code:

if (!$attachmentinfo = $DB_site->query_first("
    SELECT filename, attachment.postid, attachment.userid, attachmentid,
        " . iif($thumb, 'thumbnail AS filedata, thumbnail_dateline AS dateline, thumbnail_filesize AS filesize,', 'attachment.dateline, filedata, filesize,') . "
        attachment.visible, mimetype, NOT ISNULL(deletionlog.primaryid) AS isdeleted, private, 
        thread.forumid, forum.password, thread.threadid
    FROM " . TABLE_PREFIX . "attachment AS attachment
    LEFT JOIN " . TABLE_PREFIX . "attachmenttype AS attachmenttype ON(attachmenttype.extension = SUBSTRING_INDEX(attachment.filename, '.', -1))
    LEFT JOIN " . TABLE_PREFIX . "deletionlog AS deletionlog ON(attachment.postid = deletionlog.primaryid AND type = 'post')
    LEFT JOIN " . TABLE_PREFIX . "post AS post ON (post.postid = attachment.postid)
    LEFT JOIN " . TABLE_PREFIX . "thread AS thread ON (post.threadid = thread.threadid)
    LEFT JOIN " . TABLE_PREFIX . "forum AS forum ON (forum.forumid = thread.forumid)
    " . iif($postid, "WHERE attachment.postid = $postid", "WHERE attachmentid = $attachmentid") . "
")) 


Next, find:

PHP Code:

if ($attachment['postid'] == 0 AND $bbuserinfo['userid'] == $attachmentinfo['userid']) 


On top of that, add the following:

PHP Code:

if (!$attachmentinfo['private']) {
    $postid = verify_id('post', $attachmentinfo['postid']);
} 


Next, find:

PHP Code:

if (!($forumperms & CANVIEW) OR !($forumperms & CANGETATTACHMENT))
    {
        print_no_permission();
    }

    // check if there is a forum password and if so, ensure the user has it set
    verify_forum_password($attachmentinfo['forumid'], $attachmentinfo['password']); 


Replace it with the following:

PHP Code:

if (!($forumperms & CANGETATTACHMENT))
{
    $vboptions['viewattachedimages'] = 0;
    $vboptions['attachthumbs'] = 0;
}

// check if there is a forum password and if so, ensure the user has it set
    verify_forum_password($attachmentinfo['forumid'], $attachmentinfo['password']);

$pmUsers = $DB_site->query_first("SELECT toUserArray FROM ".TABLE_PREFIX."pmtext WHERE pmtextid='".$attachmentinfo['private']."'");
    $toUserArray = unserialize($pmUsers['toUserArray']);         
    if ($toUserArray[$bbuserinfo['userid']] != $bbuserinfo['username'] && $attachmentinfo['userid'] != $bbuserinfo['userid']) {
            print_no_permission();        
           } 


THAT'S IT! YOU'RE DONE!

It should be working now. If not, let me know because it is working for me.

[btappan]

Props to RobinHood! up and working on my forums, no problems thus far! man does this hack take a while to install though!

[Weasel]

I'm having problems with your code RobinHood, it seems to break the permissions of normal attachments, i.e. no one can view them now.