Attachments as files

Well after alot of time leaving it in the beta hacks forums without any problems, I'm now moving it to the Full Releases, I'm satisfied that there isn't any bugs that need to be addressed. Thanks to Jawelin he pointed out most of the mistakes through alot of his testing.
I've attached it as an installer file here, as it needs to make changes to the database. Two new rows to settings and a new column in the attachment table.

Scott

Updated some more

Note the > is missing off the bottom of the file after the ?, add it before trying to install

[JJR512]

PPN, I have a question for you.

It's concerning vBulletin 3, and the features described in this thread: http://www.vbulletin.com/forum/showt...threadid=51821

John mentions that attachment images (.gif,.jpg.,etc) are no longer stored in the database. I'm assuming this means text files, .zips, and whatever other formats are allowed are still stored in the database. My personal opinion of this is that all formats should be stored outside the db. I can see that some formats, especially text files, might typically be so small that it doesn't make a big difference, but it seems like it would be unnecessarily complicated from a programming point of view to have two different attachment handling routines.

I don't know if you know the answer to this, but I'm curious to know if there will be an administrative way of controlling which attachment types get stored where. Some board admins may allow other file types that could be as large as, or larger, than image files, making them also be good candidates for storing outside the database.

But, PPN, what I'd really like to know from you, is when vBulletin 3 comes out, what's going to happen to those of us who have installed your hack? I know I've long ago gotten rid of the field in the attachments table that stored all the file data, and even if I still had a copy somewhere, there's plenty of new attachments since then that were never put into that field. Will you be able to adjust this hack pretty quickly to work with vB 3, so that those of us using your hack won't have to wait that long before we can start using vB 3 without losing attachments? Or can you make something to basically reverse your hack, something that will re-import all attachment files back as filedata into the database?

[ExAvIoUr]

nevermind i made it work. i forgot to replace something.

gj

[Darren Evans]

I manually deleted some files out of the attachments folder (per somone's suggestion) and now I have errors on thread pages. The links to the attachments still show up.

I take it I shouldn't have listened to the person who told me to delete the files. aranoid:

Can someone help me fix this?

[Tim Wheatley]

Ok, I'm running 2.2.7, so I hope it works for this.

I'm going through the install and it says:

admin/functions.php

Step 1 of 3 FIND: 


function acceptupload($moderate=0) {

REPLACE from that point to the end of the function with

Well, because I'm stupid I don't know where the function ends. Is it just the one line I replace or all the way to above:

// ###################### Start getmodpermissions #######################

[Boofo]

Yes.

[Tim Wheatley]

Good, I commented the whole (what I thought was it anyway) function out just incase it didn't work.

Thanks.

[Chris M]

Great hack PPN...

I dont know why I never installed this before...

You have saved me from downloading 1.12 Mb whilst Backing up my vB Board!!!

My attachment table is now only 4.7Kb!

Satan

[Darren Evans]

<bump>

Can anyone help me with my question? ^^^^

[Chris M]

Sorry Darren...I dont know

I would like to know if you can delete the files, if there are no more attachments...

?

Hopefully I could avoid an error like Darren's...

Satan

[Bison]

I installed this hack and now I can't get images to show up in the threads after uploading them from the attachment window!