Horoscope: Why won't it work?

[Brent H]

Oops, my mistake.

It now shows the sign selection page but clicking on one doesn't do anything, although the URL does change to reflect whatever I clicked, i.e zodiac.php?do=capricorn

[merk]

A few suggestions:

Use a switch statement instead of all those ifs, it looks like:

PHP Code:

switch($_REQUEST['do'])
{
case 'aries':
    {
     // aries code
    }
break;
case 'anotherthing':
    {
     // anotherthing code
    }
break;
default:
    {
     // do something if the variable isnt any of the above "cases"
    }
break;
} 


Other than that, there is no reason it shouldnt work. You should still be able to access all variables in the superglobals ($_REQUEST, $_GET, $_POST) even after vbulletin has done its thing.

You could do alot of tiding of the code inside the if/switch statements too, but that shouldnt be causing the problem.