The Arcive of Official vBulletin Modifications Site.

Dean C · #11 05-17-2005, 03:18 PM

As another safety precaution you should probably strip on.* attributes

Edit: Ah I see you already have

Zero Tolerance · #12 05-17-2005, 10:14 PM

Quote:

Originally Posted by filburt1

It looks effective at first glance, but it makes assumptions on HTML that could change at any time.

The HTML will be submitted by users, think of it as posts, but unsubmit it will check then if any elements of JS injections are found, and if so - it will stop and warn them about it, telling them to remove it.

So they have to bypass this security before they can proceed to save the data.

- Zero Tolerance

filburt1 · #13 05-17-2005, 11:23 PM

My point is the HTML spec changes constantly, and additional methods for inserting scripting may become available.

Zero Tolerance · #14 05-18-2005, 12:30 AM

Quote:

Originally Posted by filburt1

My point is the HTML spec changes constantly, and additional methods for inserting scripting may become available.

Ah, true, i know i won't be able to rule out every possible way, but if i can rule out a lot of ways that are mostly known, then it will be more secure.

- Zero Tolerance

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.04276 seconds Memory Usage 2,186KB Queries Executed 11 (?)
More Information
Template Usage: (1)SHOWTHREAD (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)ad_showthread_beforeqr (1)ad_showthread_firstpost (1)ad_showthread_firstpost_sig (1)ad_showthread_firstpost_start (2)bbcode_quote (1)footer (1)forumjump (1)forumrules (1)gobutton (1)header (1)headinclude (1)navbar (3)navbar_link (120)option (1)pagenav (1)pagenav_curpage (1)pagenav_pagelink (4)post_thanks_box (4)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (4)post_thanks_postbit_info (4)postbit (4)postbit_onlinestatus (4)postbit_wrapper (1)spacer_close (1)spacer_open (1)tagbit_wrapper Phrase Groups Available: global inlinemod postbit posting reputationlevel showthread	Included Files: ./showthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showthread_start showthread_getinfo forumjump showthread_post_start showthread_query_postids showthread_query bbcode_fetch_tags bbcode_create showthread_postbit_create postbit_factory postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start pagenav_page pagenav_complete tag_fetchbit_complete forumrules navbits navbits_complete showthread_complete
Messages:

The Arcive of Official vBulletin Modifications Site.

It is not a VB3 engine, just a parsed copy!