conditional won't work together but work's split up?

[sabret00the]

What the code should do is:
If they are NOT original_poster OR are NOT a_moderator: Error message
(that's simplified cos i left out the check to make sure they have permission to edit their own posts)

[Marco van Herwaarden]

Let's do this again

PHP Code:

if (!$allow_edit and !$allow_edit2) 


is wrong, should be:

PHP Code:

if (!($allow_edit and $allow_edit2)) 


What you want is that both conditions are true, must be the poster and must have permissions to edit. If this combination is not true (as opposed to the 2 seperate conditions being not true) then you want an error.

[sabret00the]

that didn't work so let's simplify the original code

PHP Code:

if (($postinfo['userid'] != $bbuserinfo[userid] AND !$grps_permissions['groupspostedit']) OR (!grps_permissions['groupsmoderater']) 


simplified that would be

PHP Code:

if ($clause_one OR $clause_two) 


so basically i want if either of clause_one or clause_two = true then let the person edit the post, else show a no permission screen.

[Marco van Herwaarden]

Now let's add the moderator part. Let's simplify by making the above into 1 condition, so:

PHP Code:

if ( !(canedit) ) {error} 


Now let's add the moderator with an OR statement:

PHP Code:

if ( !(canedit) OR !(moderator) ) {error} 


Possible combinations:
1. Can NOT edit, is NOT moderator, this will give:

PHP Code:

if ( TRUE OR TRUE) {error} 


Error is shown, this is correct.

2. Can edit, is NOT moderator, this will give:

PHP Code:

if ( FALSE OR TRUE) {error} 


Since you are using an OR statement only 1 of the conditions need to be TRUE. This is the case, so an error. This is not what you want.

3. Can NOT edit, is moderator, this will give:

PHP Code:

if ( TRUE OR FALSE) {error} 


Since you are using an OR statement only 1 of the conditions need to be TRUE. This is the case, so an error. This is not what you want.

Now let's see the same with an AND:

PHP Code:

if ( !(canedit) AND !(moderator) ) {error} 


1. Can NOT edit, is NOT moderator, this will give:

PHP Code:

if ( TRUE AND TRUE) {error} 


Error is shown, this is correct.

2. Can edit, is NOT moderator, this will give:

PHP Code:

if ( FALSE AND TRUE) {error} 


Since you are using an AND statement, both of the conditions need to be TRUE. This is NOT the case, so NO error. This is what you want.

3. Can NOT edit, is moderator, this will give:

PHP Code:

if ( TRUE AND FALSE) {error} 


Since you are using an AND statement, both of the conditions need to be TRUE. This is NOT the case, so NO error. This is what you want.

Originally Posted by sabret00the

so basically i want if either of clause_one or clause_two = true then let the person edit the post, else show a no permission screen.

This is not what you are doing: You are showing an error if either of them is true

[sabret00the]

ok so how do i get it to show

PHP Code:

if ((canedit) AND !(moderator)) {no_error} 


then have

PHP Code:

if (!(canedit) AND (moderator)) {no_error} 


but if

PHP Code:

if (!(canedit) OR !(moderator)) {error} 


[Marco van Herwaarden]

Lol now you are confusing me.

What you will want is:

PHP Code:

if (!(canedit) AND !(moderator)) {error} 


Or you can turn the whole game upside down:

PHP Code:

if ((canedit) OR (moderator)) {DO EDIT} 


[Jolten]

Talk about over-thinking things

PHP Code:

if ((($postinfo['userid'] != $bbuserinfo[userid]) AND !$grps_permissions['groupspostedit']) AND !$grps_permissions['groupsmoderater']) 
{ 
    print_no_permission(); 
} 


(((user does not equal poster) AND not in allowed to edit group) AND is not moderator)

[Marco van Herwaarden]

Originally Posted by Jolten

Talk about over-thinking things

PHP Code:

if ((($postinfo['userid'] != $bbuserinfo[userid]) AND !$grps_permissions['groupspostedit']) AND !$grps_permissions['groupsmoderater']) 
{ 
    print_no_permission(); 
} 


(((user does not equal poster) AND not in allowed to edit group) AND is not moderator)

I gree, but he just didn't want to get it

[sabret00the]

win for the overthinking your code never worked

but

PHP Code:

if (!$grps_permissions['groupsmoderater'])
{
    //they'll only get in here if they're not a mod
    if ($postinfo['userid'] != $bbuserinfo[userid] AND !$grps_permissions['groupspostedit'])
    {
        print_no_permission();
    }
} 


is the working code

[Marco van Herwaarden]

So you give up? I am sure one of my codes worked