Adding Template Conditionals to vB.

[Revan]

The first error I detect is that you have a parse error on this line:

PHP Code:

        if ((strpos($useragent, 'linux') !== false) AND (strpos($useragent, 'x11') !== false) AND (strpos($useragent, 'i686') !== false)) 


You had 1 parenthesis too many at the end there
I'll keep testing this function, then race ya to get it working first

And here is the complete working function. For obvious reasons, I have not been able to test linux, mac or webtv, you might want to get someone using those os'es (is webtv an OS though? )

PHP Code:

// #################### Start is os ##########################
// os detection script
function is_os($os)
{
    $useragent = strtolower($_SERVER['HTTP_USER_AGENT']);

    // detect windows
    if ((strpos($useragent, 'winnt') !== false) OR (strpos($useragent, 'win32') !== false) OR (strpos($useragent, 'windows') !== false))
    {
        $found_os = 'windows';
    }
        
    // detect macintosh
    if (strpos($useragent, 'mac') !== false)
    {
        $found_os = 'mac';
    }

    // detect linux
    if ((strpos($useragent, 'linux') !== false) OR (strpos($useragent, 'x11') !== false) OR (strpos($useragent, 'i686') !== false))
    {
        $found_os = 'linux';
    }

    // detect web tv
    if (strpos($useragent, 'webtv') !== false)
    {
        $found_os = 'webtv';
        // I left this code in because I have no idea why you put it there... :P
        /*
        preg_match('#webtv/([0-9\.]+)#', $useragent, $regs);
        $found_os = $regs[1];
        */
    }

    // sanitize the incoming os name
    $os = strtolower($os);
    if (substr($os, 0, 3) == 'is_')
    {
        $os = substr($os, 3);
    }
    
    if ($os === $found_os)
    {
        return true;
    }
    else
    {
        return false;
    }
}
// #################### End is os ########################## 


[Marco van Herwaarden]

Looks better to me

[neocorteqz]

Originally Posted by Revan

The first error I detect is that you have a parse error on this line:

PHP Code:

        if ((strpos($useragent, 'linux') !== false) AND (strpos($useragent, 'x11') !== false) AND (strpos($useragent, 'i686') !== false)) 


You had 1 parenthesis too many at the end there
I'll keep testing this function, then race ya to get it working first

And here is the complete working function. For obvious reasons, I have not been able to test linux, mac or webtv, you might want to get someone using those os'es (is webtv an OS though? )

PHP Code:

// #################### Start is os ##########################
// os detection script
function is_os($os)
{
    $useragent = strtolower($_SERVER['HTTP_USER_AGENT']);

    // detect windows
    if ((strpos($useragent, 'winnt') !== false) OR (strpos($useragent, 'win32') !== false) OR (strpos($useragent, 'windows') !== false))
    {
        $found_os = 'windows';
    }
        
    // detect macintosh
    if (strpos($useragent, 'mac') !== false)
    {
        $found_os = 'mac';
    }

    // detect linux
    if ((strpos($useragent, 'linux') !== false) OR (strpos($useragent, 'x11') !== false) OR (strpos($useragent, 'i686') !== false))
    {
        $found_os = 'linux';
    }

    // detect web tv
    if (strpos($useragent, 'webtv') !== false)
    {
        $found_os = 'webtv';
        // I left this code in because I have no idea why you put it there... :P
        /*
        preg_match('#webtv/([0-9\.]+)#', $useragent, $regs);
        $found_os = $regs[1];
        */
    }

    // sanitize the incoming os name
    $os = strtolower($os);
    if (substr($os, 0, 3) == 'is_')
    {
        $os = substr($os, 3);
    }
    
    if ($os === $found_os)
    {
        return true;
    }
    else
    {
        return false;
    }
}
// #################### End is os ########################## 


Thanks. and Here's how to test.

Firefox's useragent switcher plugin.

Seeing as this is based on useragent string, you can change it to anything other than windows to test it.

and webtv isn't an os, But i wanted it included for the Remote posibility that someone may actually be using it. Doubtful, but you never know.


Thanks again everyone.

Edit:
@ Revan

Did you want to release this? i was planning on releasing this after i finished it.

If you don't I'll of course release with you credited as a main contributer along with anyone else that contributed in this thread.

[Revan]

You need it more than I - you haven't even gotten your coder title yet
Besides it was your idea, we merely helped you
Credits will do fine. *waves hand* Credits will do fine. [/Qui-Gon Jinn]

Ye of course, I never thought of the user agent switcher plugin. I got the bugger installed too

Hm I just took a look at your first post, and it appears like you tried to submit multiple arguments to the function - do you want/need it to do this?

[neocorteqz]

Originally Posted by Revan

You need it more than I - you haven't even gotten your coder title yet
Besides it was your idea, we merely helped you
Credits will do fine. *waves hand* Credits will do fine. [/Qui-Gon Jinn]

Ye of course, I never thought of the user agent switcher plugin. I got the bugger installed too

Hm I just took a look at your first post, and it appears like you tried to submit multiple arguments to the function - do you want/need it to do this?

Lol, even if I had one by some freakish chance, I'm far from "Coder", i still have a lot to learn.

release as soon as I post it.

[T3MEDIA]

thats hot. listen to the list maybe you should have a condition to see what contry the user is from.

THEN>>>>>>> oh ho ho ho your phases could instantly change... like google does.

do that... and users will worship you as a god with big brests and azz.