Kill 1 Query In BBCode Manager (ACP)

While looking through bbcode.php in admincp/, i noticed that a global query was executed on all of it's pages, however only 2 actions need this query to be executed, so its a useless query on other pages within the BBCode Manager.

In admincp/bbcode.php
Find:

PHP Code:

$bbcodes = $DB_site->query("SELECT bbcodetag, bbcodereplacement, twoparams FROM " . TABLE_PREFIX . "bbcode");
$searcharray = array();
$replacementarray = array();
$doubleRegex = "/(\[)(%s)(=)(['\"]?)([^\"']*)(\\4])(.*)(\[\/%s\])/siU";
$singleRegex = "/(\[)(%s)(])(.*)(\[\/%s\])/siU";

while ($bbcode = $DB_site->fetch_array($bbcodes))
{
    if ($bbcode['twoparams'])
    {
        $regex = sprintf($doubleRegex, $bbcode['bbcodetag'], $bbcode['bbcodetag']);
    }
    else
    {
        $regex = sprintf($singleRegex, $bbcode['bbcodetag'], $bbcode['bbcodetag']);
    }
    $searcharray[] = $regex;
    $replacementarray[] = $bbcode['bbcodereplacement'];
} 


Replace It With:

PHP Code:

if($_REQUEST['do'] == "test" || $_REQUEST['do'] == "modify"){

    $bbcodes = $DB_site->query("SELECT bbcodetag, bbcodereplacement, twoparams FROM " . TABLE_PREFIX . "bbcode");
    $searcharray = array();
    $replacementarray = array();
    $doubleRegex = "/(\[)(%s)(=)(['\"]?)([^\"']*)(\\4])(.*)(\[\/%s\])/siU";
    $singleRegex = "/(\[)(%s)(])(.*)(\[\/%s\])/siU";

    while ($bbcode = $DB_site->fetch_array($bbcodes))
    {
        if ($bbcode['twoparams'])
        {
            $regex = sprintf($doubleRegex, $bbcode['bbcodetag'], $bbcode['bbcodetag']);
        }
        else
        {
            $regex = sprintf($singleRegex, $bbcode['bbcodetag'], $bbcode['bbcodetag']);
        }
        $searcharray[] = $regex;
        $replacementarray[] = $bbcode['bbcodereplacement'];
    }
} 


I know it's not much, but every little helps!

- Zero Tolerance

[Corriewf]

Yeah, I dont run my air conditioning much in my car but when it needs to be charged I am filling that chit up.

[eva01_]

maybe we will have to create our own forum code that whenever there is a problem it gets fixed no matter how small. :P

either way, great catch zero ^^

[Paul M]

Given some of the very minor bugs they have fixed I find that reply very strange.

[Corriewf]

Yeah, given that the excuse for updating vb versions everyday is discovering problems and fixing them right away..................................

[neocorteqz]

And such a simple fix too. as I see, it's only two lines.

When i upgrade I'll be sure to apply this.

[Zero Tolerance]

Originally Posted by neocorteqz

And such a simple fix too. as I see, it's only two lines.

When i upgrade I'll be sure to apply this.

Yeah, the code is just wrapped in an if statement, easy as pie

- Zero Tolerance

[neocorteqz]

Originally Posted by Zero Tolerance

Yeah, the code is just wrapped in an if statement, easy as pie

- Zero Tolerance

You would figure it's such a quick modification they would consider it.

[diettalk]

Isn't reducing a query a good thing... especially on busy boards?

[Oblivion Knight]

Originally Posted by diettalk

Isn't reducing a query a good thing... especially on busy boards?

It doesn't really matter in the Admin CP so much.. Still if a query can be killed where it isn't needed, that can only be a good thing and I don't see why Jelsoft aren't taking this into consideration.

[neocorteqz]

Originally Posted by Oblivion Knight

It doesn't really matter in the Admin CP somuch.. Still if a query can be killed where it isn't needed, that canonly be a good thing and I don't see why Jelsoft aren't taking thisinto consideration.

Now if my admin panel would load faster, I'd be a happy camper.

I agree with you. For the query minded. This would make us happy.