Bug or install error?

I've got a problem that I think is a bug due to everything else going perfect for the install.

Basically, if you make like certain armor or weapons usable by only one class type.

Someone can edit their character to that class, buy those items and then change their class to whatever else they want and they will still keep the items.

For example, if you made a plate armor that only warriors could use and mages could only use robes.

The mage player could edit their character to a warrior, buy the plate armor and then edit their character back to a mage and they'd keep the plate armor on :dead:

I haven't seen anything about this posted except for one person that hinted at having found a major bug but hasn't seen a thread about it.

Thinking this is the one he was referring too...

Any ideas on how to fix it?

[Revan]

Armor (please note the difference between Armor and Shield type) are currently not being prohibited, yes.
The fix is hassle to test, so I didn't, but you feel free to test it for me.

File: battleupdate.php
Find (BOTH instances of):

PHP Code:

                    rpgrace, 


Add BELOW:

PHP Code:

                    rpgtype, 


Find:

PHP Code:

                    $defense = $DB_site->query_first("SELECT damage FROM " . TABLE_PREFIX . "rpg_items WHERE itemid='$opparmor[id]'");
                    if ($defense['damage'] > 0) 
                    {
                        $armor = $armor + $defense['damage'];
                    } 


Replace with:

PHP Code:

                    $defense = $DB_site->query_first("SELECT damage, type FROM " . TABLE_PREFIX . "rpg_items WHERE itemid='$opparmor[id]'");
                    if ($defense['damage'] > 0) 
                    {
                        $opparmortype = explode(' ', $defense['type']);
                        if (in_array($opponent['rpgtype'], $opparmortype))
                        {
                            $armor = $armor + $defense['damage'];
                        }
                    } 


IMPORTANT: To test this fix, do the following BEFORE doing the above:

1. Set $battledebug to 1 in battleupdate.php
2. Make yourself have armor your not supposed to have
3. Let both combatants have weapons they ARE supposed to have
4. Let your opponent attack you (thus having your illegal armor reduce the damage
5. Note down the second last Debug Variable under Damage Done
6. Apply the fix
7. Upload the file
8. Let your opponent attack you (thus in theory having the armor not count)
9. Compare the second last Debug Variable under Damage Done to the value you saw before

If the fix worked, the Armor should have no effect.

PS: I will add an error message like the "your weapon is for a different class" in v3.

Thanks for helping me make this hack better


//peace

[Cyricx]

Nope, didn't do the trick, didn't get an error or anything, but the debugs stayed the same.

Before the fix -

Debug Variables:
Anger ($anger): 1
Hit Chance ($hitchance): 0.49279003035213
Random Number ($randnum): 35
Regular Attack Bonus ($regattbonus): 6.0456592223288
Regular Defense Minus ($regdefminus): 3.145988105131
Damage Done ($damagedone): -1 == [floor((28 + 6.0456592223288) * 0.5 * 1 + 0 - 14 - 3.145988105131)]
Random Mad ($randmad): 10

After the fix -
Debug Variables:
Anger ($anger): 1
Hit Chance ($hitchance): 0.49279003035213
Random Number ($randnum): 22
Regular Attack Bonus ($regattbonus): 6.0456592223288
Regular Defense Minus ($regdefminus): 3.145988105131
Damage Done ($damagedone): -1 == [floor((28 + 6.0456592223288) * 0.5 * 1 + 0 - 14 - 3.145988105131)]
Random Mad ($randmad): 8

[Revan]

Goddamit!
Ok guess I have tomorrow's work cut out for me then
I'll either edit this post or make a new reply
because Im gonna fuggen do this even if it's the last thing I do!

[Cyricx]

Hehe, I'll happily test out anything you need bro

I can add in hacks like crazy, but when it comes to writting arrays and explode and all that my mind fragments into a trillion pieces

[Revan]

Well I can say that the fix works.
I just applied it, and here's the results:

BEFORE the fix:
Damage Done ($damagedone): 166 == [floor((82 + 839.48094618951) * 1 * 1 + 0 - 0 - 756.75105588525)]


AFTER the fix:
Damage Done ($damagedone): 109 == [floor((82 + 839.48094618951) * 1 * 1 + 0 - 54 - 756.75105588525)]

And 54 IS indeed the buff value I set the Armor I tested it with to be.

[Cyricx]

I'll double check my values on test. See if I can find out what I did wrong incase someone else repeats my mistake.