vB3 cron system

[filburt1]

The latest code block I posted is already at the global level. It would be easy for me to raise an error flag, but the problem is I would have to have a gargantuan tree of nested ifs (at least ten, more likely around 20) in order to gracefully have the code flow to the end of the file (the point at which the cron system resumes its work with the next job).

[g-force2k2]

so then are you trying to break the control of the cron job to stop the following scheduled cron jobs, because I see that you are logging the error that has occurred, and if thats the case couldn't you simple add a continue ; to end that section of the while loop in the file, after it the included cron php files are within the actual loop, it would then resume the next cron job after all, because the continue only breaks that certain loop.

Cheers,
g-force2k2

[filburt1]

To clear the ambiguity, I'm trying to make my custom cron job (vbms_checkmail.php) gracefully terminate and yield control to the next scheduled job (whatever.php), if there is any.

[g-force2k2]

Alright, then couldn't continue ; possibly do the trick?

Cheers,
g-force2k2

[filburt1]

That's actually a really good idea. The only problem would be that it could reference the wrong loop (for example, if I want to exit from within a loop).

Or wait, how would it work exactly? If continue is used in a function where there aren't even loops, would PHP just reversely traverse the code tree until it finds a loop, and then force the next iteration?

edit: http://www.php.net/continue for reference doesn't mention anything other than the freaky fact it supports an argument. I wish PHP was as clean as Java but as easy as it is now...

[g-force2k2]

Hmm... very interesting, I did some tests with continue ; in both an included file and a function and both returned errors, but something else did work.

PHP Code:

return ; 


It returns to the main script I am assuming here's the three php files that I made and when I told it to 'continue' or in this case 'return' it skipped the rest of the script.

numbermain.php

PHP Code:

<?php

error_reporting ( E_ALL & ~E_NOTICE ) ;

require_once ( "numberfunction.php" ) ;
while ( $x <= 35 ) :
    include ( "numbercount.php" ) ;
endwhile ;

?>

numbercount.php

PHP Code:

<?php

error_reporting ( E_ALL & ~E_NOTICE ) ;

global $x ;
$x++ ;
$dobreak = do_check ( $x ) ;
if ( $dobreak ) :
    return ;
endif ;

echo $x . "<br />" ;

?>

numberfunction.php

PHP Code:

<?php

error_reporting ( E_ALL & ~E_NOTICE ) ;

function do_check ( &$x ) 
{
    $dobreak = 0 ;
    if ( $x == 5 OR $x == 9 ) :
        $dobreak = 1 ;
    endif ;
    return $dobreak ;
}

?>

And the result was:

1
2
3
4
6
7
8
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36

Skipped five and nine as I had asked the script. Maybe that will help some.

Cheers,
g-force2k2

[filburt1]

Well remember that because PHP's file inclusion functions are essentially identical to the #include preprocessor directive in C--just dumps a file into another file--the code being run is this:

PHP Code:

<?php 

error_reporting ( E_ALL & ~E_NOTICE ) ; 

require_once ( "numberfunction.php" ) ; 
while ( $x <= 35 ) : 
    error_reporting ( E_ALL & ~E_NOTICE ) ; 

    function do_check ( &$x ) 
    { 
        $dobreak = 0 ; 
        if ( $x == 5 OR $x == 9 ) : 
            $dobreak = 1 ; 
        endif ; 
        return $dobreak ; 
    } 

endwhile ; 

?>

You always need braces surrounding an include or require when using control structures or loops: http://www.php.net/include/ (example 11-6)

[g-force2k2]

Originally Posted by filburt1

Well remember that because PHP's file inclusion functions are essentially identical to the #include preprocessor directive in C--just dumps a file into another file--the code being run is this:

Yeah I don't really know C ( or C++ ) at all, wanted to learn some, but you don't think that placing a return to return the the main cron control script, which would be exiting out of the inner cron script that is erroring woud do what you're looking to accomplish?

Cheers,
g-force2k2

[filburt1]

Originally Posted by g-force2k2

Yeah I don't really know C ( or C++ ) at all, wanted to learn some, but you don't think that placing a return to return the the main cron control script, which would be exiting out of the inner cron script that is erroring woud do what you're looking to accomplish?

Cheers,
g-force2k2

Bizarrely, it looks like that might work. However it looks like any death code would have to be within vbms_checkmail.php and none of its helper functions.

Handling Returns: It is possible to execute a return() statement inside an included file in order to terminate processing in that file and return to the script which called it. Also, it's possible to return values from included files. You can take the value of the include call as you would a normal function.

[filburt1]

Interestingly, it looks like exit; will work. vB registers a shutdown function via register_shutdown_function() named exec_cron() that will, hopefully, cause the cron jobs to continue to run.