latest threads in forumdisplay.php?

i want to show the latest 10 threads, pulled from all forums in forumdisplay.php. i have this code:

// get latest threads
$forums=$DB_site->query("SELECT * FROM forum WHERE active=1");
$forumids='forumid IN (0';
while ($forum=$DB_site->fetch_array($forums)) {
  $getperms=getpermissions($forum['forumid']);
  if ($getperms[canview]) {
    $forumids .= "," . $forum['forumid'];
  }
}
$forumids.=')';

unset($forum);

$getthreads=$DB_site->query("SELECT * FROM thread WHERE $forumids AND visible=1 ORDER BY lastpost DESC LIMIT 10");
while ($lastthread=$DB_site->fetch_array($getthreads)) {
  $threadid=$lastthread[threadid];
  $titleextra='';
  if (strlen($lastthread[title])>32) {
    $titleextra="...";
  }
  $threadtitle=substr($lastthread[title], 0, 29);
}

eval("\$lastthreadbits .= \"".gettemplate('home_threadbits')."\";");

everything is working fine... hmm the problem is that it's making me jump from 21 to 40!!!! queries. is there a way to cache somehow those pesky queries? thanks for your help.

[TECK]

i was wondering if any of the big guns can look at the file ensemble and let me know if there is some wierd code i have in there?
i have a modified forumdisplay.php file that does what it shows in this pic:
News Page

for some reason, even with the right perms set for a usergroup, it will still show the last threads in the hidden forums.
also, i added comments in that file so you can easy follow the changes i did and evaluate better the code.
firefly or PPN, i would apreciate your help on this. if interested, let me know and i will PM the modified file.

thanks.

[Scott MacVicar]

email me then
scott.macvicar@vbulletin.org

Just leaving for school I will check in once i get there.

try setting $bbuserinfo[usergroupid] to 1 in the query

[TECK]

thanks PPN. i emailed you the file.

[Scott MacVicar]

PHP Code:

$doperms=$DB_site->query("SELECT canview,forumid FROM forumpermission WHERE usergroupid='$bbuserinfo[usergroupid]'");
while ($doperm = $DB_site->fetch_array($doperms)) {
  $perms["$doperm[forumid]"] = $doperm;
}
$DB_site->free_result($doperms);
unset($doperm);

$forum=$DB_site->query("SELECT forumid FROM forum");
while ($forums=$DB_site->fetch_array($forum)) {
  if($perms["$forums[forumid]"]["canview"] == 1 || !isset($perms["$forums[forumid]"]["canview"])) {
    $forumperms[]=$forums["forumid"];
  }
}
$DB_site->free_result($forum);
unset($forums);
if(!empty($forumperms)) {
  $forumperms='AND forumid='.implode(' OR forumid=',$forumperms);
} 


i had a variable name wrong

[TECK]

thanks alot scott. when you have a chance, can you look at the file and let me know if there is any unbalanced code? i shrinked alot the forumdisplay.php file. just making sure someone with php experince can give me the ok on that.

i'm concerned about some unset queries and also about some errors that might be in there without knowing (for example the access array)...

[KuraFire]

Thanks Scott, your new code works just fine, I've included it in my newsportal hack and will give you credit.

[Scott MacVicar]

sure no problem, just glad to help.