Attachments as files

Well after alot of time leaving it in the beta hacks forums without any problems, I'm now moving it to the Full Releases, I'm satisfied that there isn't any bugs that need to be addressed. Thanks to Jawelin he pointed out most of the mistakes through alot of his testing.
I've attached it as an installer file here, as it needs to make changes to the database. Two new rows to settings and a new column in the attachment table.

Scott

Updated some more

Note the > is missing off the bottom of the file after the ?, add it before trying to install

[Wolf42]

I added (like the instruction told) the line twice

Worked perfectly! Thanks PPN!

[Scott MacVicar]

do it twice, its the addition of the function which removes the attachment file.

[NitroSimSev]

Ok the issue was of all things the ? didnt have the > after it. Question regarding the functions.php editing portion. The first step says to "REPLACE from that point to the end of the function with". When I do this step it crashes the functions.php any ideas?

[Scott MacVicar]

define crashes?

you get a parse error?

if you want send me your functions.php to software@pp-network.com and I'll add that of the hack to your file and mail it back.

[pdaGuy]

I tried to test this on my local site, on a Windows PC and I get this error...

Fatal error: Call to undefined function: cpheader() in c:\appserv\www\vbulletin\attachment_install.php on line 112

I get the same error on my live site too! Any ideas?

I also want to ask something else.
If everything goes well and I install this hack, will it be possible to upgrade to a new version of vBulletin in the future?
I mean, this hack edits the database! What will happen when vBulletin v3.x comes out??

[Scott MacVicar]

move the file into the admin folder, it needs to check authorisation to make sure your an admin.

[Scott MacVicar]

It will make upgrading to vB3 a problem as your attachments will be files but they will expect it to be in database, but I'll be rewriting the hack for v3 so there won't be a problem about upgrading. You upgrade as normal then apply the new version of the hack to make it work with 3.0

[JJR512]

The instructions do NOT say to add that line twice. I have "Attachments as Files v1.0". In the section for "Changes to
editpost.php (1)", it says,

editpost.php

Step 1 of 1 FIND:


$DB_site->query("DELETE FROM attachment WHERE attachmentid=$postinfo[attachmentid]");


ABOVE that add

removeattachment($postinfo[attachmentid]);

And that's it.

OK, so I edited my file to put the new bit in twice, once in each spot.

Now some people have told me that they cannot see some of the attachments. I am not having that problem, even after clearing my browser cache, I can still see all attachments fine. I tried posting a new attachment, and I could also see that fine, too. So far, one other person has said he can also see it, while several people have told me they cannot see it. I don't understand this problem at all. How come some people can see attachments (whether post-hack or pre-hack), while some people cannot see any attachments?

[Scott MacVicar]

have you tried to view the same attachment?

It could be a problem with the type of attachment that it was, though I doubt this as the only part that has been changed is where the content is taken from for the attachment. If the place it takes it from is empty then they would experience a problem. If not does their usergroup have permissions to view attachments?

[Sean]

I posted my problem about not being able to download attachments..(only the admin could). Did you ever get that problem. Or was it fixed? I may just restore a backup, and re-install anyway..