Infraction Hook

[Chris.08i]

Originally Posted by MarkFL

Do you mean then a deduction based only on the points being issued at the time, and not on the cumulative total of active points? If so, I would have to investigate to see how to retrieve that value.

The code I posted does exactly the opposite of that...it uses $userinfo['ipoints'] which does not include the points currently being given, but rather the number of points accumulated by the user before the current infraction.

edit: Try using the hook location "infraction_update_complete", and at that hook, the points for the current infraction is in $vbulletin->GPC['points']. Then you can base the rep deduction on that and update the user table.

No, the current script works fine. I want it to deduct based on the current active points, so using ipoints is correct.

However, I don't want to issue and deduction when the user is only issued a warning (infraction without points).

[MarkFL]

If you use the code I posted in post #8, then the deduction will be based on the accumulated active points prior to the infraction being issued. So, for example, suppose a user has 3 active points, and you then issue a warning...$userinfo['ipoints'] will be equal to 3.

But, if you use the hook location and variable I suggested in post #10, then $vbulletin->GPC['points'] will be equal to 0.

[Chris.08i]

Hi Mark

PHP Code:

global $vbulletin, $db, $userinfo;

if ($vbulletin->GPC['points'] == 0) {
    continue;
}

$points = $userinfo['ipoints'];
$rep = $userinfo['reputation'];

if ($points > 0)
{
    $newrep = ($rep - $points*500);
}
else
{
    $newrep = ($rep - 150);
}

$vbulletin->db->query_write("
    UPDATE " . TABLE_PREFIX . "user
    SET reputation = " . $newrep . "
    WHERE userid = " . $userinfo['userid']
); 


This is what my revised code looked like, on the hook that you suggested. I'm getting a server 500 error when I try to issue a warning.

Any ideas?

[Dragonsys]

why are you using continue without a loop?

I would remove this, it is rather pointless in that code:

PHP Code:

if ($vbulletin->GPC['points'] == 0) {
    continue;
} 


or comment it out until you are ready to do something with it. This might be the cause of your 500 error

[Chris.08i]

Originally Posted by Dragonsys

why are you using continue without a loop?

I would remove this, it is rather pointless in that code:

PHP Code:

if ($vbulletin->GPC['points'] == 0) {
    continue;
} 


or comment it out until you are ready to do something with it. This might be the cause of your 500 error

I am trying to prevent the bottom code from running if the infraction points being handed out = 0.

[Dragonsys]

That is not how your code is working. You need to put the bottom inside the if statement. I can post the code when I get home if someone doesn't beat to it

--------------- Added [DATE]1450838239[/DATE] at [TIME]1450838239[/TIME] ---------------

try this:

PHP Code:

global $vbulletin, $db, $userinfo;

if ($vbulletin->GPC['points'] != 0) {
    $points = $userinfo['ipoints'];
    $rep = $userinfo['reputation'];

    if ($points > 0)
    {
        $newrep = ($rep - $points*500);
    }
    else
    {
        $newrep = ($rep - 150);
    }

    $vbulletin->db->query_write("
        UPDATE " . TABLE_PREFIX . "user
        SET reputation = " . $newrep . "
        WHERE userid = " . $userinfo['userid']
    );
} 


[Chris.08i]

I tried that - it doesn't work.

I don't get the server 500 error anymore, but it no longer deducts points if the infraction points being handed out is > 0

[Dragonsys]

sorry, i think I read what you wanted backwards, try this:

PHP Code:

global $vbulletin, $db, $userinfo;

if ($vbulletin->GPC['points'] == 0) {
    $points = $userinfo['ipoints'];
    $rep = $userinfo['reputation'];

    if ($points > 0)
    {
        $newrep = ($rep - $points*500);
    }
    else
    {
        $newrep = ($rep - 150);
    }

    $vbulletin->db->query_write("
        UPDATE " . TABLE_PREFIX . "user
        SET reputation = " . $newrep . "
        WHERE userid = " . $userinfo['userid']
    );
} 


[Chris.08i]

Thanks for the reply.

I already have that exact code on my forums - yet it still does not work. It also doesn't make sense to me.

When I read your code, it basically only runs the deduction code when it ISNT an infraction, and IS a warning.

I want the deduction code to only run when there IS points applied to the infraction.

I hope I am making sense.

[Dragonsys]

ok, that is what I gave you the first time

PHP Code:

$vbulletin->GPC['points'] != 0 


but you said it didn't work. So I changed it to this:

PHP Code:

$vbulletin->GPC['points'] == 0 


So what determines an infraction vs a warning, in the code?

--------------- Added [DATE]1450845203[/DATE] at [TIME]1450845203[/TIME] ---------------

the continue you had in your code is what was causing the 500 error for you, as a continue is used to exit a loop, and you did not have a loop. So I moved the code you wanted to run when points is 0, to inside your if statement. Should it run when points is 0, or when it is not 0?