Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 General Discussions
FAQ Community Calendar Today's Posts Search

Closed Thread
 
Thread Tools Display Modes
  #11  
Old 09-01-2014, 05:28 PM
ozzy47's Avatar
ozzy47 ozzy47 is offline
 
Join Date: Jul 2009
Location: USA
Posts: 10,929
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Those are not errors, but warnings. They have always been suppressed it was just recently with PHP newer versions, they started showing again.
  #12  
Old 09-03-2014, 12:06 AM
Paul M's Avatar
Paul M Paul M is offline
 
Join Date: Sep 2004
Location: Nottingham, UK
Posts: 23,748
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Brandon Sheley View Post
I just upgraded a clients site to vb 4 and we're upgrading the vb3 style with vbulletin's built in upgrade tool. I went to go change out the logo and I get the Declaration errors mentioned a year ago in the OP... The advice is to hide PHP errors?

It seems it would be better for the company to fix the problem, not hide it.. :down:


actually it seems when I edit any stylevar.. well this will be an annoying job.. I'm sure the client will be asking me what the hell is wrong with vb4 when they see them too.. Thanks vBulletin
Regardless of your predictable rant, if you want to fix it, use the advice given.
You should however use SKIP_DS_ERRORS rather than SKIP_ALL_ERRORS, that restores the warning reporting to the same as used by vb2, vb3 and vb4 versions other than 4.2.2.
  #13  
Old 09-04-2014, 09:27 AM
Disco_Stu Disco_Stu is offline
 
Join Date: Apr 2012
Posts: 305
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I have to throw my two cents in here:

I run my own software business and have over 30 years experience developing software. I develop systems for telecoms, railroads and manufacturers and I can tell you that if I started suppressing errors instead of addressing and correcting them I would be out of business tomorrow.

Suppressing errors (hiding, covering up problems) is about the worst thing you can do as a developer. If customers find out you're doing that then they will never trust you again. This type of approach shows a complete lack of desire or ability to fix the underlying problems.

Would you want your plumber or auto mechanic to hide problems from you? Of courses not.

Ask yourself this: When you were first thinking about purchasing vBulletin and you found out that error messages were being suppressed would you still be willing to purchase it?
4 благодарности(ей) от:
49er, DemOnstar, ForceHSS, napy8gen
  #14  
Old 09-04-2014, 10:26 AM
doctorsexy's Avatar
doctorsexy doctorsexy is offline
 
Join Date: Mar 2011
Location: earth
Posts: 383
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Ask yourself this: When you were first thinking about purchasing vBulletin and you found out that error messages were being suppressed would you still be willing to purchase it?
Reply With Quote
The answer to that is, no.....
  #15  
Old 09-04-2014, 10:29 AM
ozzy47's Avatar
ozzy47 ozzy47 is offline
 
Join Date: Jul 2009
Location: USA
Posts: 10,929
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Well then there is not much web based software you would purchase then, as it has been a common practice for ever. If it was so bad, then the blame should fall on the people who created PHP, as they made it so the warnings could be suppressed.
  #16  
Old 09-04-2014, 04:44 PM
Disco_Stu Disco_Stu is offline
 
Join Date: Apr 2012
Posts: 305
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by ozzy47 View Post
Well then there is not much web based software you would purchase then, as it has been a common practice for ever. If it was so bad, then the blame should fall on the people who created PHP, as they made it so the warnings could be suppressed.
Most software development environments have the ability to suppress error messages. They also provide the ability to write completely illogical spaghetti code too but that doesn't mean it's good practice to use either option.
  #17  
Old 09-04-2014, 05:24 PM
ozzy47's Avatar
ozzy47 ozzy47 is offline
 
Join Date: Jul 2009
Location: USA
Posts: 10,929
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Leave my spaghetti code out of this.
  #18  
Old 09-04-2014, 05:53 PM
tbworld tbworld is offline
 
Join Date: Oct 2008
Posts: 2,126
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Disco_Stu View Post
I have to throw my two cents in here:

I run my own software business and have over 30 years experience developing software. I develop systems for telecoms, railroads and manufacturers and I can tell you that if I started suppressing errors instead of addressing and correcting them I would be out of business tomorrow.

Suppressing errors (hiding, covering up problems) is about the worst thing you can do as a developer. If customers find out you're doing that then they will never trust you again. This type of approach shows a complete lack of desire or ability to fix the underlying problems.

Would you want your plumber or auto mechanic to hide problems from you? Of courses not.

Ask yourself this: When you were first thinking about purchasing vBulletin and you found out that error messages were being suppressed would you still be willing to purchase it?
I do not believe that anyone was promoting masking constructional errors. The discussion (as I interpreted) was about interpretive/compiler warnings. Maybe I just misread.
  #19  
Old 09-04-2014, 06:26 PM
Mark.B Mark.B is offline
Senior Member
 
Join Date: Feb 2004
Posts: 1,354
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Disco_Stu View Post
I have to throw my two cents in here:

I run my own software business and have over 30 years experience developing software. I develop systems for telecoms, railroads and manufacturers and I can tell you that if I started suppressing errors instead of addressing and correcting them I would be out of business tomorrow.

Suppressing errors (hiding, covering up problems) is about the worst thing you can do as a developer. If customers find out you're doing that then they will never trust you again. This type of approach shows a complete lack of desire or ability to fix the underlying problems.

Would you want your plumber or auto mechanic to hide problems from you? Of courses not.

Ask yourself this: When you were first thinking about purchasing vBulletin and you found out that error messages were being suppressed would you still be willing to purchase it?
Well it was common knowledge when vBulletin 3 was released. Nobody seemed to mind then.
  #20  
Old 09-04-2014, 06:42 PM
ForceHSS ForceHSS is offline
 
Join Date: Apr 2008
Posts: 6,357
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Disco_Stu View Post
I have to throw my two cents in here:

I run my own software business and have over 30 years experience developing software. I develop systems for telecoms, railroads and manufacturers and I can tell you that if I started suppressing errors instead of addressing and correcting them I would be out of business tomorrow.

Suppressing errors (hiding, covering up problems) is about the worst thing you can do as a developer. If customers find out you're doing that then they will never trust you again. This type of approach shows a complete lack of desire or ability to fix the underlying problems.

Would you want your plumber or auto mechanic to hide problems from you? Of courses not.

Ask yourself this: When you were first thinking about purchasing vBulletin and you found out that error messages were being suppressed would you still be willing to purchase it?
I totally agree with what you have said this is why I put a link in my sig so any can find the fixes for the problems in 4.2.2
Closed Thread


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 10:54 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.05558 seconds
  • Memory Usage 2,269KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (6)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (10)post_thanks_box
  • (4)post_thanks_box_bit
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete