Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 Programming Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #11  
Old 10-07-2013, 11:12 PM
tbworld tbworld is offline
 
Join Date: Oct 2008
Posts: 2,126
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thanks @Lynne, I am not that familiar with vb3.

In vb4 if you view history -- in debug mode -- on one of the master templates. Is the compare done against the original XML file? -- if you happen to know.

Don't do any research, I can look through the code, if you do not know off hand.
Reply With Quote
  #12  
Old 10-08-2013, 01:13 AM
Lynne's Avatar
Lynne Lynne is offline
 
Join Date: Sep 2004
Location: California/Idaho
Posts: 41,180
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by tbworld View Post

In vb4 if you view history -- in debug mode -- on one of the master templates. Is the compare done against the original XML file? -- if you happen to know.
It can be against the original or against any saved configuration.
Reply With Quote
Благодарность от:
tbworld
  #13  
Old 10-08-2013, 01:45 AM
Digital Jedi's Avatar
Digital Jedi Digital Jedi is offline
 
Join Date: Oct 2006
Location: PopCulturalReferenceLand
Posts: 5,171
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I could tell you if my database hadn't went all wiggy today, since I had mine in admin only debug mode. But I can tell you that the last time I tried to revert a template in the Master Style, it just deleted it. So I don't think history is saved in the Master. But it seems unlikely the OP was editing his Master in debug mode. All your other styles will always keep the original, which is stored in the Master.
Reply With Quote
Благодарность от:
tbworld
  #14  
Old 10-08-2013, 02:15 AM
tbworld tbworld is offline
 
Join Date: Oct 2008
Posts: 2,126
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thanks @digital_Jedi,
What brought on my question was @Lynne's picture. I figured vb4 had a similar feature and occasionally users alter their master templates. Thanks for the additonal input, always welcomed
Reply With Quote
Благодарность от:
Digital Jedi
  #15  
Old 10-08-2013, 02:32 AM
Digital Jedi's Avatar
Digital Jedi Digital Jedi is offline
 
Join Date: Oct 2006
Location: PopCulturalReferenceLand
Posts: 5,171
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I think Lynne's picture is vB4. The {vb:variables} aren't in 3.
Reply With Quote
  #16  
Old 10-08-2013, 02:54 AM
tbworld tbworld is offline
 
Join Date: Oct 2008
Posts: 2,126
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

So I did a little research on this to make sure I knew what I was posting about. This is still rough folks.

From the original post, I should have told the vbulletin member to use history. Your first modification of a template, stores the default (template master) in the history stack.
1. In all cases this works, but in the master style it does not append the correct template version. It does work correctly in any user styles. [Minor Bug].

2. 'Default' in all cases refers to the current master style, not the original style in 'vbulletin-style.xml' or histoy stack[0].

3. The history stack[0] automatic entry should be equivalent to 'vbulletin-style.xml' or the original master style for a template.
a. This may not be true if you try to upload a new master style. I did not check this.

Example:

I accidentally edited a template in the master style. So in 'master style' I press 'Revert', to go back to the 'original' untouched master style template -- the same template that should reside in 'vbulletin-style.xml'.
BOOM! - This will delete the master template from the database. [Bug]. So don't press 'Revert' in the 'Master Style'.

Instead press 'History' and compare with 'History Stack[0]' -- the first history position stored.

Example:

My master template styles have been modified from the vbulletin originals. In the new style that I have created, on a particular template, it turned out to be an abomination. (I know this has never happen to anyone.)** So I press 'Show Default', which shows me the current master template: so I can compare.
This shows you the current 'default' master template. This does not show you vbulletin's 'original' template. This works correctly, in my opinion.

To see the 'original' template use 'History'.
Update: This is not always true, in nested children styles: 'History Stack[0] will resolve to the 'default' master template. My wish is that it would have appended the 'original' template in the history stack.
** We are not discussing weather my period should be inside or outside of the parenthetical marks.

Summery:

1.) Use 'Show Default' to compare to the current master template. 'View Original on 'controls block' works the same as 'Show Default' on template editor page, in all cases.

2.) Unless you save an 'original' master template in the history stack, you cannot be assured that a 'Original' compare version will be there.

3.) Do not try to revert a template in 'Master Style', you will delete the template.


Thank you: @Lynne, @Digital_Jedi, @ForceHSS, @Simon_Lloyd
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 07:11 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.04440 seconds
  • Memory Usage 2,238KB
  • Queries Executed 12 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (6)post_thanks_box
  • (3)post_thanks_box_bit
  • (6)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (3)post_thanks_postbit
  • (6)post_thanks_postbit_info
  • (6)postbit
  • (6)postbit_onlinestatus
  • (6)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete