Counting users online

[vbdarwin]

Originally Posted by kh99

Here's an xml file you can import as a product if you want, it will create the scheduled task and plugin for you. You still need to make the changes to includes/cron/usercount.php yourself.

ETA: I don't know what else I can do, if someone else thinks they can improve on this or has a different solution feel free to jump in.

Hello all, and thank you again for the support.

The resulting code should be like this:

PHP Code:

<?php

// ######################## SET PHP ENVIRONMENT ###########################
error_reporting(E_ALL & ~E_NOTICE);
if (!is_object($vbulletin->db))
{
    exit;
}

// SQL for creating table, do once before starting task (add your table prefix to the table name
//CREATE TABLE usercounts (
//time INT UNSIGNED NOT NULL DEFAULT '0',
//users SMALLINT UNSIGNED NOT NULL DEFAULT '0',
//guests SMALLINT UNSIGNED NOT NULL DEFAULT '0')

$datecut = TIMENOW - $vbulletin->options['cookietimeout'];

$guests = $vbulletin->db->query_first("
    SELECT COUNT(*) AS guests
    FROM " . TABLE_PREFIX . "session
    WHERE lastactivity > $datecut AND userid = 0
");

$users = $vbulletin->db->query_first("
    SELECT COUNT(DISTINCT userid) AS users
    FROM " . TABLE_PREFIX . "session
    WHERE lastactivity > $datecut AND userid != 0
");

$vbulletin->db->query_write(
    "UPDATE " . TABLE_PREFIX . "usercounts
            VALUES(" . TIMENOW . ", $users[users], $guests[guests])
");

build_datastore('usercount', serialize(array('users' => $users['users'], 'guests' => $guests['guests'])), 1);

$datastore_fetch[]="'usercount'";  

log_cron_action('', $nextitem, 1);

?>

Is it correct?

[kh99]

I apologize for making it confusing, so let's start over from the beginning.

1) Drop the table you created from the database (usercounts), delete includes/cron/usercount.php, and if you created a scheduled task or plugin, delete them.

2) Save the usercount.php attachment from this post and ftp it to includes/cron

3) Save the product-usercount.xml attachment and import it as a product. This will create the database table, the plugin, and the scheduled task.

4) To display the values put something like this code in a template:

<if condition="!empty($vbulletin->usercounts)">
{$vbulletin->usercounts[members]} Members, {$vbulletin->usercounts[guests]} Guests
</if>

Notes:
- The scheduled task is set to run every 15 minutes. If you want to run it at a different interval, you can use the Scheduled Task Manager to change it.
- I changed the database column "users" to "members" so it's not quite the same as the previous code.
- The counts will not display until the task runs at least once, so you can go to the "Scheduled Task Manager" and press the "Run Now" button to force it to run once if you want to.
- If you uninstall the product, it won't remove the database table.

[Lynne]

If they had Reputation here, I know I'd be repping kh99 for all his help!

[vbdarwin]

kh99, I have no words to thank you for the wonderful job! :up:

Only, I'm not able to format 'time' to a readable value.

However, this WORK and THANK YOU

--------------- Added [DATE]1289205457[/DATE] at [TIME]1289205457[/TIME] ---------------

Found!

FROM_UNIXTIME(time)

[kh99]

Originally Posted by vbdarwin

Found!

FROM_UNIXTIME(time)

I'm glad that worked out - we could change the column type for the time if you wanted to.