Forum Display Enhancements - Filter Closed Threads

vb 4.x version here

Description

This product allows to hide closed threads.

Features:

• Settings are forum-based
• Administrator can setup default state (hide or show)
• Administrator can allow user to switch filter setting or make it mandatory

Setup

Just import product XML

Configuration

ACP -> Forums & Moderators -> Forum Manager -> edit forum
Find section "Filter Closed Threads settings" and do necessary changes (usually, all ON).

(!) By default, filtering is disabled.

This mod is developped here: http://github.com/rcdesign/vb-filter_closed_threads . Patches are welcome.

history

v0.4
- hope that fixes unserialisation bug, reported by some members

v0.3
- small fixes for guests
- refactoring
- developnent moved to vb3.8

v0.2
- first public release

[Zarxrax]

I installed this mod and had some problems. It worked GREAT for me, but it caused some users to not be able to view my forums!

Unable to add cookies, header already sent.
File: /public_html/includes/class_core.php
Line: 3277

The users of my forum don't need this mod, but I desperately need it, so is there any way to limit it to only work for my account (administrator)?

[Zarxrax]

This plugin has a bug in the way it stores the cookie. I don't know enough about the code to be able to fix it, but I found out what is causing the problem.

If you allow the plugin to show the setting to the user, then some users will have a problem where the page wont properly load (the error message in my previous post)
I'm not sure why it only effects some users, but I noticed that the problem didn't effect me. However, one day, without having made any changes to my forum, the problem started effecting me as well.

But anyways, I tried taking out the part of the code that sets the cookie. After I did that, it started working again (but obviously you can't change the setting).

This is the code I removed, so I guess something in this is causing the problem:

if ($foruminfo['forumid'] AND $foruminfo['fct_allow_user_set'])
{
  // try to get saved state
  if ($vbulletin->userinfo['userid'] > 0)
  {
    // is state saved by user
    $fct_state_saved =
      array_key_exists("$foruminfo[forumid]", $vbulletin->userinfo['fct_data'])
        ? true
        : false;

    // get saved or default value
    $filterclosedthreads =
      $fct_state_saved
        // saved state
        ? $vbulletin->userinfo['fct_data']["$foruminfo[forumid]"]
        // default state
        : $foruminfo['fct_hide_by_default'];

    unset($fct_state_saved);
  }

  if (!empty($vbulletin->GPC['closed']))
  {
    $fct_temp_state =
      $vbulletin->GPC['closed'] == 'hide'
        ? 1
        : 0;

    if ($fct_temp_state != $filterclosedthreads)
    {
      global $usercache;

      // update saved state
      $filterclosedthreads = $fct_temp_state;

      if ($vbulletin->userinfo['userid'] > 0)
      {
        $fct_userid = $vbulletin->userinfo['userid'];

        // update cache
        if(isset($usercache["$fct_userid"]))
        {
          $usercache["$fct_userid"]['fct_data']["$foruminfo[forumid]"] =
            $filterclosedthreads;
        }

        // update user profile
        $vbulletin->userinfo['fct_data']["$foruminfo[forumid]"] =
          $filterclosedthreads;

        // init user data manager
        $fct_userdata =& datamanager_init('User', $vbulletin, ERRTYPE_STANDARD);
        $fct_userdata->set_existing($vbulletin->userinfo);
        $fct_userdata->save();

        unset($fct_userdata, $fct_userid);
      }
    }

    unset($fct_temp_state);
  }
}

[xorex]

in admin profile (id 1) error

Warning: unserialize() expects parameter 1 to be string, array given in [path]\includes\class_userprofile.php(141) : eval()'d code(7) : eval()'d code on line 1

другими словами если просматриваю профиль админа (c первым id ) вылазит эта ошибка ((

а в целом все работает

[Vitaly]

Please, report if attached version solve problems. Note, that it will reset user filters.

[xorex]

problem solved

[Vitaly]

Since no more bugs reported, last version moved to release.

[Skyline_GT]

Is it possible to not hide closed sticky threads?

[Vitaly]

Sorry, all new features will be added only to vb4.0 branch, if ever.