Foreach Loop

[Mythotical]

Thanks Tefra, will give it a go later.

EDIT: I just noticed something Tefra, in the code above you have it counting categories, why I had it that way I don't know, what I meant to count when viewing the main page you see a total number of files for that cat and all sub cats then a total for files under that main cat only. I'm still trying to figure that out, once I get the cats sorted, I'll post up my file count stuff.

--------------- Added [DATE]1200524647[/DATE] at [TIME]1200524647[/TIME] ---------------

Seems this line:

PHP Code:

$id = (empty($vbulletin->GPC['id'])) 0 : $vbulletin->GPC['id']; 


is causing this error:

Parse error: syntax error, unexpected T_LNUMBER in /downloads.php on line 96

I changed it to '0' but got an error of encapsed this and that. So I'm not sure about that line.

[Dismounted]

PHP Code:

$id = (empty($vbulletin->GPC['id'])) ? 0 : $vbulletin->GPC['id']; 


Missing ternary operator.

[Mythotical]

Duh, I was just looking at similar code in another file, didn't even think about that. Thanks Dismounted.

[Tefra]

sorry about the syntax error, the code above is based on my suggestion to calculate the entries of each category during the management of the categories and during the add, edit, delete and tje move of the entries.

If you decide to go with a multi-level structure the counting with queries during listing will be really ugly.

If you go with this structure for example

Downloads A
- Downloads ab | Downloads ac

You can't have it saying Downloads A total entries = 0 when the subs have entries inside.

[Marco van Herwaarden]

also shouldn't it be:

PHP Code:

$id = (empty($vbulletin->GPC['id']) ? 0 : $vbulletin->GPC['id']); 


Also as you are already using the GPC functions to only allow a numeric value, this is probably useless as it will already default to 0.

[Dismounted]

Marco, both methods are correct.

Marco is correct, however, that it is a redundant check - what should be checked is if the id is negative or not, which can be done using TYPE_UINT.