Change Vote Ability

As promised a few weeks ago, I finally found some time to make the much needed addition to allow users to change their votes in a poll. After examining the code a bit, I ended up reusing some of the vB code for this ... I hope this isn't a violation of the hacks rules. I read through them, and I think the code re-use is so small and specialized that it will be ok for redistribution via this forum. If it's not, please feel free to edit/lock this thread, I just ask that a moderator let me know what parts are unacceptable.

Here is the hack, it's fairly simple:

Open up poll.php:

At the bottom of the file, find ?>

Just above this, insert this code:

PHP Code:

// #################################### Change Vote ##########################################

if ($action=="changevote") 

{

  // other permissions?
  $permissions=getpermissions($forumid);
  if (!$permissions[canview] or !$permissions[canvote]) {
    show_nopermission();
  }

  $pollid=verifyid("poll",$pollid);
  $pollinfo=$DB_site->query_first("SELECT * FROM poll WHERE pollid='$pollid'");
  $voteinfo=$DB_site->query_first("SELECT * FROM pollvote WHERE userid='$bbuserinfo[userid]' AND pollid='$pollid'");

  $threadinfo=$DB_site->query_first("SELECT * FROM thread WHERE pollid='$pollid' AND open<>10");
  $threadcache[$threadinfo[threadid]]=$threadinfo;
  
  //check if poll is closed
  if (!$pollinfo[active] or !$threadinfo[open] or ($pollinfo[dateline]+($pollinfo[timeout]*86400)<time() and $pollinfo[timeout]!=0)){ //poll closed
     eval("standarderror(\"".gettemplate("error_pollclosed")."\");");
     exit;
  }

    //check if a user has already voted - abuse management
    if (!$uservoteinfo=$DB_site->query_first("SELECT userid FROM pollvote WHERE userid=$bbuserinfo[userid] AND pollid='$pollid'"))
    {
      //the user has not voted yet
      eval("standarderror(\"".gettemplate("error_userhasnotvoted")."\");");
      exit;
    }

    //Error checking complete, lets get the options
    $timenow = time();
    $DB_site->query("DELETE FROM pollvote WHERE pollid='$pollid' AND userid='$bbuserinfo[userid]' LIMIT 1");

    $splitvotes=explode("|||",$pollinfo[votes]);
    $splitvotes[$voteinfo[voteoption]-1]--;

    $counter=0;
    while ($counter<$pollinfo[numberoptions]) {
      $votesstring.="|||".intval($splitvotes[$counter]);
      $counter++;
    }
    if (substr($votesstring,0,3)=="|||") {
      $votesstring=substr($votesstring,3);
    }

    $DB_site->query("UPDATE poll SET votes='".addslashes($votesstring)."' WHERE pollid='$pollid'");

    //make last reply date == last vote date
    if ($updatelastpost){ //option selected in CP
      $DB_site->query("UPDATE thread SET lastpost=$timenow WHERE threadid=$threadinfo[threadid]");
    }

    // redirect
    eval("standardredirect(\"".gettemplate("redirect_pollchange")."\",\"showthread.php?s=$session[sessionhash]&threadid=$threadinfo[threadid]\");");
  } 


Save poll.php and upload it.

In your templates, you will need to add two templates and modify 1 existing one.

First:

Add template " error_userhasnotvoted "

The text of the template should be: 

You have not voted on this thread, so you can not change your vote.

Second:

Add template " redirect_pollchange "

The text of the template should be:

You have deleted your vote.  You will be taken to the poll, where you will be allowed to revote.

Lastly:

Edit your "showthread_pollresults_voted" template.

Change the text to:

You have already voted on this poll!
<BR>If you wish to change your vote, click <a href="poll.php?action=changevote&pollid=$pollinfo[pollid]">here</a>.

That's it...

Now your users will have the option to erase thier vote and revote. Not <i>quite</i> as elegant as allowing them to actually revote, but it will suffice for now ... at least for me. Someone feel free to expand on this if they want something a bit more robust.

Thanks, and good luck!

-Flare

Originally posted by Flare
Where is this error generated? Can you show me a on your system?

Parse error when woting, and view result
Parse error: parse error in C:\HTTPD\upload\poll.php on line 532

[Flare]

Can you send me your poll.php?

My email is: flare@cohort.cc

I haven't tried this with the latest VB, I'm running 2.0.0 ... but I can't imagine anything has changed in poll.php between the two versions.

Only other thing I can think of off the top of my head is that you are running it on a windows box compared to my linux box... but I don't think that would affect it either.

Originally posted by Flare
Can you send me your poll.php?

My email is: flare@cohort.cc

I haven't tried this with the latest VB, I'm running 2.0.0 ... but I can't imagine anything has changed in poll.php between the two versions.

Only other thing I can think of off the top of my head is that you are running it on a windows box compared to my linux box... but I don't think that would affect it either.

I dont know much about this but shouldn't the new templates be mentioned in the $templatesused at the top of poll.php?? Did try that but no good,

[Flare]

No, that $templatesused variable isn't referenced anywhere else in poll.php. To be honest, I'm not even sure why it's there.

I tried installing this hack on a clean copy of poll.php and it worked fine. I have no clue what your issues could be, if you send me a copy of your poll.php, I'll run a compare against mine and see what's different.

OK here it comes

[Flare]

PHP Code:

 // redirect
    eval("standardredirect(\"".gettemplate("redirect_pollchange")."\",\"showthread.php?s=$session[sessionhash]&threadid=$threadinfo[threadid]\");");
  } 


 // redirect
    eval("standardredirect(\"".gettemplate("redirect_pollchange")."\",\"showthread.php?s=$session[sessionhash]&threadid=$threadinfo[threadid]\");");
  }

// redirect
eval("standardredirect(\"".gettemplate("redirect_p ollchange")."\",\"showthread.php?s=$session[sessionhash]&threadid=$threadinfo[threadid]\");");
}

[Flare]

Ok... well, I found your problem. Which is exposing a problem with vBulletin itself. Very strange.

I'm on a dialup so I can't debug it very easily right now.. perhaps the VB programmers can take a look at this.

If you look at my original post, you'll see this line:

PHP Code:

 // redirect
    eval("standardredirect(\"".gettemplate("redirect_pollchange")."\",\"showthread.php?s=$session[sessionhash]&threadid=$threadinfo[threadid]\");");
  } 


at the bottom of the [ PHP ] tag.

If you'll look closely, the slash is missing from that line when viewed.

If you go edit that message, that quote shows up in the edit box.

You'll see above that the slash exists in the above [ php ] block. The code was cut and pasted from the edit box of the first message, it is identical to the first PHP block in the first message...

Currently, I have no explanation for this. I'll try to look at it more on Monday, but no guarentees. If the vB programmers can take a look at it and see what is causing the parse error, it'd be greatly appreciated.

To solve Jbb and AJ's problem, however, is simple. Just pull the code out of the edit box, not directly from the post page. You are missing an escaping slash (and possibly more), which is generating your parse error. When I tried installing it on a fresh poll.php, I used the copy from the edit box, which is why it worked for me, and not for you two.

Ok It works now, That is to bad that you have been trubbled with such a tiny error, sorry!! But I could never have found it myself,
One little slash....... and the empire shakes. Btw It is a very nice featuer to have in the poll's. Good job

I don't understand what to fix right now. Can you post the fix here?

Thanks,
Aunt

OK sroll down to the end of your poll.php, at the end of the last line you will see that there is a slash missing,

// redirect
eval("standardredirect(\"".gettemplate("redirect_p ollchange")."\",\"showthread.p hp?s=$session[sessionhash]&threadid=$threadinfo[threadid]\");");
}