Secondary Group Permissions Issue

I don't allow regular members play the arcade. I only allow supporters or VIP members. If I set a regular members secondary group to VIP they still can't play the arcade, but if I set the primary group to VIP they can.

Note: When the users secondary permission is set to VIP the permissions work fine everywhere on the site, it's only the arcade that has the problem.

I am currently running the most recent version
ibProArcade v2.5.6+

[jiffy]

I'd be willing to kick in $20 for this. I have one forum that could use this. Switching to using only secondary user groups isn't really an option. It would be nice if it could function like other hacks where it looks to either the primary or secondary usergroup for the permissions. Not one or the other.

[butty]

cool nice one mr jiffy. we got $70 up to now then in the pot is anyone else up for chipping in and givin mr zp a offer he cant refuse to sort this for us

[RaceJunkie]

With all the installs it has I can't believe there would not be more..

[jiffy]

I got a PM from "Sarcoth" saying he got it sorted out and if I sent him my donation he would send me the details on fixing it. Anyone else get that PM?

I got a PM from "Sarcoth" saying he got it sorted out and if I sent him my donation he would send me the details on fixing it. Anyone else get that PM?

[RaceJunkie]

Originally Posted by jiffy

I got a PM from "Sarcoth" saying he got it sorted out and if I sent him my donation he would send me the details on fixing it. Anyone else get that PM?

I got a PM from "Sarcoth" saying he got it sorted out and if I sent him my donation he would send me the details on fixing it. Anyone else get that PM?

I received the pm as well. There was no cost mentioned in the PM, only a link that I have not looked at yet. I don't want to do anything to dis-respect MrZero since he has put all the time into this mod. I will wait and see if he comes up with anything first.

[MrZeropage]

I talked to him and it is no real fix, just a hardcoded solution to once make sure certain secondary usergroups are checked. For any changes you need to alter PHP-Files again ...

So this is not what I understand as a real "fix" or "addon" to make ibProArcade check both primary and secondary usergroups.

I will try to look on that particular thing (but a real fix) for the upcoming v2.5.8+ release but can't promise anything yet

[RaceJunkie]

Originally Posted by MrZeropage

I talked to him and it is no real fix, just a hardcoded solution to once make sure certain secondary usergroups are checked. For any changes you need to alter PHP-Files again ...

So this is not what I understand as a real "fix" or "addon" to make ibProArcade check both primary and secondary usergroups.


I will try to look on that particular thing (but a real fix) for the upcoming v2.5.8+ release but can't promise anything yet

Well a look into is better than nothing at all. I don't mind doing any php edits for a temp fix, but before I spend the money on that I'll wait untill you release the next version.

[butty]

mr zp. dya think there is any chance of you implementing this issue in any version soon? i really need this for my forums and have been looking 6 months. its cool if you have no plans to add it in the future just let me know and i can look at paying a coder to implement the feature for me

thanks for your time

[MGSteve]

I can't believe it doesn't treat permissions in the same way that vBulletin does. Sadly, I've only just found out it doesn't work as it should after I've set everything else up, spending 3 hours in the process.

Likewise, I'll gladly donate $25 IF you get this to work correctly with vBulletin's permission system, frankly I'm amazed you haven't done so already, given the pledges on this thread.

Not to mention, I'd have thought the majority of people installing this system will want to tie it into the subscription system & thus the usergroups.

Erm, I think I've done it anyway! It didn't appear to be very hard to do - so I'm thinking I've missed something! But it appears to work on my setup anyway....

Delete this out of the mod_arcade.php file...

        $DB->query("SELECT m.id, m.name, m.posts, m.arcade_ban, m.times_played, m.is_arcade_mod AS is_mod,
       			m.fav_games AS favs, m.user_sort, m.user_order, m.user_g_pp, m.membergroupids,
                    m.user_s_pp, m.def_g_cat, m.game_skin, m.arcade_mod_privs, m.arcade_pmactive, g.g_access_cp AS is_admin,
                    g.arcade_access, g.p_require, g.max_play, g.ppd_require, g.ibpa_cats AS allowed_categories
        	    FROM ibf_members AS m
                    LEFT JOIN ibf_groups AS g
                    ON (m.mgroup = g.g_id)   
                    WHERE id=".$ibforums->member['id']." LIMIT 0, 1");
        $this->user = $DB->fetch_row();

// use ON (m.membergroupids = g.g_id) in above Query for secondary Usergroup

and replace with

         // Mod by MGSteve to support vBulletin Secondary Groups.

        // We don't limit the number of rows returned now, so we'll get one row for each usergroup they're 
        // part of. So, we save the first row as we did before, but we then go through & merge all the usergroup category 
        // permissions and save this in the allowed_categories field of the $this->user array.
        
        $DB->query("SELECT m.id, m.name, m.posts, m.arcade_ban, m.times_played, m.is_arcade_mod AS is_mod,
       			m.fav_games AS favs, m.user_sort, m.user_order, m.user_g_pp, m.membergroupids,
                    m.user_s_pp, m.def_g_cat, m.game_skin, m.arcade_mod_privs, m.arcade_pmactive, g.g_access_cp AS is_admin,
                    g.arcade_access, g.p_require, g.max_play, g.ppd_require, g.ibpa_cats AS allowed_categories
        	    FROM ibf_members AS m, ibf_groups AS g 
                    WHERE 
                    (m.mgroup = g.g_id OR m.membergroupids = g.g_id)
                    AND
                    id={$ibforums->member['id']}");
        
        // Ok, how many rows have we got?
        $nRowMax = $DB->get_num_rows();
        $this->user = $DB->fetch_row();
        
        if ($nRowMax > 1)
        {
          // No point doing this if we've only returned one row!!
          for ($nRowCnt = 0;$nRowCnt < $nRowMax;$nRowCnt++)
          {
            if ($nRowCnt == 0)
              // We've already got the first row!
              $Row = $this->user;
            else
              $Row = $DB->fetch_row();

            $Cats[] = $Row['allowed_categories'];
          }
          
          // Ok, now collapse the array down into a Comma Seperated String (as stored in the DB)
          $Cats = implode(',',$Cats);
          // And save this back over the allowed_categories field in the first row.
          $this->user['allowed_categories'] = $Cats;
          unset($Cats);
          unset($Row);
          unset($nRowCnt);
          unset($nRowMax);
        }

[MrZeropage]

Thanks, will check this out and will integrate it in v2.5.9+ if everythink is ok with it